| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
implement Davi's review suggestions (post-push fixes)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug#31621: Windows server hanging during shutdown using named pipes
and idle connection
Problem: when idle pipe connection is forcefully closed with KILL
statement or when the server goes down, thread that is closing connection
would hang infinitely in CloseHandle(). The reason for the hang is that
named pipe operations are performed synchronously. In this mode all IOs
on pipe are serialized, that is CloseHandle() will not abort ReadFile()
in another thread, but wait for ReadFile() to complete.
The fix implements asynchrnous mode for named pipes, where operation of file
are not synchronized. Read/Write operation would fire an async IO and wait for
either IO completion or timeout.
Note, that with this patch timeouts are properly handled for named pipes.
Post-review: Win32 timeout code has been fixed for named pipes and shared
memory. We do not store pointer to NET in vio structure, only the read and
write timeouts.
|
| |\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The problem is that the read and write methods of the shared
memory transport (protocol) didn't react to asynchornous close
events, which could lead to a lock up as the client would wait
(until time out) for a server response that will never come.
The solution is to also wait for close events while waiting
for I/O from or to the server.
Bug report and patch submitted by: Armin Schöffmann
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
The problem is that the read and write methods of the shared
memory transport (protocol) didn't react to asynchronous close
events, which could lead to a lock up as the client would wait
(until time out) for a server response that will never come.
The solution is to also wait for close events while waiting
for I/O from or to the server.
|
| | |
| |
| |
| |
| | |
- Remove bothersome warning messages. This change focuses on the warnings
that are covered by the ignore file: support-files/compiler_warnings.supp.
- Strings are guaranteed to be max uint in length
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Faster thr_alarm()
Added 'Opened_files' status variable to track calls to my_open()
Don't give warnings when running mysql_install_db
Added option --source-install to mysql_install_db
I had to do the following renames() as used polymorphism didn't work with Forte compiler on 64 bit systems
index_read() -> index_read_map()
index_read_idx() -> index_read_idx_map()
index_read_last() -> index_read_last_map()
|
| |\ \
| | |
| | |
| | | |
into quadxeon.mysql.com:/benchmarks/ext3/TOSAVE/tsmith/bk/maint/jun05/51
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
(first part)
The following type conversions was done:
- Changed byte to uchar
- Changed gptr to uchar*
- Change my_string to char *
- Change my_size_t to size_t
- Change size_s to size_t
Removed declaration of byte, gptr, my_string, my_size_t and size_s.
Following function parameter changes was done:
- All string functions in mysys/strings was changed to use size_t
instead of uint for string lengths.
- All read()/write() functions changed to use size_t (including vio).
- All protocoll functions changed to use size_t instead of uint
- Functions that used a pointer to a string length was changed to use size_t*
- Changed malloc(), free() and related functions from using gptr to use void *
as this requires fewer casts in the code and is more in line with how the
standard functions work.
- Added extra length argument to dirname_part() to return the length of the
created string.
- Changed (at least) following functions to take uchar* as argument:
- db_dump()
- my_net_write()
- net_write_command()
- net_store_data()
- DBUG_DUMP()
- decimal2bin() & bin2decimal()
- Changed my_compress() and my_uncompress() to use size_t. Changed one
argument to my_uncompress() from a pointer to a value as we only return
one value (makes function easier to use).
- Changed type of 'pack_data' argument to packfrm() to avoid casts.
- Changed in readfrm() and writefrom(), ha_discover and handler::discover()
the type for argument 'frmdata' to uchar** to avoid casts.
- Changed most Field functions to use uchar* instead of char* (reduced a lot of
casts).
- Changed field->val_xxx(xxx, new_ptr) to take const pointers.
Other changes:
- Removed a lot of not needed casts
- Added a few new cast required by other changes
- Added some cast to my_multi_malloc() arguments for safety (as string lengths
needs to be uint, not size_t).
- Fixed all calls to hash-get-key functions to use size_t*. (Needed to be done
explicitely as this conflict was often hided by casting the function to
hash_get_key).
- Changed some buffers to memory regions to uchar* to avoid casts.
- Changed some string lengths from uint to size_t.
- Changed field->ptr to be uchar* instead of char*. This allowed us to
get rid of a lot of casts.
- Some changes from true -> TRUE, false -> FALSE, unsigned char -> uchar
- Include zlib.h in some files as we needed declaration of crc32()
- Changed MY_FILE_ERROR to be (size_t) -1.
- Changed many variables to hold the result of my_read() / my_write() to be
size_t. This was needed to properly detect errors (which are
returned as (size_t) -1).
- Removed some very old VMS code
- Changed packfrm()/unpackfrm() to not be depending on uint size
(portability fix)
- Removed windows specific code to restore cursor position as this
causes slowdown on windows and we should not mix read() and pread()
calls anyway as this is not thread safe. Updated function comment to
reflect this. Changed function that depended on original behavior of
my_pwrite() to itself restore the cursor position (one such case).
- Added some missing checking of return value of malloc().
- Changed definition of MOD_PAD_CHAR_TO_FULL_LENGTH to avoid 'long' overflow.
- Changed type of table_def::m_size from my_size_t to ulong to reflect that
m_size is the number of elements in the array, not a string/memory
length.
- Moved THD::max_row_length() to table.cc (as it's not depending on THD).
Inlined max_row_length_blob() into this function.
- More function comments
- Fixed some compiler warnings when compiled without partitions.
- Removed setting of LEX_STRING() arguments in declaration (portability fix).
- Some trivial indentation/variable name changes.
- Some trivial code simplifications:
- Replaced some calls to alloc_root + memcpy to use
strmake_root()/strdup_root().
- Changed some calls from memdup() to strmake() (Safety fix)
- Simpler loops in client-simple.c
|
| |\ \ \
| |/ /
|/| /
| |/ |
into pilot.blaudden:/home/msvensson/mysql/bug26664/my51-bug26664
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- The "mysql client in mysqld"(which is used by
replication and federated) should use alarms instead of setting
socket timeout value if the rest of the server uses alarm. By
always calling 'my_net_set_write_timeout'
or 'my_net_set_read_timeout' when changing the timeout value(s), the
selection whether to use alarms or timeouts will be handled by
ifdef's in those two functions.
- Move declaration of 'vio_timeout' into "vio_priv.h"
|
| |\ \
| |/
| |
| | |
into mysql.com:/home/kent/bk/main/mysql-5.1
|
| | |
| |
| |
| | |
Changed header to GPL version 2 only
|
| | |
| |
| |
| |
| |
| |
| | |
(Mostly in DBUG_PRINT() and unused arguments)
Fixed bug in query cache when used with traceing (--with-debug)
Fixed memory leak in mysqldump
Removed warnings from mysqltest scripts (replaced -- with #)
|
| | |\
| | |
| | |
| | | |
into zippy.cornsilk.net:/home/cmiller/work/mysql/bug14262/my50-bug14262
|
| | | | |
|
| | |\ \
| | | |
| | | |
| | | | |
into shellback.(none):/home/msvensson/mysql/mysql-5.0-maint
|
| | |\ \ \
| | | | |
| | | | |
| | | | | |
into zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.0-maint
|
| |\ \ \ \ \
| | |_|/ /
| |/| | |
| | | | | |
into shellback.(none):/home/msvensson/mysql/work/my51-work
|
| | |/ / / |
|
| | |\ \ \
| | |_|/
| |/| |
| | | | |
into maint2.mysql.com:/data/localhome/tsmith/bk/50
|
| |\ \ \ \
| | |_|/
| |/| |
| | | | |
into zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.1-maint
|
| | |/ /
| | |
| | |
| | | |
functions and return it.
|
| |\ \ \
| | |/
| |/|
| | | |
into zippy.cornsilk.net:/home/cmiller/work/mysql/mysql-5.1-maint
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Socket timeouts in client library were used only on Windows.
The solution is to use socket timeouts in client library on all
systems were they are supported.
No test case is provided because it is impossible to simulate network
failure in current test suit.
|
| | | | |
|
| | |/
|/| |
|
| | | |
|
| |\ \
| |/
| |
| | |
into ua141d10.elisa.omakaista.fi:/home/my/bk/mysql-5.0
|
| | |
| |
| |
| |
| | |
signal handlers are set up, the blocking flags for sockets are set,
and which thread-related functions are used. (Bug #8731)
|
| |\ \
| |/
| |
| | |
into moonbone.local:/work/12887-bug-5.0-mysql
|
| | |\
| | |
| | |
| | | |
into mysql.com:/home/jimw/my/mysql-4.1-clean
|
| | | | |
|
| |\ \ \
| |/ /
| | |
| | | |
into mysql.com:/home/jimw/my/mysql-5.0-clean
|
| | | | |
|
| | |\ \
| | |/
| |/|
| | | |
into selena.:H:/MYSQL/src/#05588-mysql-4.1
|
| | | |
| | |
| | |
| | | |
read timeout properly on win32.
|
| |\ \ \
| |/ /
| | |
| | | |
into mysql.com:/home/bk/mysql-5.0
|
| | | | |
|
| |\ \ \
| |/ /
| | |
| | | |
into mysql.com:/home/jimw/my/mysql-5.0-clean
|
| | | | |
|
| |\ \ \
| |/ /
| | |
| | | |
into bk-internal.mysql.com:/users/rburnett/mysql-5.0
|
| | | |
| | |
| | |
| | |
| | | |
viosocket.c:
Use ?: syntax to simplify code for setting both timeouts
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Added an extra parameter to all calls to timeout().
1 means we want to set the write timeout
0 means we wnat to set the read timeout
viossl.c:
Add which parameter to ssl timeout routine
vio_priv.h:
Added which parameter to vio_ignore_timeout and vio_ssl_timeout
violite.h:
Add which parameter to vio_timeout sigs
net_serv.cc:
Use proper which code in call to vio_timeout to set the proper timeout
viosocket.c:
Set the appropriate timeout in vio_timeout
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The patch implements the idea suggested by Olaf van der Spek in
thread "Client: many small reads?" (internals@lists.mysql.com).
Now small reads performed by the client library are buffered.
The buffering gives up to 2 times speedup when retrieving
one-column tables.
|
| |\ \ \
| |/ / |
|
| | |\ \
| | |/ |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
DIFFERENT host"
This fixes also the reverse lookup bug introduced by the previous patch
|
| |\ \ \
| |/ / |
|
| | |\ \
| | |/ |
|
| | | |
| | |
| | |
| | | |
always initialized. (Bug #5569)
|
