summaryrefslogtreecommitdiff
path: root/plugin/feedback
Commit message (Collapse)AuthorAgeFilesLines
* MDEV-17556 Assertion `bitmap_is_set_all(&table->s->all_set)' failedNikita Malyavin2021-01-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The assertion failed in handler::ha_reset upon SELECT under READ UNCOMMITTED from table with index on virtual column. This was the debug-only failure, though the problem is mush wider: * MY_BITMAP is a structure containing my_bitmap_map, the latter is a raw bitmap. * read_set, write_set and vcol_set of TABLE are the pointers to MY_BITMAP * The rest of MY_BITMAPs are stored in TABLE and TABLE_SHARE * The pointers to the stored MY_BITMAPs, like orig_read_set etc, and sometimes all_set and tmp_set, are assigned to the pointers. * Sometimes tmp_use_all_columns is used to substitute the raw bitmap directly with all_set.bitmap * Sometimes even bitmaps are directly modified, like in TABLE::update_virtual_field(): bitmap_clear_all(&tmp_set) is called. The last three bullets in the list, when used together (which is mostly always) make the program flow cumbersome and impossible to follow, notwithstanding the errors they cause, like this MDEV-17556, where tmp_set pointer was assigned to read_set, write_set and vcol_set, then its bitmap was substituted with all_set.bitmap by dbug_tmp_use_all_columns() call, and then bitmap_clear_all(&tmp_set) was applied to all this. To untangle this knot, the rule should be applied: * Never substitute bitmaps! This patch is about this. orig_*, all_set bitmaps are never substituted already. This patch changes the following function prototypes: * tmp_use_all_columns, dbug_tmp_use_all_columns to accept MY_BITMAP** and to return MY_BITMAP * instead of my_bitmap_map* * tmp_restore_column_map, dbug_tmp_restore_column_maps to accept MY_BITMAP* instead of my_bitmap_map* These functions now will substitute read_set/write_set/vcol_set directly, and won't touch underlying bitmaps.
* Merge 10.1 into 10.2Marko Mäkelä2019-05-136-6/+6
|\
| * Merge branch '5.5' into 10.1Vicențiu Ciorbaru2019-05-116-6/+6
| |\
| | * Update FSF addressMichal Schorm2019-05-106-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit is based on the work of Michal Schorm, rebased on the earliest MariaDB version. Th command line used to generate this diff was: find ./ -type f \ -exec sed -i -e 's/Foundation, Inc., 59 Temple Place, Suite 330, Boston, /Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, /g' {} \; \ -exec sed -i -e 's/Foundation, Inc. 59 Temple Place.* Suite 330, Boston, /Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, /g' {} \; \ -exec sed -i -e 's/MA.*.....-1307.*USA/MA 02110-1335 USA/g' {} \; \ -exec sed -i -e 's/Foundation, Inc., 59 Temple/Foundation, Inc., 51 Franklin/g' {} \; \ -exec sed -i -e 's/Place, Suite 330, Boston, MA.*02111-1307.*USA/Street, Fifth Floor, Boston, MA 02110-1335 USA/g' {} \; \ -exec sed -i -e 's/MA.*.....-1307/MA 02110-1335/g' {} \;
* | | MDEV-13384 - misc Windows warnings fixedVladislav Vaintroub2017-09-283-9/+9
| | |
* | | Merge 10.1 into 10.2Marko Mäkelä2017-05-231-1/+1
|\ \ \ | |/ /
| * | Merge 10.0 into 10.1Marko Mäkelä2017-05-231-1/+1
| |\ \
| | * | MDEV-6262 analyze the coverity report on mariadbSergei Golubchik2017-05-191-1/+1
| | | | | | | | | | | | | | | | | | | | uploaded 10.0, analyzed everything with the Impact=High (and a couple of Medium)
* | | | Merge branch '10.1' into 10.2Sergei Golubchik2017-03-306-11/+8
|\ \ \ \ | |/ / /
| * | | Correct FSF addressiangilfillan2017-03-106-6/+6
| | | |
| * | | base64 serviceSergei Golubchik2017-03-101-2/+0
| | | |
| * | | cleanup: generalize my_sha1.ccSergei Golubchik2017-03-101-3/+2
| | | | | | | | | | | | | | | | | | | | move most of the code into my_sha.ic, making it independent from the actual SHAx variant.
* | | | Merge branch '10.1' into 10.2Sergei Golubchik2016-12-292-3/+12
|\ \ \ \ | |/ / /
| * | | Merge branch '10.0' into 10.1Sergei Golubchik2016-09-291-2/+11
| |\ \ \ | | |/ /
| | * | Merge branch '5.5' into 10.0Sergei Golubchik2016-09-291-2/+11
| | |\ \ | | | |/
| | | * Feedback plugin : add support for Windows 10 / Server 2016.Vladislav Vaintroub2016-09-281-2/+11
| | | | | | | | | | | | | | | | Also add fallback version string for unknown future versions.
| * | | Make sure to recompile the feedback plugin for EMBEDDEDVicențiu Ciorbaru2016-09-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On OS X with clang 7.3.0 running any test as embedded crashes. As libfeedback was not compiled with embedded, we had 2 notions of THD, with different number of members. When calling inline functions defined in sql_class.h, the functions were defined for 1 THD but called on an object that is different. This resulted in erroneous data being returned and shortly after, a crash within the alloc_query() function. Recompile the feedback plugin for the embedded server specifically to not have such symbol conflicts.
* | | | name clash with gnutls on on base64_encodeSergei Golubchik2016-09-121-2/+2
| | | |
* | | | Merge branch '10.1' into 10.2Sergei Golubchik2016-06-301-0/+1
|\ \ \ \ | |/ / /
| * | | Merge branch '10.0' into 10.1Sergei Golubchik2016-06-281-0/+1
| |\ \ \ | | |/ /
| | * | Merge branch '5.5' into bb-10.0Sergei Golubchik2016-06-211-0/+1
| | |\ \ | | | |/
| | | * MDEV-9749 InnoDB receives 'Bad file descriptor' error, possibly related to ↵Sergei Golubchik2016-06-201-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | feedback plugin and MDEV-10250 InnoDB: Error: File (unknown): 'close' returned OS error 209. Cannot continue operation" after a failed connect() feedback plugin was continuing with the file descriptor, trying to send the data (which failed) and closing it at the end. Even though this fd might've been reused for something else already.
* | | | cleanup: thread_countSergei Golubchik2016-06-041-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | move thread_count handling into THD: * increment thread_count in THD constructor * decrement thread_count in THD destructor * never modify thread_count directly!
* | | | Reuse THD for new user connectionsMonty2016-06-041-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - To ensure that mallocs are marked for the correct THD, even if it's allocated in another thread, I added the thread_id to the THD constructor - Added st_my_thread_var to thr_lock_info_init() to avoid a call to my_thread_var - Moved things from THD::THD() to THD::init() - Moved some things to THD::cleanup() - Added THD::free_connection() and THD::reset_for_reuse() - Added THD to CONNECT::create_thd() - Added THD::thread_dbug_id and st_my_thread_var->dbug_id. These are needed to ensure that we have a constant thread_id used for debugging with a THD, even if it changes thread_id (=connection_id) - Set variables.pseudo_thread_id in constructor. Removed not needed sets.
* | | | Fixed plugins.feedback_plugin_send failureSergey Vojtovich2016-02-261-0/+1
| | | | | | | | | | | | | | | | | | | | Fixed assertion failure introduced along with MDEV-6150 (thd must be unlinked before calling "delete thd").
* | | | Merge branch '10.1' into 10.2Sergei Golubchik2016-02-252-2/+0
|\ \ \ \ | |/ / /
| * | | Merge branch '10.0' into 10.1Sergei Golubchik2016-02-232-2/+0
| |\ \ \ | | |/ /
| | * | Merge branch '5.5' into 10.0Sergei Golubchik2016-02-154-13/+99
| | |\ \ | | | |/
| | | * MDEV-9438 backport feedback-http-proxy to 5.5 and 10.0.Alexey Botchkov2016-02-094-13/+99
| | | | | | | | | | | | | | | | The http-proxy option to the FEEDBACK plugin backported.
* | | | MDEV-6150 Speed up connection speed by moving creation of THD to new threadMonty2016-02-071-3/+1
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Creating a CONNECT object on client connect and pass this to the working thread which creates the THD. Split LOCK_thread_count to different mutexes Added LOCK_thread_start to syncronize threads Moved most usage of LOCK_thread_count to dedicated functions Use next_thread_id() instead of thread_id++ Other things: - Thread id now starts from 1 instead of 2 - Added cast for thread_id as thread id is now of type my_thread_id - Made THD->host const (To ensure it's not changed) - Removed some DBUG_PRINT() about entering/exiting mutex as these was already logged by mutex code - Fixed that aborted_connects and connection_errors_internal are counted in all cases - Don't take locks for current_linfo when we set it (not needed as it was 0 before)
* | | Merge branch '10.0' into 10.1Sergei Golubchik2015-12-213-7/+8
|\ \ \ | |/ /
| * | Merge branch '5.5' into 10.0Sergei Golubchik2015-12-133-7/+8
| |\ \ | | |/
| | * MDEV-9161 feedback_plugin_send in debug buildsSergei Golubchik2015-12-081-0/+1
| | | | | | | | | | | | | | | | | | thd->cleanup_after_query() is needed to destroy all Items created for this query (and Item destructors free allocated Strings).
| | * feedback plugin compilation warningsSergei Golubchik2015-12-083-7/+7
| | |
* | | Merge branch '10.0' into 10.1Sergei Golubchik2015-11-193-4/+42
|\ \ \ | |/ /
| * | fix feedback plugin not to crash in debug buildsSergei Golubchik2015-11-191-1/+1
| | | | | | | | | | | | | | | feedback was bzero-ing thd->status_vars.memory_used, but server was asserting the correct value of it
| * | Merge branch '5.5' into 10.0Sergei Golubchik2015-11-183-3/+41
| |\ \ | | |/
| | * MDEV-9051 mysqld got signal 11, after upgrade to 10.1.8Sergei Golubchik2015-11-181-0/+1
| | | | | | | | | | | | feedback plugin needs to set tables->select_lex properly
| | * feedback plugin debugSergei Golubchik2015-11-183-3/+40
| | | | | | | | | | | | | | | | | | | | | | | | make it possible to change feedback plugin wait intervals * only in debug builds * and force the feedback report to be ignored update the test to use this feature
* | | Fixed compiler warnings and errorsMonty2015-10-091-1/+1
| | |
* | | MDEV-8431 Feedback plugin needs an option for http proxy.Alexey Botchkov2015-10-094-13/+101
| | | | | | | | | | | | | | | 'feedback_http_proxy' system variable added to specify the proxy server as host:port. Not a dynamic one.
* | | MDEV-6152: Remove calls to current_thd while creating ItemMonty2015-08-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | - Part 3: Adding mem_root to push_back() and push_front() Other things: - Added THD as an argument to some partition functions. - Added memory overflow checking for XML tag's in read_xml()
* | | Stage 2 of MDEV-6152:Monty2015-08-211-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | - Added mem_root to all calls to new Item - Added private method operator new(size_t size) to Item to ensure that we always use a mem_root when creating an item. This saves use once call to current_thd per Item creation
* | | MDEV-8010 - Avoid sql_alloc() in Items (Patch #1)Sergey Vojtovich2015-08-211-4/+4
| | | | | | | | | | | | | | | | | | | | | Added mandatory thd parameter to Item (and all derivative classes) constructor. Added thd parameter to all routines that may create items. Also removed "current_thd" from Item::Item. This reduced number of pthread_getspecific() calls from 290 to 177 per OLTP RO transaction.
* | | MDEV-7943 - pthread_getspecific() takes 0.76% in OLTP ROSergey Vojtovich2015-06-191-1/+1
| | | | | | | | | | | | | | | Pass THD to Item_field (and all derivatives) constructors. This reduces number of pthread_getspecific() calls from 322 to 292.
* | | Merge 10.0.14 into 10.1Sergei Golubchik2014-10-153-1/+22
|\ \ \ | |/ /
| * | MDEV-6274 Collation usage statisticsAlexander Barkov2014-08-113-1/+22
| | | | | | | | | | | | | | | Adding collation usage statistics into the feedback plugin I_S table.
* | | SHOW and FLUSH for I_S tables.Sergei Golubchik2014-10-111-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Extend existing plugins to support * SHOW QUERY_RESPONSE_TIME * FLUSH QUERY_RESPONSE_TIME * SHOW LOCALE move userstat tables to use the new API instead of hand-coded syntax
* | | fixing embedded: first set of changes (storage engines don't work yet)Sergei Golubchik2014-10-011-1/+0
| | |
* | | MDEV-6247: Merge 10.0-galera to 10.1.Jan Lindström2014-08-261-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Merged lp:maria/maria-10.0-galera up to revision 3879. Added a new functions to handler API to forcefully abort_transaction, producing fake_trx_id, get_checkpoint and set_checkpoint for XA. These were added for future possiblity to add more storage engines that could use galera replication.
View Lorry Controller Status