diff options
| author | Marko Mäkelä <marko.makela@mariadb.com> | 2020-02-11 18:44:26 +0200 |
|---|---|---|
| committer | Marko Mäkelä <marko.makela@mariadb.com> | 2020-02-11 18:44:26 +0200 |
| commit | fc2f2fa85306d80c317e76933264ba3d3675ed1c (patch) | |
| tree | 5f2beb7d399fa620968cb91687697e64eee48aab /storage/innobase/fil | |
| parent | 8ccb3caafb7cba0fca12e89c5c9b67a740364fdd (diff) | |
| download | mariadb-git-fc2f2fa85306d80c317e76933264ba3d3675ed1c.tar.gz | |
MDEV-19747: Deprecate and ignore innodb_log_optimize_ddl
During native table rebuild or index creation, InnoDB used to skip
redo logging and write MLOG_INDEX_LOAD records to inform crash recovery
and Mariabackup of the gaps in redo log. This is fragile and prohibits
some optimizations, such as skipping the doublewrite buffer for
newly (re)initialized pages (MDEV-19738).
row_merge_write_redo(): Remove. We do not write MLOG_INDEX_LOAD
records any more. Instead, we write full redo log.
FlushObserver: Remove.
fseg_free_page_func(): Remove the parameter log. Redo logging
cannot be disabled.
fil_space_t::redo_skipped_count: Remove.
We cannot remove buf_block_t::skip_flush_check, because PageBulk
will temporarily generate invalid B-tree pages in the buffer pool.
Diffstat (limited to 'storage/innobase/fil')
| -rw-r--r-- | storage/innobase/fil/fil0fil.cc | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/storage/innobase/fil/fil0fil.cc b/storage/innobase/fil/fil0fil.cc index 2d6cae8ce87..d579fd802de 100644 --- a/storage/innobase/fil/fil0fil.cc +++ b/storage/innobase/fil/fil0fil.cc @@ -2253,11 +2253,7 @@ fil_close_tablespace( buffer pool. Thus we can clean the tablespace out of the buffer pool completely and permanently. The flag stop_new_ops also prevents fil_flush() from being applied to this tablespace. */ - - { - FlushObserver observer(space, trx, NULL); - buf_LRU_flush_or_remove_pages(id, &observer); - } + buf_LRU_flush_or_remove_pages(id, true); /* If the free is successful, the X lock will be released before the space memory data structure is freed. */ |