MDEV-5535: Cannot reopen temporary table

mysqld maintains a list of TABLE objects for all temporary
tables created within a session in THD. Here each table is
represented by a TABLE object.

A query referencing a particular temporary table for more
than once, however, failed with ER_CANT_REOPEN_TABLE error
because a TABLE_SHARE was allocate together with the TABLE,
so temporary tables always had only one TABLE per TABLE_SHARE.

This patch lift this restriction by separating TABLE and
TABLE_SHARE objects and storing TABLE_SHAREs for temporary
tables in a list in THD, and TABLEs in a list within their
respective TABLE_SHAREs.

1 files changed, 3 insertions, 6 deletions

diff --git a/sql/wsrep_thd.cc b/sql/wsrep_thd.cc
index 3835c925745..36768a37973 100644
--- a/sql/wsrep_thd.cc
+++ b/sql/wsrep_thd.cc
@@ -360,13 +360,10 @@ static void wsrep_replication_process(THD *thd)
   mysql_cond_broadcast(&COND_thread_count);
   mysql_mutex_unlock(&LOCK_thread_count);
 
-  TABLE *tmp;
-  while ((tmp = thd->temporary_tables))
+  if(thd->has_thd_temporary_tables())
   {
-    WSREP_WARN("Applier %lld, has temporary tables at exit: %s.%s",
-               (longlong) thd->thread_id, 
-               (tmp->s) ? tmp->s->db.str : "void",
-               (tmp->s) ? tmp->s->table_name.str : "void");
+    WSREP_WARN("Applier %lld has temporary tables at exit.",
+               thd->thread_id);
   }
   wsrep_return_from_bf_mode(thd, &shadow);
   DBUG_VOID_RETURN;