summaryrefslogtreecommitdiff
path: root/sql/item_xmlfunc.h
diff options
context:
space:
mode:
authorMichael Widenius <monty@mariadb.org>2020-08-02 12:31:14 +0300
committerSergei Golubchik <serg@mariadb.org>2021-05-19 22:27:28 +0200
commit3105c9e7a5eb3706f6520e1566ed4a2add06c6a5 (patch)
tree628f083d286f970ac8358f882195ea834c16131e /sql/item_xmlfunc.h
parent451c4ae548fd4b0dda93ac499682e95b249bfcf4 (diff)
downloadmariadb-git-3105c9e7a5eb3706f6520e1566ed4a2add06c6a5.tar.gz
Change bitfields in Item to an uint16
The reason for the change is that neither clang or gcc can do efficient code when several bit fields are change at the same time or when copying one or more bits between identical bit fields. Updated bits explicitely with & and | is MUCH more efficient than what current compilers can do.
Diffstat (limited to 'sql/item_xmlfunc.h')
-rw-r--r--sql/item_xmlfunc.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/sql/item_xmlfunc.h b/sql/item_xmlfunc.h
index 806739d1139..3369304d79c 100644
--- a/sql/item_xmlfunc.h
+++ b/sql/item_xmlfunc.h
@@ -110,12 +110,12 @@ protected:
public:
Item_xml_str_func(THD *thd, Item *a, Item *b): Item_str_func(thd, a, b)
{
- maybe_null= TRUE;
+ flags|= ITEM_FLAG_MAYBE_NULL;
}
Item_xml_str_func(THD *thd, Item *a, Item *b, Item *c):
Item_str_func(thd, a, b, c)
{
- maybe_null= TRUE;
+ flags|= ITEM_FLAG_MAYBE_NULL;
}
bool fix_fields(THD *thd, Item **ref);
bool fix_length_and_dec();