diff options
author | Vicențiu Ciorbaru <cvicentiu@gmail.com> | 2016-02-16 00:33:53 +0200 |
---|---|---|
committer | Vicențiu Ciorbaru <cvicentiu@gmail.com> | 2016-02-16 00:43:57 +0200 |
commit | 0c223a96c12689157894c09f91aa2a5500937afb (patch) | |
tree | cf7c0be42543d4903ed49f4c909ce1cee23511c3 /sql/item_windowfunc.h | |
parent | 9a673e0a88cf7ab5eba8115edbd66d479ad38764 (diff) | |
download | mariadb-git-0c223a96c12689157894c09f91aa2a5500937afb.tar.gz |
Fix review comments.
Diffstat (limited to 'sql/item_windowfunc.h')
-rw-r--r-- | sql/item_windowfunc.h | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/sql/item_windowfunc.h b/sql/item_windowfunc.h index 7db98872b3a..202b0db406e 100644 --- a/sql/item_windowfunc.h +++ b/sql/item_windowfunc.h @@ -157,13 +157,18 @@ class Item_sum_dense_rank: public Item_sum_int { longlong dense_rank; List<Cached_item> orderby_fields; - /* TODO: implementation is missing */ - void clear() { + /* + XXX(cvicentiu) This class could potentially be implemented in the rank + class, with a switch for the DENSE case. + */ + void clear() + { dense_rank= 1; } bool add(); void update_field() {} - longlong val_int() { + longlong val_int() + { return dense_rank; } |