summaryrefslogtreecommitdiff
path: root/sql/item.cc
diff options
context:
space:
mode:
authorNorvald H. Ryeng <norvald.ryeng@oracle.com>2012-03-12 09:24:59 +0100
committerNorvald H. Ryeng <norvald.ryeng@oracle.com>2012-03-12 09:24:59 +0100
commitbedf97c93aa8665cef5e8d0865eecb56ac2b4d26 (patch)
treee81e5701323b0349293d6a96e507ecd3dae592c4 /sql/item.cc
parentc7a6ee1964ae0a9c51f86d69dccd15981a996b9c (diff)
parent2e72df370ba0b89cae9afd42b621326ab6dccd04 (diff)
downloadmariadb-git-bedf97c93aa8665cef5e8d0865eecb56ac2b4d26.tar.gz
Merge 5.1 => 5.5.
Diffstat (limited to 'sql/item.cc')
-rw-r--r--sql/item.cc16
1 files changed, 4 insertions, 12 deletions
diff --git a/sql/item.cc b/sql/item.cc
index 69821df986a..45ce1cac961 100644
--- a/sql/item.cc
+++ b/sql/item.cc
@@ -7078,20 +7078,12 @@ bool Item_insert_value::fix_fields(THD *thd, Item **items)
}
if (arg->type() == REF_ITEM)
+ arg= static_cast<Item_ref *>(arg)->ref[0];
+ if (arg->type() != FIELD_ITEM)
{
- Item_ref *ref= (Item_ref *)arg;
- if (ref->ref[0]->type() != FIELD_ITEM)
- {
- my_error(ER_BAD_FIELD_ERROR, MYF(0), "", "VALUES() function");
- return TRUE;
- }
- arg= ref->ref[0];
+ my_error(ER_BAD_FIELD_ERROR, MYF(0), "", "VALUES() function");
+ return TRUE;
}
- /*
- According to our SQL grammar, VALUES() function can reference
- only to a column.
- */
- DBUG_ASSERT(arg->type() == FIELD_ITEM);
Item_field *field_arg= (Item_field *)arg;