diff options
author | ingo@mysql.com <> | 2006-07-04 19:10:13 +0200 |
---|---|---|
committer | ingo@mysql.com <> | 2006-07-04 19:10:13 +0200 |
commit | 40c103478d11b8b90ffa9e1d9c18b0cb92536d62 (patch) | |
tree | c9392d011c4ed50df63ad84d1ffc540f6d4b2f21 /myisam | |
parent | ffd8ed17162333032e8d69454da5319c5d03b60b (diff) | |
parent | 99ad23ec7cde9db5f02ca7ac375b0050289d711f (diff) | |
download | mariadb-git-40c103478d11b8b90ffa9e1d9c18b0cb92536d62.tar.gz |
Merge mysql.com:/home/mydev/mysql-4.0-bug14400
into mysql.com:/home/mydev/mysql-4.1-bug14400
Diffstat (limited to 'myisam')
-rw-r--r-- | myisam/mi_rkey.c | 24 |
1 files changed, 18 insertions, 6 deletions
diff --git a/myisam/mi_rkey.c b/myisam/mi_rkey.c index de4cefb19b6..98e1a0a9a26 100644 --- a/myisam/mi_rkey.c +++ b/myisam/mi_rkey.c @@ -68,6 +68,7 @@ int mi_rkey(MI_INFO *info, byte *buf, int inx, const byte *key, uint key_len, if (fast_mi_readinfo(info)) goto err; + if (share->concurrent_insert) rw_rdlock(&share->key_root_lock[inx]); @@ -89,24 +90,35 @@ int mi_rkey(MI_INFO *info, byte *buf, int inx, const byte *key, uint key_len, case HA_KEY_ALG_BTREE: default: if (!_mi_search(info, keyinfo, key_buff, use_key_length, - myisam_read_vec[search_flag], info->s->state.key_root[inx])) + myisam_read_vec[search_flag], info->s->state.key_root[inx])) { - while (info->lastpos >= info->state->data_file_length) + /* + If we are searching for an exact key (including the data pointer) + and this was added by an concurrent insert, + then the result is "key not found". + */ + if ((search_flag == HA_READ_KEY_EXACT) && + (info->lastpos >= info->state->data_file_length)) + { + my_errno= HA_ERR_KEY_NOT_FOUND; + info->lastpos= HA_OFFSET_ERROR; + } + else while (info->lastpos >= info->state->data_file_length) { /* Skip rows that are inserted by other threads since we got a lock Note that this can only happen if we are not searching after an exact key, because the keys are sorted according to position */ - if (_mi_search_next(info, keyinfo, info->lastkey, - info->lastkey_length, - myisam_readnext_vec[search_flag], - info->s->state.key_root[inx])) + info->lastkey_length, + myisam_readnext_vec[search_flag], + info->s->state.key_root[inx])) break; } } } + if (share->concurrent_insert) rw_unlock(&share->key_root_lock[inx]); |