diff options
| author | Alexander Barkov <bar@mariadb.com> | 2018-05-21 13:26:16 +0400 |
|---|---|---|
| committer | Vladislav Vaintroub <wlad@mariadb.com> | 2018-05-21 16:34:11 +0000 |
| commit | 1e69d3f19616d2ac52608db4422a018930b32b0d (patch) | |
| tree | 9cadb4bb0459e6d723ca284f15ec98b1d4a25b50 /client/mysqldump.c | |
| parent | 7d91d98ac12a849eebc553989b706bb820b94d79 (diff) | |
| download | mariadb-git-1e69d3f19616d2ac52608db4422a018930b32b0d.tar.gz | |
Addressing Monty's review suggestions for MDEV-11952 Oracle-style packages (partial)
- Using array_elements() instead of a constant to iterate through an array
- Adding some comments
- Adding new-line function comments
- Using STRING_WITH_LEN instead of C_STRING_WITH_LEN
Diffstat (limited to 'client/mysqldump.c')
| -rw-r--r-- | client/mysqldump.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/client/mysqldump.c b/client/mysqldump.c index 694ce4a5134..dc87338aac2 100644 --- a/client/mysqldump.c +++ b/client/mysqldump.c @@ -2514,7 +2514,7 @@ static uint dump_routines_for_db(char *db) "Create Package Body"}; char db_name_buff[NAME_LEN*2+3], name_buff[NAME_LEN*2+3]; char *routine_name; - int i; + uint i; FILE *sql_file= md_result_file; MYSQL_ROW row, routine_list_row; @@ -2550,7 +2550,7 @@ static uint dump_routines_for_db(char *db) fputs("\t<routines>\n", sql_file); /* 0, retrieve and dump functions, 1, procedures, etc. */ - for (i= 0; i < 4; i++) + for (i= 0; i < array_elements(routine_type); i++) { my_snprintf(query_buff, sizeof(query_buff), "SHOW %s STATUS WHERE Db = '%s'", |