summaryrefslogtreecommitdiff
path: root/appveyor.yml
diff options
context:
space:
mode:
authorMarko Mäkelä <marko.makela@mariadb.com>2019-04-08 09:00:25 +0300
committerMarko Mäkelä <marko.makela@mariadb.com>2019-04-08 09:20:48 +0300
commit1e7ad5bb1c69dba8c7d721a2cfbbe98c7e900015 (patch)
tree56603cb31dae4c4092a1acb6c18097c73297f090 /appveyor.yml
parentd8303c3ee7750f4003e3561c3e60ee6e636bf9ad (diff)
downloadmariadb-git-1e7ad5bb1c69dba8c7d721a2cfbbe98c7e900015.tar.gz
MDEV-15584: Do not invoke open(dir=NULL)
On Linux, <fcntl.h> declares open(2) as having a nonnull first argument. In GCC 8, if a function with nonnull argument is called, that argument will be silently assumed to nonnull along the same code path. Hence, later nullness checks for this argument can be optimized away. Similar to MDEV-15587, the fix is to ensure that functions with nonnull arguments are not being called with NULL. This bug caused a crash in mysqlbinlog, which was invoking create_temp_file() with the argument dir=NULL. The affected test was binlog.binlog_mysqlbinlog_base64. It would display the following message before crashing: mysqlbinlog: O_TMPFILE is not supported on (null) (disabling future attempts) Segmentation fault
Diffstat (limited to 'appveyor.yml')
0 files changed, 0 insertions, 0 deletions