summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlasdair G Kergon <agk@redhat.com>2015-01-21 12:23:56 +0000
committerAlasdair G Kergon <agk@redhat.com>2015-01-21 12:23:56 +0000
commit7cfc9a4f640296679f2b860842cc8b25b82fd30f (patch)
tree6a26efecbb738db0b917cf48ee09705b813ec0d9
parent338d98be97428bd9202391abe705e7fe10ec5ce8 (diff)
downloadlvm2-7cfc9a4f640296679f2b860842cc8b25b82fd30f.tar.gz
libdevmapper: Improve incompatible version msg.
-rw-r--r--WHATS_NEW_DM1
-rw-r--r--libdm/ioctl/libdm-iface.c5
2 files changed, 4 insertions, 2 deletions
diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM
index 98f98b67c..0a5987575 100644
--- a/WHATS_NEW_DM
+++ b/WHATS_NEW_DM
@@ -1,5 +1,6 @@
Version 1.02.93 -
====================================
+ Report 'unknown version' when incompatible version numbers were not obtained.
Report more info from thin pool status (out of data, metadata-ro, fail).
Support error_if_no_space for thin pool target.
Fix segfault while using selection with regex and unbuffered reporting.
diff --git a/libdm/ioctl/libdm-iface.c b/libdm/ioctl/libdm-iface.c
index 4c37a539b..f8b4ed999 100644
--- a/libdm/ioctl/libdm-iface.c
+++ b/libdm/ioctl/libdm-iface.c
@@ -571,8 +571,9 @@ int dm_check_version(void)
dm_get_library_version(libversion, sizeof(libversion));
bad:
- log_error("Incompatible libdevmapper %s%s and kernel driver %s",
- libversion, compat, dmversion);
+ log_error("Incompatible libdevmapper %s%s and kernel driver %s.",
+ *libversion ? libversion : "(unknown version)", compat,
+ *dmversion ? dmversion : "(unknown version)");
_version_ok = 0;
return 0;