diff options
| author | Zdenek Kabelac <zkabelac@redhat.com> | 2016-01-19 16:07:39 +0100 |
|---|---|---|
| committer | Zdenek Kabelac <zkabelac@redhat.com> | 2016-01-20 13:44:47 +0100 |
| commit | 21028a7903a8ef78e3dbda6afbd245c1cae1aae8 (patch) | |
| tree | 6bebfaa11b19dde53b5e53af9c841338f50b4b33 | |
| parent | 7b5a8f61a79c88e9a99f3cec590163a143e70237 (diff) | |
| download | lvm2-21028a7903a8ef78e3dbda6afbd245c1cae1aae8.tar.gz | |
cleanup: reformat sentence about max sizes
The extent size must fits all blocks in 4294967295 sectors
(in 512b units) this is 1/2 KiB less then 2TiB.
So while previous statement 'suggested' 2TiB is still acceptable value,
make it clear it's not.
As now we support any multiples of 128KB as extent size -
values like 2047G will still 'flow-in' otherwise the largest power-of-2
supported value is 1TiB.
With 1TiB user needs 8388608 extents for 8EiB device.
(FYI such device is already unusable with todays glibc-2.22.90-27)
4GiB extent size is currently the smallest extent size which allows
a user to create 8EiB devices (with 2GiB it's less then 8EiB).
TODO: lvm2 may possibly print amount of 'lost/unused space' on a PV,
since using such ridiculously sized extent size may result in huge
space being left unaccessible.
| -rw-r--r-- | lib/metadata/metadata.c | 2 | ||||
| -rw-r--r-- | tools/toollib.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/lib/metadata/metadata.c b/lib/metadata/metadata.c index 0336d5d82..a7954904f 100644 --- a/lib/metadata/metadata.c +++ b/lib/metadata/metadata.c @@ -1093,7 +1093,7 @@ uint32_t extents_from_size(struct cmd_context *cmd, uint64_t size, if (size > (uint64_t) MAX_EXTENT_COUNT * extent_size) { log_error("Volume too large (%s) for extent size %s. " - "Upper limit is %s.", + "Upper limit is less then %s.", display_size(cmd, size), display_size(cmd, (uint64_t) extent_size), display_size(cmd, (uint64_t) MAX_EXTENT_COUNT * diff --git a/tools/toollib.c b/tools/toollib.c index dec9106a3..f2be8cb6f 100644 --- a/tools/toollib.c +++ b/tools/toollib.c @@ -777,7 +777,7 @@ int vgcreate_params_set_from_args(struct cmd_context *cmd, } if (arg_uint64_value(cmd, physicalextentsize_ARG, 0) > MAX_EXTENT_SIZE) { - log_error("Physical extent size cannot be larger than %s.", + log_error("Physical extent size must be smaller than %s.", display_size(cmd, (uint64_t) MAX_EXTENT_SIZE)); return 0; } |