summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZdenek Kabelac <zkabelac@redhat.com>2019-10-14 11:54:49 +0200
committerZdenek Kabelac <zkabelac@redhat.com>2019-10-14 15:13:33 +0200
commit76a9a86fd359681a598a6509eb90940c3a10f1f3 (patch)
treea5bd5f29cfcfb241b0d39b9a9cea8a35d0768b38
parentbd21736e8b082319e1a9a29e75badd906ee277f6 (diff)
downloadlvm2-76a9a86fd359681a598a6509eb90940c3a10f1f3.tar.gz
lvconvert: fix return value when zeroing fails
Use correct error return code for fail path.
-rw-r--r--WHATS_NEW1
-rw-r--r--tools/lvconvert.c2
2 files changed, 2 insertions, 1 deletions
diff --git a/WHATS_NEW b/WHATS_NEW
index 767973c0b..d530d9f79 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,6 @@
Version 2.03.06 -
================================
+ Fix cmd return when zering of cachevol fails.
Extend lvs to show all VDO properties.
Preserve VDO write policy with vdopool.
Increase default vdo bio threads to 4.
diff --git a/tools/lvconvert.c b/tools/lvconvert.c
index 60ab95661..caef5d5a5 100644
--- a/tools/lvconvert.c
+++ b/tools/lvconvert.c
@@ -5565,7 +5565,7 @@ static int _lvconvert_writecache_attach_single(struct cmd_context *cmd,
if (!_writecache_zero(cmd, lv_fast)) {
log_error("LV %s could not be zeroed.", display_lvname(lv_fast));
- return 0;
+ return ECMD_FAILED;
}
/*