diff options
author | Andreas Fenkart <afenkart@gmail.com> | 2015-07-17 09:13:05 +0200 |
---|---|---|
committer | Kalle Valo <kvalo@codeaurora.org> | 2015-08-06 10:09:09 +0300 |
commit | e9f21d403699a4d299a02df107326f11acecd13e (patch) | |
tree | 81b66a6c7542c48ad85b4769cb113089decc6090 /drivers/net/wireless/mwifiex/util.c | |
parent | aeb03000837eec7df4f57034106542efd60be02b (diff) | |
download | linux-e9f21d403699a4d299a02df107326f11acecd13e.tar.gz |
mwifiex: remove CMD_F_CANCELED flag
CMD_F_CANCELED was used to abort mwifiex_process_cmdresp in
case it already started or starts processing the cmd.
But this was probably not working the way intended:
- it is racy: mwifiex_process_cmdresp might already have passed that
test and is continuing to use the cmd node being recycled
- mwifiex_process_cmdresp repeatedly uses adapter->curr_cmd which
we just set to NULL
- mwifiex_recycle_cmd_node will clear the flag
The reason why it probably works is that mwifiex_cancel_pending_ioctl
is only called from mwifiex_cmd_timeout_func, where the there is little
chance of a command response still arriving
Signed-off-by: Andreas Fenkart <afenkart@gmail.com>
Acked-by: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/net/wireless/mwifiex/util.c')
0 files changed, 0 insertions, 0 deletions