| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As written by Martin Kletzander <mkletzan@redhat.com>:
Since commit 8eb55d782a2b9afacc7938694891cc6fad7b42a5, when you parse
and save an URI that has no server (or similar) part, two slashes
after the 'schema:' get lost. It means 'uri:///noserver' is turned
into 'uri:/noserver'.
basically
foo:///only/path
means a host of "" while
foo:/only/path
means no host at all
So the best fix IMHO is to fix the URI parser to record the first
case and an empty host string and the second case as a NULL host string
I would not revert the initial patch, we should not 'invent' those
slash, but we should instead when parsing keep the information that
it's a host based path and that foo:/// means the presence of a host
but an empty one.
Once applied the resulting patch below, all cases seems to be saved
properly:
thinkpad:~/XML -> ./testURI uri:/noserver
uri:/noserver
thinkpad:~/XML -> ./testURI uri:///noserver
uri:///noserver
thinkpad:~/XML -> ./testURI uri://server/foo
uri://server/foo
thinkpad:~/XML -> ./testURI uri:/noserver/foo
uri:/noserver/foo
thinkpad:~/XML -> ./testURI uri:///
uri:///
thinkpad:~/XML -> ./testURI uri://
uri://
thinkpad:~/XML -> ./testURI uri:/
uri:/
thinkpad:~/XML ->
If you revert the initial patch that last case fails
The problem is that I don't want to change the xmlURI structure to
minimize ABI breakage, so I could not extend the field. The natural
solution is to denote that uri:/// has an empty host by making
the uri server field an empty string which works very well but breaks
applications (like libvirt ;-) who blindly look at uri->server
not being NULL to try to reach it !
Simplest was to stick the port to -1 in that case, instead of 0
application don't bother looking at the port of there is no server
string, this makes the patch more complex than a 1 liner, but
is better for ABI.
|
|
|
|
|
|
|
| |
xmlCoreDepthFirstItertor and xmlCoreBreadthFirstItertr only
implement a python2-compatible iterator interface. The next()
method has been changed to __next__(). An alias has been
defined to keep python2 compatibility.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For https://bugzilla.gnome.org/show_bug.cgi?id=734280
libxml2 reports wrong error column numbers (field int2 in xmlError)
in structured error handler, after parsing XML attribute values.
Example XML:
<?xml version="1.0" encoding="UTF-8"?>
<root
xmlns="urn:colbug">&</root>
<!--
1 2 3 4
1234567890123456789012345678901234567890
-->
Expected location of the error would be line 3, column 21.
The actual location of the error is line 3, column 9:
$ ./xmlparse colbug2.xml
colbug2.xml:3:9: xmlParseEntityRef: no name
The 12 characters of the xmlns attribute value "urn:colbug" are
not accounted for in the error column value.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For https://bugzilla.gnome.org/show_bug.cgi?id=734276
libxml2 reports wrong error column numbers (field int2 in xmlError)
in structured error handler, after an XML declaration containing
whitespace.
Example XML:
<?xml version="1.0" encoding="UTF-8" ?><root>&</root>
<!--
1 2 3 4 5 6
123456789012345678901234567890123456789012345678901234567890
-->
Expected location of the error would be line 1, column 53.
The actual location of the error is line 1, column 44:
$ ./xmlparse colbug1.xml
colbug1.xml:1:44: xmlParseEntityRef: no name
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For https://bugzilla.gnome.org/show_bug.cgi?id=734363
When using xml schema validation, structured error callbacks do not get
passed a valid column number in xmlError field "int2".
$ ./xmlsaxparse colbug5.xml colbug5.xsd
colbug5.xml:3:0: Element '{urn:colbug5}bx': This element is not
expected.
Expected is ( {urn:colbug5}b ).
The schema error is reported for line 3, column 0 (= N/A).
I'd like to have the column number of the error passed in the xmlError
structure. With this test case: line 3, column 9.
|
|
|
|
|
|
|
|
| |
For https://bugzilla.gnome.org/show_bug.cgi?id=734328
Missing Null check could cause crash, if a pointer is dereferenced.
Found problem at two places in valid.c
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=733900
|
|
|
|
| |
For https://bugzilla.gnome.org/show_bug.cgi?id=733711
|
|
|
|
|
| |
For https://bugzilla.gnome.org/show_bug.cgi?id=733710
Reported by Gaurav but with slightly different fixes
|
|
|
|
|
| |
For https://bugzilla.gnome.org/show_bug.cgi?id=731511
Pointed byt vincent Lefevre
|
|
|
|
|
|
|
|
|
| |
The year and month need validating before being put into the
MAX_DAYINMONTH macro.
Coverity issue: #60436
https://bugzilla.gnome.org/show_bug.cgi?id=731990
|
|
|
|
|
|
| |
Coverity issue: #60439
https://bugzilla.gnome.org/show_bug.cgi?id=731990
|
|
|
|
|
|
|
|
|
|
| |
According to the documentation, gzdopen() does not close the FD on
failure (but does effectively close it on success, since gzclose()
closes it).
Coverity issues: #60440, #60441
https://bugzilla.gnome.org/show_bug.cgi?id=731990
|
|
|
|
|
|
| |
Coverity issue: #60442
https://bugzilla.gnome.org/show_bug.cgi?id=731990
|
|
|
|
|
|
|
|
| |
If not initialised, the ‘node’ member remains undefined.
Coverity issue: #60466
https://bugzilla.gnome.org/show_bug.cgi?id=731990
|
|
|
|
|
|
| |
For https://bugzilla.gnome.org/show_bug.cgi?id=732735
schematron little used code and xptr rely on XPath, fix the
configure script.
|
|
|
|
|
|
|
|
|
|
|
|
| |
For https://bugzilla.gnome.org/show_bug.cgi?id=732705
In _xmlSchemaDateAdd(), the check for |tmon| should be the following
since MAX_DAYINMONTH() expects a month in the range [1,12]:
if (tmon < 1)
tmon = 1;
Regression introduced in
https://git.gnome.org/browse/libxml2/commit/?id=14b5643947845df089376106517c4f7ba061e4b0
|
|
|
|
|
|
| |
For https://bugzilla.gnome.org/show_bug.cgi?id=730005
While using assert in libxml2 is really not a good idea, it's
still better to assert than crash
|
|
|
|
| |
Related to https://bugzilla.gnome.org/show_bug.cgi?id=731360
|
|
|
|
|
| |
For https://bugzilla.gnome.org/show_bug.cgi?id=731832
small fix
|
|
|
|
| |
For https://bugzilla.gnome.org/show_bug.cgi?id=732823
|
|
|
|
|
|
|
| |
For https://bugzilla.gnome.org/show_bug.cgi?id=733040
xmlDictLookup() may return NULL in case of allocation error,
though very unlikely it need to be checked.
|
|
|
|
|
|
|
|
| |
For https://bugzilla.gnome.org/show_bug.cgi?id=733041
check cur->parent before dereferencing the pointer even if
a null parent there should not happen
Also fix a typo
|
|
|
|
|
|
| |
For https://bugzilla.gnome.org/show_bug.cgi?id=733042
the states argument of xmlRelaxNGAddStates() ought to be checked too
|
|
|
|
|
|
|
|
| |
For https://bugzilla.gnome.org/show_bug.cgi?id=733043
There is missing Null condition in xmlRelaxNGValidateInterleave of
relaxng.c
Dereferencing it may cause a crash.
|
| |
|
|
|
|
|
|
|
|
|
| |
For https://bugzilla.gnome.org/show_bug.cgi?id=731063
xmlSaveUri() of libxml2 (snapshot 2014-05-31 and earlier) returns
bogus values when called with URIs that have rootless paths
(e.g. "urx:b:b" becomes "urx://b%3Ab" where "urx:b%3Ab" would be
correct)
|
|
|
|
| |
in SAX2 DOM building code and in the HTML parser
|
|
|
|
|
| |
let's make sure that parser options are updated too when a corrsponding
global variable or other field of the context is set.
|
|
|
|
|
|
|
|
| |
A number of issues have been raised after the fix, and this patch
tries to correct all of them, though most were related to
postvalidation.
https://bugzilla.gnome.org/show_bug.cgi?id=730290
and other reports on list, off-list and on Red Hat bugzilla
|
|
|
|
|
| |
Reported by Stefan Behnel
https://bugzilla.gnome.org/show_bug.cgi?id=724903
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cross-compiling the python bindings is a bit difficult today, as the
configure script will figure out the site packages dir
(PYTHON_SITE_PACKAGES) by either:
- Generating the path to the site-package target directories using
libdir, and see if it exists. As it is not possible to point to the
full path of the sysroot, since that will yield the wrong install
path, and that the directory does not neccessarily exist on the host,
this approach will not work.
- Fetch the site packages dir from the python interpreter as pointed to
by --with-python. Since this python interpreter will point to the
sysroot, the install dir generated will be inside the sysroot and thus
not work.
This patch approaches the problem by adding the possibility of
explicitly stating the install dir of the python packages, leaving it up
to the cross-compilation environment to specify it. The patch does not
affect the default case (non-cross compilation).
Signed-off-by: Jonas Eriksson <jonas.eriksson@enea.com>
|
|
|
|
| |
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
|
|
|
|
| |
Cut and paste error, using the wrong variable
|
|
|
|
|
| |
Fix a use before check on pointer
For https://bugzilla.gnome.org/show_bug.cgi?id=729849
|
|
|
|
|
| |
Cleanup
For https://bugzilla.gnome.org/show_bug.cgi?id=729851
|
|
|
|
|
| |
Unless explicitely asked for when validating or replacing entities
with their value. Problem pointed out by Daniel Berrange <berrange@redhat.com>
|
|
|
|
|
|
|
| |
Avoid freeing the currently set name until after having assigned the new name,
this allows one to call xmlNodeSetName (node, node->name + 1) to set the new
name of the node to a substring of the current name without introducing any
crash and without requiring an extra strdup().
|
| |
|
|
|
|
| |
Raised by Blasius Bieselbert on IRC
|
|
|
|
|
| |
Fixes a bug with predicates:
https://mail.gnome.org/archives/xml/2014-March/msg00014.html
|
|
|
|
|
|
| |
We really need to have ctxt->instate == XML_PARSER_CONTENT when
jumping in content parsing
Bug reported by Frank Gross
|
|
|
|
| |
For https://bugzilla.gnome.org/show_bug.cgi?id=708355
|
|
|
|
|
|
| |
xinclude needs xmlAddNextSibling().
Compile out use of xmlLocationSetPtr when xptr is disabled.
Include xpath header.
|
|
|
|
| |
Fix compilation with minimum and valid.
|
|
|
|
|
| |
Add a hard dependancy on tree.
Disable write and close callbacks when output is disabled.
|
|
|
|
| |
Fix compilation with minimum and legacy.
|