summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Veillard <veillard@redhat.com>2015-11-20 15:04:09 +0800
committerDaniel Veillard <veillard@redhat.com>2015-11-20 15:04:09 +0800
commit35bcb1d758ed70aa7b257c9c3b3ff55e54e3d0da (patch)
tree2b2cab2edfa88b6a2db8e2ba44aed391769b9d57
parentce0b0d0d81fdbb5f722a890432b52d363e4de57b (diff)
downloadlibxml2-35bcb1d758ed70aa7b257c9c3b3ff55e54e3d0da.tar.gz
Detect incoherency on GROWCVE-2015-7499-2
the current pointer to the input has to be between the base and end if not stop everything we have an internal state error.
-rw-r--r--parser.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/parser.c b/parser.c
index 1810f99f..ab007aaa 100644
--- a/parser.c
+++ b/parser.c
@@ -2075,9 +2075,16 @@ static void xmlGROW (xmlParserCtxtPtr ctxt) {
((ctxt->input->buf) && (ctxt->input->buf->readcallback != (xmlInputReadCallback) xmlNop)) &&
((ctxt->options & XML_PARSE_HUGE) == 0)) {
xmlFatalErr(ctxt, XML_ERR_INTERNAL_ERROR, "Huge input lookup");
- ctxt->instate = XML_PARSER_EOF;
+ xmlHaltParser(ctxt);
+ return;
}
xmlParserInputGrow(ctxt->input, INPUT_CHUNK);
+ if ((ctxt->input->cur > ctxt->input->end) ||
+ (ctxt->input->cur < ctxt->input->base)) {
+ xmlHaltParser(ctxt);
+ xmlFatalErr(ctxt, XML_ERR_INTERNAL_ERROR, "cur index out of bound");
+ return;
+ }
if ((ctxt->input->cur != NULL) && (*ctxt->input->cur == 0) &&
(xmlParserInputGrow(ctxt->input, INPUT_CHUNK) <= 0))
xmlPopInput(ctxt);