diff options
| author | Ján Tomko <jtomko@redhat.com> | 2019-06-14 09:17:39 +0200 |
|---|---|---|
| committer | Ján Tomko <jtomko@redhat.com> | 2019-06-24 09:36:00 +0200 |
| commit | 45ae5e529d4e886f47dacca9dfe5a08d95a3425a (patch) | |
| tree | 5265e39de91a8580911ca1622841a79ba9f0b6b5 | |
| parent | 4f50f36c0004af0faf0f535b46e2a1841c2443d8 (diff) | |
| download | libvirt-45ae5e529d4e886f47dacca9dfe5a08d95a3425a.tar.gz | |
api: disallow virConnect*HypervisorCPU on read-only connectionsv5.2-maint
These APIs can be used to execute arbitrary emulators.
Forbid them on read-only connections.
Fixes: CVE-2019-10168
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
(cherry picked from commit bf6c2830b6c338b1f5699b095df36f374777b291)
Signed-off-by: Ján Tomko <jtomko@redhat.com>
| -rw-r--r-- | src/libvirt-host.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/libvirt-host.c b/src/libvirt-host.c index e20d6ee250..2978825d22 100644 --- a/src/libvirt-host.c +++ b/src/libvirt-host.c @@ -1041,6 +1041,7 @@ virConnectCompareHypervisorCPU(virConnectPtr conn, virCheckConnectReturn(conn, VIR_CPU_COMPARE_ERROR); virCheckNonNullArgGoto(xmlCPU, error); + virCheckReadOnlyGoto(conn->flags, error); if (conn->driver->connectCompareHypervisorCPU) { int ret; @@ -1234,6 +1235,7 @@ virConnectBaselineHypervisorCPU(virConnectPtr conn, virCheckConnectReturn(conn, NULL); virCheckNonNullArgGoto(xmlCPUs, error); + virCheckReadOnlyGoto(conn->flags, error); if (conn->driver->connectBaselineHypervisorCPU) { char *cpu; |