summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMo Yuxiang <Moyuxiang@huawei.com>2014-08-08 17:55:37 +0800
committerJán Tomko <jtomko@redhat.com>2014-08-19 12:43:28 +0200
commit2175f4f3da4dbf5f44a00275bd61f807cedf72ea (patch)
treea811db905a5142b53cc03df6820fb295756c7c34
parent86ee51ce97525fd474d3a155d67bf0730597c23a (diff)
downloadlibvirt-python-2175f4f3da4dbf5f44a00275bd61f807cedf72ea.tar.gz
build: Fix build warning on libvirt-python
On compiling libvirt-python, we get such a warning: libvirt-qemu-override.c: In function ‘libvirt_qemu_virConnectDomainQemuMonitorEventRegister’: libvirt-qemu-override.c:304: warning: suggest explicit braces to avoid ambiguous ‘else’ Py_DECREF is a macro using if/else on older Python releases. The solution is to add braces. Python 2.7 and newer has the macro wrapped in a do { } while(0) block. Signed-off-by: Mo Yuxiang <Moyuxiang@huawei.com> Signed-off-by: Ján Tomko <jtomko@redhat.com>
-rw-r--r--libvirt-qemu-override.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/libvirt-qemu-override.c b/libvirt-qemu-override.c
index 05ead30..8be3755 100644
--- a/libvirt-qemu-override.c
+++ b/libvirt-qemu-override.c
@@ -301,8 +301,9 @@ libvirt_qemu_virConnectDomainQemuMonitorEventRegister(PyObject *self ATTRIBUTE_U
flags);
LIBVIRT_END_ALLOW_THREADS;
- if (ret < 0)
+ if (ret < 0) {
Py_DECREF(pyobj_cbData);
+ }
py_retval = libvirt_intWrap(ret);
return py_retval;