diff options
| author | Milian Wolff <mail@milianw.de> | 2018-05-31 16:11:30 +0200 |
|---|---|---|
| committer | Dave Watson <davejwatson@fb.com> | 2018-05-31 07:11:30 -0700 |
| commit | 038556f57e3433cbaaa7b087c9798143709caa9c (patch) | |
| tree | b4cb8ff27da4db318575fa2190cc91e20dc44a77 | |
| parent | cd8c5d70d4358aee3dc9fee53e9870d0501cc6db (diff) | |
| download | libunwind-038556f57e3433cbaaa7b087c9798143709caa9c.tar.gz | |
Also define NLGA when we build with atomic ops (#80)
This uncovered the use of NLGA to guard the initializaition
of the valid mem cache. This code is removed, as it isn't
working properly for a per-thread cache anyways. What's more,
it shouldn't be required anyways since static data is guaranteed
to be initialized to zero anyways.
Fixes https://github.com/libunwind/libunwind/issues/79
| -rw-r--r-- | src/x86_64/Ginit.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/src/x86_64/Ginit.c b/src/x86_64/Ginit.c index 669e9edb..6161da64 100644 --- a/src/x86_64/Ginit.c +++ b/src/x86_64/Ginit.c @@ -174,8 +174,8 @@ tdep_init_mem_validate (void) } /* Cache of already validated addresses */ -#if defined(HAVE___THREAD) && HAVE___THREAD #define NLGA 4 +#if defined(HAVE___THREAD) && HAVE___THREAD // thread-local variant static __thread unw_word_t last_good_addr[NLGA]; static __thread int lga_victim; @@ -394,11 +394,6 @@ x86_64_local_addr_space_init (void) local_addr_space.acc.resume = x86_64_local_resume; local_addr_space.acc.get_proc_name = get_static_proc_name; unw_flush_cache (&local_addr_space, 0, 0); - -#if NLGA > 0 - memset (last_good_addr, 0, sizeof (unw_word_t) * NLGA); - lga_victim = 0; -#endif } #endif /* !UNW_REMOTE_ONLY */ |