diff options
| author | Tijl Coosemans <tijl@FreeBSD.org> | 2014-11-28 16:46:56 +0000 |
|---|---|---|
| committer | Gary V. Vaughan <gary@gnu.org> | 2014-11-28 20:23:42 +0000 |
| commit | cbeefbc8f0ac527f7c7f14cbc8b3fc9de0ff2b77 (patch) | |
| tree | 290d7e6e0b18c6190e99b25e70280a52148965c3 | |
| parent | 16bcf1884998a56963d81c796d138b0107fffce7 (diff) | |
| download | libtool-cbeefbc8f0ac527f7c7f14cbc8b3fc9de0ff2b77.tar.gz | |
libtoolize: no need for umask 0 now that copying does not use tar.
The umask calls seem to be left over as a workaround for several
releases ago when libtoolize copied libltdl sources with the help
of tar. Now that we use cp or ln -s exclusively, this just
needlessly makes the files world writable; we should just respect
the users' own umask setting.
* libtoolize.in (func_copy): Remove umask 0 calls and simplify.
Signed-off-by: Gary V. Vaughan <gary@gnu.org>
| -rw-r--r-- | libtoolize.in | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/libtoolize.in b/libtoolize.in index dbc6ac3d..6e5eaca7 100644 --- a/libtoolize.in +++ b/libtoolize.in @@ -392,11 +392,7 @@ func_copy () # Filters always take priority. if test -n "$my_filter"; then - if $opt_dry_run || { - ( umask 0 - $SED -e "$my_filter" "$my_srcfile" > "$my_destfile" - ) >/dev/null 2>&1 - } + if $opt_dry_run || $SED -e "$my_filter" "$my_srcfile" > "$my_destfile" 2>/dev/null then func_notquiet_once "$my_msg_var" if $opt_verbose; then @@ -422,11 +418,7 @@ func_copy () my_copy_msg="$my_copy_type file '$my_destfile'" $opt_verbose && my_copy_msg="$my_copycmd $my_srcfile $my_destdir" - if $opt_dry_run || { - ( umask 0 - $my_copycmd "$my_srcfile" "$my_destfile" - ) >/dev/null 2>&1 - } + if $opt_dry_run || $my_copycmd "$my_srcfile" "$my_destfile" 2>/dev/null then func_notquiet_hdr "$my_msg_var" "$my_copy_msg" else |