diff options
| author | Brian Cain <brian.cain@gmail.com> | 2015-05-06 15:34:38 -0400 |
|---|---|---|
| committer | Paul Moore <pmoore@redhat.com> | 2015-05-06 15:34:38 -0400 |
| commit | 713cc03591eb21d36e56f14a1db85ad084b92d03 (patch) | |
| tree | 5896e837808a18e42e1a4d0c7c25776b097c816f | |
| parent | 7b8e5023add1d9b22e7367c230c1b1935ea232bc (diff) | |
| download | libseccomp-713cc03591eb21d36e56f14a1db85ad084b92d03.tar.gz | |
tests: fixed leak in basic-resolver
seccomp_syscall_resolve_num_arch() returns a string from strdup() that
needs to be reaped. I found this bug using clang and
address-sanitizer.
Signed-off-by: Brian Cain <brian.cain@gmail.com>
Signed-off-by: Paul Moore <pmoore@redhat.com>
(imported from commit 5b813a7331dcadd5d8b63532df8d07cdf47a041e)
| -rw-r--r-- | tests/15-basic-resolver.c | 31 |
1 files changed, 21 insertions, 10 deletions
diff --git a/tests/15-basic-resolver.c b/tests/15-basic-resolver.c index a8988fd..0bd0cf8 100644 --- a/tests/15-basic-resolver.c +++ b/tests/15-basic-resolver.c @@ -21,40 +21,51 @@ #include <errno.h> #include <string.h> +#include <stdlib.h> #include <seccomp.h> int main(int argc, char *argv[]) { - char *name; + char *name = NULL; if (seccomp_syscall_resolve_name("open") != __NR_open) - return 1; + goto fail; if (seccomp_syscall_resolve_name("socket") != __NR_socket) - return 1; + goto fail; if (seccomp_syscall_resolve_name("INVALID") != __NR_SCMP_ERROR) - return 1; + goto fail; if (seccomp_syscall_resolve_name_arch(SCMP_ARCH_NATIVE, "open") != __NR_open) - return 1; + goto fail; if (seccomp_syscall_resolve_name_arch(SCMP_ARCH_NATIVE, "socket") != __NR_socket) - return 1; + goto fail; if (seccomp_syscall_resolve_name_arch(SCMP_ARCH_NATIVE, "INVALID") != __NR_SCMP_ERROR) - return 1; + goto fail; name = seccomp_syscall_resolve_num_arch(SCMP_ARCH_NATIVE, __NR_open); if (name == NULL || strcmp(name, "open") != 0) - return 1; + goto fail; + free(name); + name = seccomp_syscall_resolve_num_arch(SCMP_ARCH_NATIVE, __NR_socket); if (name == NULL || strcmp(name, "socket") != 0) - return 1; + goto fail; + free(name); + name = seccomp_syscall_resolve_num_arch(SCMP_ARCH_NATIVE, __NR_SCMP_ERROR); if (name != NULL) - return 1; + goto fail; + free(name); return 0; + +fail: + if (name != NULL) + free(name); + return 1; } |