| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
* pass strings by const & instead of copy
* Search single chars as chars and not as strings
|
|
|
|
|
|
|
| |
get-pac-test.cpp:55:10: error: assigning to 'int' from incompatible type '__bind<int &, sockaddr *, unsigned int>'
ret = bind(m_sock, (sockaddr*)&addr, sizeof (struct sockaddr_in)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Khem Raj <raj.khem@gmail.com>
|
|
|
|
| |
Closes: #64
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Rather than checking for EBADF when the socket is closed due to an
overly-large request, check that the sent size differs from the
received. Use a large buffer to ensure that the number of bytes sent are
greater than the kernel TCP receive buffer size, as otherwise the send()
call succeeds even though the bytes were never retrieved from the
socket. Pass the MSG_NOSIGNAL flag (or the SO_NOSIGPIPE socket option)
so that SIGPIPE is not generated when the socket is closed once the
content length has been read.
Close #47
|
| |
| |
| |
| |
| |
| |
| | |
Do not call close() on the return value from send(), which is a number
of bytes.
Fixes #47
|
| | |
|
| | |
|
| |
| |
| |
| | |
sys/socket.h
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
| |
There are two things wrong with the unit test. First
depending on the state of the socket the overflow send
may terminate with either EBADF or EPIPE.
Second, the length of the send is being used as the fd
in the call to close.
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the way we detect if get_pac correctly aborted on our server trying
to send a > 102400 byte long stream (which we do to avoid malicious pac
files/wpad server to buffer overflow us).
Replace assert calls with proper error handling, which avoids the server
from hanging (the write command to send the quit was wrapped in
assert()).
When not building for a Debug release with CMAKE, the -DNDEBUG is being
specified, which in turn disables the assert macro.
Fixes bug 189.
|
|
|
|
| |
This should help in preventing regression that could lead to new security
issues. This unit test only runs on Unix for now.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
external libmodman ; please test
|
| |
|
| |
|
|
|