summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorCosmin Truta <ctruta@gmail.com>2019-04-21 00:30:14 -0400
committerCosmin Truta <ctruta@gmail.com>2019-04-21 00:30:14 -0400
commit72fa126446460347a504f3d9b90f24aed1365595 (patch)
treef35f1a33a94da387070c247f115c6b1ad0733d21 /tests
parent5df8e982e2bad2af7da5ecf689219ca89296c56d (diff)
downloadlibpng-72fa126446460347a504f3d9b90f24aed1365595.tar.gz
Avoid random test failures by running pngtest sequentially only
It is unreliable to run pngtest in parallel, due to competing writes to the same intermediate/output file ("pngout.png"). Customization of this output file name should be possible, but it is currently broken.
Diffstat (limited to 'tests')
-rwxr-xr-xtests/pngtest2
-rwxr-xr-xtests/pngtest-all (renamed from tests/pngtest-badpngs)7
2 files changed, 5 insertions, 4 deletions
diff --git a/tests/pngtest b/tests/pngtest
deleted file mode 100755
index 813973b23..000000000
--- a/tests/pngtest
+++ /dev/null
@@ -1,2 +0,0 @@
-#!/bin/sh
-exec ./pngtest --strict ${srcdir}/pngtest.png
diff --git a/tests/pngtest-badpngs b/tests/pngtest-all
index 77775232b..5e96451d3 100755
--- a/tests/pngtest-badpngs
+++ b/tests/pngtest-all
@@ -1,5 +1,9 @@
#!/bin/sh
+# normal execution
+
+./pngtest --strict ${srcdir}/pngtest.png
+
# various crashers
# using --relaxed because some come from fuzzers that don't maintain CRC's
@@ -9,5 +13,4 @@
./pngtest --xfail ${srcdir}/contrib/testpngs/crashers/empty_ancillary_chunks.png
./pngtest --xfail ${srcdir}/contrib/testpngs/crashers/huge_*_chunk.png \
${srcdir}/contrib/testpngs/crashers/huge_*safe_to_copy.png
-
-exec ./pngtest --xfail ${srcdir}/contrib/testpngs/crashers/huge_IDAT.png
+./pngtest --xfail ${srcdir}/contrib/testpngs/crashers/huge_IDAT.png