| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
to remove warnings
|
|
|
|
| |
fixes https://github.com/gphoto/libgphoto2/issues/278
|
| |
|
| |
|
|
|
|
|
|
| |
descriptor
fixes https://github.com/gphoto/libgphoto2/issues/194
|
| |
|
| |
|
|
|
|
|
|
|
| |
Adjust the camlibs that use it
(As this is mostly a internal function it should be ok to change.)
Fixes https://github.com/gphoto/libgphoto2/issues/73
|
|
|
|
| |
in the windows directory anymore
|
|
|
|
|
|
| |
The old %hX string was for an unsigned short, but we pass an unsigned char.
This silences another compiler warning.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
the regular get_config and set_config if not present
|
|
|
|
| |
gp_camera_list_config, gp_camera_set_single_config, gp_camera_get_single_config
|
| |
|
|
|
|
|
|
| |
building better with Visual C
https://github.com/gphoto/libgphoto2/issues/33
|
|
|
|
|
|
|
|
|
|
|
|
| |
3) I got heaps of error messages from a failed attempt to read the settings
file. The code in gphoto_settings.c could need some proper cleanup but I
only improved the logging messages a bit and made the usage of the
log-level consistent (report the unproblematic failed read as a DEBUG
level message consistently).
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@15405 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
| |
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@15233 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
| |
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@15201 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
|
|
|
|
| |
make gpi_vsnprintf internal export
and use it in gphoto2-context.c too
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@15178 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rewrote the ptp_opensession error retry code
changed some more error logging handling
detailed:
a) yet another logging/cleanup patch improving the code and error log
readability in this specific situation:
* extend translate_ptp_results to better handle PTP_ERROR_IO
* log the failure of ptp_opensession
* make the ptp_opensession error handling code clearer
* don't report a 'ptp_port' error inside the CHECK_INIT macro
when gp_camera_init fails in gphoto-camera.c. There is no
port error string mechanism involved and the original error has
been reported already from inside camera_init
* don't report the source location when logging the error string
inside gp_context_error(). interesting would be the original
source location but that is not available there.
* remove one of two different strings conveying the same
information: 'No additional information available.' and
'No error description available'
* improve logging in existing CHECK_RESULT_OPEN_CLOSE macro
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@15110 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
|
|
|
|
|
|
|
|
| |
I had something 'prepared' for this situation, here you go.. ;)
The patch does not, however, actually remove the GP_LOG_VERBOSE enum,
since that would change the interface for all clients, which might not
be worth it. If you don't think that is a problem, please remove it...
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@15107 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) introduce C_PARAMS and C_PARAMS_MSG along the lines of C_MEM
2) replace CHECK_NULL with C_PARAMS
3) replace the pattern
if ( something ) return GP_ERROR_BAD_PARAMETERS;
with
C_PARAMS ( !something );
I went over the whole patch again to check that each 'something'
condition is really inverted, so I dare to suggest you don't have to
do that again ;).
4) replaced CHECK_LIST and CHECK_INDEX_RANGE with simple one-line
C_PARAMS(...) expressions
5) a couple of hunks look like this
- if (!inet_aton (buffer, &inp)) {
- fprintf(stderr,"failed to scan for addr in %s\n", buffer);
- return GP_ERROR_BAD_PARAMETERS;
- }
+ C_PARAMS_MSG (inet_aton (buffer, &inp),
so some 'lost' error messages get now properly piped into the gp_log
mechanism.
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@15103 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
|
|
|
|
|
|
| |
3) use the fact that realloc() is defined to simply malloc if the
first param is NULL, no need to manually distinguish between first and
later allocations.
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@15098 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
|
|
|
|
|
| |
2) don't check the pointer for NULL before calling free(), because
free() checks it again.
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@15097 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
|
|
|
|
|
|
|
| |
here is a patch for (mostly) consistent usage of a generalized C_MEM
macro for checking the return values of memory allocating functions,
i.e. malloc, calloc, realloc and strdup. It is the C_MEM from
libusb1.c, moved to gphoto2-port-log.h.
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@15096 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
7, 8, 9) same 3,4,5 but for libgphoto core
3, 4) strictly replacing gp_log( GP_LOG_DEBUG/ERROR, ... with
GP_LOG_D/E in the libgphoto2 code. they are simple regex-replace
patches.
5) fix some whitespace issues caused by 3 and 4 and remove any _(...)
gettext macro usage for log messages
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@15085 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
|
|
|
|
|
| |
2) only replaces the existing GP_DEBUG with the new GP_LOG_D and
removes the GP_MODULE strings
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@15079 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
| |
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@15018 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
| |
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@15017 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
| |
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@15016 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
|
|
|
|
|
|
| |
A great many functions have variables which are set to some
value, but never read thereafter. All these variables can be
removed with no functional impact.
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@14896 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
|
|
|
|
|
|
|
|
| |
The gpi_jpeg_make_quantization and gpi_jpeg_header methods take
a 'jpeg_quantization_table *' arg. The callers pass in a pointer
to a 'const jpeg_quantization_table *' causing compile warnings
about discarding const-ness. Mark the args as 'const' since their
contents are never modified.
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@14891 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
| |
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@14851 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
| |
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@14822 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
| |
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@14762 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
| |
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@14676 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
| |
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@14640 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
| |
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@14639 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
| |
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@14638 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
| |
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@14637 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
| |
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@14636 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
| |
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@14631 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
| |
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@14630 67ed7778-7388-44ab-90cf-0a291f65f57c
|
|
|
|
| |
git-svn-id: https://svn.code.sf.net/p/gphoto/code/trunk/libgphoto2@14610 67ed7778-7388-44ab-90cf-0a291f65f57c
|