| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| | |_|/
|/| | |
|
| |\ \ \
| | | |
| | | | |
path: refactor utility path functions
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Teach `git_path_is_valid` to respect `core.longpaths`. Add helper
methods to validate length and set the error message appropriately.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Add a `git_str` based validity check; the existing `git_path_is_valid`
defers to it.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Provide a mechanism for users to limit the number of characters that are
examined; `git_fs_path_str_is_valid` and friends will only examine up to
`str->size` bytes.
`git_fs_path_is_valid` delegates to these new functions by passing
`SIZE_MAX` (instead of doing a `strlen`), which is a sentinel value
meaning "look for a NUL terminator".
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Since we're returning a boolean about validation, the name is more
properly "is valid".
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Since we're returning a boolean about validation, the name is more
properly "is valid".
|
| | |/ /
| | |
| | |
| | |
| | |
| | | |
Introduce `git_fs_path`, which operates on generic filesystem paths.
`git_path` will be kept for only git-specific path functionality (for
example, checking for `.git` in a path).
|
| |/ /
| |
| |
| |
| | |
Add optional refreshing in the fake backend, and count the number of
refresh calls if enabled.
|
| |/
|
|
|
|
| |
in #6083 the test runner was renamed to libgit2_tests,
but not all references to the old name were updated.
this change changes all of them to use the new name.
|
| |
|
|
|
| |
Ensure that we always use lowercase function names, and that we do not
have spaces preceding open parentheses, for consistency.
|
| |
|
|
|
| |
Nobody knows what CLAR is. The test building option should be
`BUILD_TESTS`.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
libgit2 has two distinct requirements that were previously solved by
`git_buf`. We require:
1. A general purpose string class that provides a number of utility APIs
for manipulating data (eg, concatenating, truncating, etc).
2. A structure that we can use to return strings to callers that they
can take ownership of.
By using a single class (`git_buf`) for both of these purposes, we have
confused the API to the point that refactorings are difficult and
reasoning about correctness is also difficult.
Move the utility class `git_buf` to be called `git_str`: this represents
its general purpose, as an internal string buffer class. The name also
is an homage to Junio Hamano ("gitstr").
The public API remains `git_buf`, and has a much smaller footprint. It
is generally only used as an "out" param with strict requirements that
follow the documentation. (Exceptions exist for some legacy APIs to
avoid breaking callers unnecessarily.)
Utility functions exist to convert a user-specified `git_buf` to a
`git_str` so that we can call internal functions, then converting it
back again.
|
| |
|
|
|
|
| |
Separate the concerns of the hash functions from the git_oid functions.
The git_oid structure will need to understand either SHA1 or SHA256; the
hash functions should only deal with the appropriate one of these.
|
| | |
|
| |\
| |
| | |
oidarray: introduce `git_oidarray_dispose`
|
| | |
| |
| |
| |
| |
| | |
Since users are disposing the _contents_ of the oidarray, not freeing
the oidarray itself, the proper cleanup function is
`git_oidarray_dispose`. Deprecate `git_oidarray_free`.
|
| |\ \ |
|
| | |/
| |
| |
| | |
The `repo` argument is now unnecessary. Remove it.
|
| |\ \ |
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When `git_repository_hashfile` is handed an absolute path, it determines
whether the path is within the repository's working directory or not.
This is necessary when there is no `as_path` specified.
If the path is within the working directory, then the given path should
be used for attribute lookups (it is the effective `as_path`). If it is
not within the working directory, then it is _not_ eligible.
Importantly, now we will _never_ pass an absolute path down to attribute
lookup functions.
|
| |/
|
|
|
|
| |
`git_strarray` is a public-facing type. Change
`git_buf_text_common_prefix` to not use it, and just take an array of
strings instead.
|
| |\
| |
| | |
filter: use a `git_oid` in filter options, not a pointer
|
| | |
| |
| |
| |
| |
| |
| | |
Using a `git_oid *` in filter options was a mistake; it is a deviation
from our typical pattern, and callers in some languages that GC may need
very special treatment in order to pass both an options structure and a
pointer outside of it.
|
| |/ |
|
| |\
| |
| | |
Introduce `git_email_create`; deprecate `git_diff_format_email`
|
| | |
| |
| |
| | |
`git_diff_format_email` is deprecated in favor of `git_email_create`.
|
| | |
| |
| |
| |
| | |
`git format-patch` includes diffs with rename detection enabled by
default when creating emails. Match this behavior.
|
| | |
| |
| |
| |
| | |
`git format-patch` includes binary diffs by default when creating
emails. Match this behavior.
|
| | |
| |
| |
| |
| | |
Allow a `0` patch index and `0` patch count; in this case, simply don't
display these in the email.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Introduce a function to create an email from a diff and multiple inputs
about the source of the diff.
Creating an email from a diff requires many more inputs, and should be
discouraged in favor of building directly from a commit, and is thus in
the `sys` namespace.
|
| | |
| |
| |
| |
| |
| | |
Create `git_email_*` which will encapsulate email creation and
application, and `git_email_create_from_commit` in particular, which
creates an email for a single commit.
|
| |\ \ |
|
| | | |
| | |
| | |
| | |
| | | |
The configuration change will override the environment variable, so the
environment variable check needs to come first.
|
| | | |
| | |
| | | |
Signed-off-by: Mathieu Parent <math.parent@gmail.com>
|
| | | | |
|
| |\ \ \ |
|
| | | | |
| | | |
| | | | |
Co-authored-by: Edward Thomson <ethomson@github.com>
|
| | | | | |
|
| | |/ /
| | |
| | |
| | |
| | |
| | | |
the filtering code to ensure the cached longpath setting is returned.
Fixes: #6054
|
| |\ \ \
| | | |
| | | | |
Allow proxy options when connecting with a detached remote.
|
| | | | | |
|
| | | |/
| |/| |
|
| |/ / |
|
| |\ \
| | |
| | | |
Support custom git extensions
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Allow users to specify additional repository extensions that they want
to support. For example, callers can specify that they support
`preciousObjects` and then may open repositories that support
`extensions.preciousObjects`.
Similarly, callers may opt out of supporting extensions that the library
itself supports.
|
| | |/ |
|
| |/
|
|
|
| |
This tests parsing a multiline string containing multiple quoted comment
chars. See #6019
|
| |
|
|
|
|
|
|
|
|
| |
Update the proxy detection for a remote.
1. Honor `http.<url>.proxy` syntax for a remote's direct URL and
parent URLs.
2. Honor an empty configuration URL to override a proxy configuration.
Add tests to ensure that configuration specificity is honored.
|