summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* reflog: Do not free references before timenew-referencesVicent Marti2011-11-061-10/+20
|
* refs: Partial rewrite for read-only refsVicent Marti2011-11-063-848/+623
| | | | | | | | | | | | | | | | | | | | | | | | | This new version of the references code is significantly faster and hopefully easier to read. External API stays the same. A new method `git_reference_reload()` has been added to force updating a memory reference from disk. In-memory references are no longer updated automagically -- this was killing us. If a reference is deleted externally and the user doesn't reload the memory object, nothing critical happens: any functions using that reference should fail gracefully (e.g. deletion, renaming, and so on). All generated references from the API are read only and must be free'd by the user. There is no reference counting and no traces of generated references are kept in the library. There is no longer an internal representation for references. There is only one reference struct `git_reference`, and symbolic/oid targets are stored inside an union. Packfile references are stored using an optimized struct with flex array for reference names. This should significantly reduce the memory cost of loading the packfile from disk.
* git_reference_rename: cleanup reference renamingschu2011-11-061-37/+35
| | | | | | | | | git_reference_rename() didn't properly cleanup old references given by the user to not break some ugly old tests. Since references don't point to libgit's internal cache anymore we can cleanup git_reference_rename() to be somewhat less messy. Signed-off-by: schu <schu-github@schulog.org>
* Free all used references in the source treeschu2011-11-065-17/+77
| | | | | | | Since references are not owned by the repository anymore we have to free them manually now. Signed-off-by: schu <schu-github@schulog.org>
* refs: split internal and external referencesschu2011-11-063-128/+303
| | | | | | | | | | | | | | | | | Currently libgit2 shares pointers to its internal reference cache with the user. This leads to several problems like invalidation of reference pointers when reordering the cache or manipulation of the cache from user side. Give each user its own git_reference instead of leaking the internal representation (struct reference). Add the following new API functions: * git_reference_free * git_reference_is_packed Signed-off-by: schu <schu-github@schulog.org>
* Merge pull request #468 from nulltoken/ntk/fix/issue-465Vicent Martí2011-10-291-27/+48
|\ | | | | Status: fix segfault (#465) and order issues
| * status: Fix a sorting issue in the treewalkernulltoken2011-10-291-7/+26
| | | | | | | | | | | | | | This ensures that entries from the working directory are retrieved according to the following rules: - The file "subdir" should appear before the file "subdir.txt" - The folder "subdir" should appear after the file "subdir.txt"
| * status: Prevent segfaulting when determining the status of a repositorynulltoken2011-10-291-20/+22
| | | | | | | | Fixes #465
* | Merge pull request #456 from brodie/perm-fixesVicent Martí2011-10-2824-54/+79
|\ \ | |/ |/| Create objects, indexes, and directories with the right file permissions
| * *: correct and codify various file permissionsBrodie Rao2011-10-1417-18/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following files now have 0444 permissions: - loose objects - pack indexes - pack files - packs downloaded by fetch - packs downloaded by the HTTP transport And the following files now have 0666 permissions: - config files - repository indexes - reflogs - refs This brings libgit2 more in line with Git. Note that git_filebuf_commit() and git_filebuf_commit_at() have both gained a new mode parameter. The latter change fixes an important issue where filebufs created with GIT_FILEBUF_TEMPORARY received 0600 permissions (due to mkstemp(3) usage). Now we chmod() the file before renaming it into place. Tests have been added to confirm that new commit, tag, and tree objects are created with the right permissions. I don't have access to Windows, so for now I've guarded the tests with "#ifndef GIT_WIN32".
| * fileops/repository: create (most) directories with 0777 permissionsBrodie Rao2011-10-1411-23/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To further match how Git behaves, this change makes most of the directories libgit2 creates in a git repo have a file mode of 0777. Specifically: - Intermediate directories created with git_futils_mkpath2file() have 0777 permissions. This affects odb_loose, reflog, and refs. - The top level folder for bare repos is created with 0777 permissions. - The top level folder for non-bare repos is created with 0755 permissions. - /objects/info/, /objects/pack/, /refs/heads/, and /refs/tags/ are created with 0777 permissions. Additionally, the following changes have been made: - fileops functions that create intermediate directories have grown a new dirmode parameter. The only exception to this is filebuf's lock_file(), which unconditionally creates intermediate directories with 0777 permissions when GIT_FILEBUF_FORCE is set. - The test runner now sets the umask to 0 before running any tests. This ensurses all file mode checks are consistent across systems. - t09-tree.c now does a directory permissions check. I've avoided adding this check to other tests that might reuse existing directories from the prefabricated test repos. Because they're checked into the repo, they have 0755 permissions. - Other assorted directories created by tests have 0777 permissions.
| * fileops/posix: replace usage of "int mode" with "mode_t mode"Brodie Rao2011-10-147-20/+20
| | | | | | | | | | Note: Functions exported from fileops take const mode_t, while the underlying POSIX wrappers take mode_t.
* | global: Properly use `git__` memory wrappersVicent Marti2011-10-2847-268/+270
| | | | | | | | | | Ensure that all memory related functions (malloc, calloc, strdup, free, etc) are using their respective `git__` wrappers.
* | tree: Add traversal in post-orderVicent Marti2011-10-271-2/+54
| |
* | Merge branch 'status' of https://github.com/carlosmn/libgit2 into developmentVicent Marti2011-10-271-37/+17
|\ \
| * | status: move GIT_STATUS_PATH_* into an enumCarlos Martín Nieto2011-10-271-7/+9
| | | | | | | | | | | | | | | | | | Their actual values have no meaning, so pack them in an enum. Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
| * | status: reorder retrieve_head_tree error checksCarlos Martín Nieto2011-10-271-4/+2
| | | | | | | | | | | | Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
| * | status: remove git_tree_entry_byposCarlos Martín Nieto2011-10-271-14/+5
| | | | | | | | | | | | | | | | | | | | | The only caller has been changed to treat a NULL tree as a special case and use the existing git_tree_entry_byindex. Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
| * | status: remove git_index_entry_byposCarlos Martín Nieto2011-10-271-12/+1
| | | | | | | | | | | | | | | | | | | | | This function is already implemented (better) as git_index_get. Change the only caller to use that function. Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
* | | Merge pull request #467 from oleganza/oa-config-parse-fixVicent Martí2011-10-271-2/+8
|\ \ \ | |/ / |/| | Fixed crash in config parser when empty value is encountered.
| * | Fixed crash in config parser when empty value is encountered.Oleg Andreev2011-10-271-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | Example: key1 = value1 key2 = In this config the value will be a bad pointer which config object will attempt to free() causing a crash.
* | | windows: Add support for non-UTF codepagesVicent Marti2011-10-266-28/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Our previous assumption that all paths in Windows are encoded in UTF-8 is rather weak, specially when considering that Git is encoding-agnostic. These set of functions allow the user to change the library's active codepage globally, so it is possible to access paths and files on all international versions of Windows. Note that the default encoding here is UTF-8 because we assume that 99% of all Git repositories will be in UTF-8. Also, if you use non-ascii characters in paths, anywhere, please burn on a fire.
* | | Tolerate zlib deflation with window size < 32KbRoberto Tyley2011-10-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | libgit2 currently identifies loose objects as corrupt if they've been deflated using a window size less than 32Kb, because the is_zlib_compressed_data() function doesn't recognise the header byte as a zlib header. This patch makes the method tolerant of all valid window sizes (15-bit to 8-bit) - but doesn't sacrifice it's accuracy in distingushing the standard loose-object format from the experimental (now abandoned) format. It's based on a patch which has been merged into C-Git master branch: https://github.com/git/git/commit/7f684a2aff636f44a506 On memory constrained systems zlib may use a much smaller window size - working on Agit, I found that Android uses a 4KB window; giving a header byte of 0x48, not 0x78. Consequently all loose objects generated by the Android platform appear 'corrupt' :( It might appear that this patch changes isStandardFormat() to the point where it could incorrectly identify the experimental format as the standard one, but the two criteria (bitmask & checksum) can only give a false result for an experimental object where both of the following are true: 1) object size is exactly 8 bytes when uncompressed (bitmask) 2) [single-byte in-pack git type&size header] * 256 + [1st byte of the following zlib header] % 31 = 0 (checksum) As it happens, for all possible combinations of valid object type (1-4) and window bits (0-7), the only time when the checksum will be divisible by 31 is for 0x1838 - ie object type *1*, a Commit - which, due the fields all Commit objects must contain, could never be as small as 8 bytes in size. Given this, the combination of the two criteria (bitmask & checksum) always correctly determines the buffer format, and is more tolerant than the previous version. References: Android uses a 4KB window for deflation: http://android.git.kernel.org/?p=platform/libcore.git;a=blob;f=luni/src/main/native/java_util_zip_Deflater.cpp;h=c0b2feff196e63a7b85d97cf9ae5bb258 Code snippet searching for false positives with the zlib checksum: https://gist.github.com/1118177 Change-Id: Ifd84cd2bd6b46f087c9984fb4cbd8309f483dec0
* | | tree: Fix name lookups once and for allVicent Marti2011-10-201-45/+85
| | | | | | | | | | | | Double-pass binary search. Jeez.
* | | tree: Fix lookups by entry nameVicent Marti2011-10-191-2/+11
| | |
* | | mwindow: close LRU window properlyCarlos Martín Nieto2011-10-151-5/+12
| |/ |/| | | | | | | | | | | | | | | | | | | Remove a wrong call to git_mwindow_close which caused a segfault if it ever did run. In that same piece of code, if the LRU was from the first wiindow in the list in a different file, we didn't update that list, so the first element had been freed. Fix these two issues. Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
* | tree: Add git_tree_frompath() which, given a relative path to a tree entry, ↵nulltoken2011-10-131-0/+45
| | | | | | | | retrieves the tree object containing this tree entry
* | oid: Add git_oid_streq() which checks if an oid and an hex formatted string ↵nulltoken2011-10-131-0/+11
| | | | | | | | are equal
* | Fix compilation error on Windowsnulltoken2011-10-131-1/+0
| |
* | Merge pull request #454 from brodie/parsing-fixesVicent Martí2011-10-133-11/+12
|\ \ | | | | | | Improvements to tag, commit, and signature parsing
| * | signature: don't blow up trying to parse names containing '>'Brodie Rao2011-10-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When trying to find the end of an email, instead of starting at the beginning of the signature, we start at the end of the name (after the first '<'). This brings libgit2 more in line with Git's behavior when reading out existing signatures. However, note that Git does not allow names like these through the usual porcelain; instead, it silently strips any '>' characters it sees.
| * | tag: allow the tagger field to be missing when parsing tagsBrodie Rao2011-10-121-6/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of bailing out with an error, this sets tagger to NULL when the field is missing from the object. This makes it possible to inspect tags like this one: http://git.kernel.org/?p=git/git.git;a=tag;h=f25a265a342aed6041ab0cc484224d9ca54b6f41
| * | tag: avoid a double-free when parsing tags without a tagger fieldBrodie Rao2011-10-121-4/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The v0.99 tag in the Git repo triggers this behavior: http://git.kernel.org/?p=git/git.git;a=tag;h=d6602ec5194c87b0fc87103ca4d67251c76f233a Ideally, we'd allow the tag to be instantiated even though the tagger field is missing, but this at the very least prevents libgit2 from crashing. To test this bug, a new repository has been added based on the test branch in testrepo.git. It contains a "e90810b" tag that looks like this: object e90810b8df3e80c413d903f631643c716887138d type commit tag e90810b This is a very simple tag.
| * | commit: properly parse empty commit messagesBrodie Rao2011-10-121-2/+2
| |/ | | | | | | | | | | | | | | | | This ensures commit->message is always non-NULL, even if the commit message is empty or consists of only a newline. One such commit can be found in the wild in the jQuery repository: https://github.com/jquery/jquery/commit/25b424134f9927a5bf0bab5cba836a0aa6c3cfc1
* | Merge pull request #455 from brodie/pack-fixesVicent Martí2011-10-131-1/+1
|\ \ | | | | | | odb_pack: don't do ambiguity checks for fully qualified SHA1 hashes
| * | odb_pack: don't do ambiguity checks for fully qualified SHA1 hashesBrodie Rao2011-10-121-1/+1
| |/ | | | | | | | | | | | | | | This makes libgit2 more closely match Git, which only checks for ambiguous pack entries when given short hashes. Note that the only time this is ever relevant is when a pack has the same object more than once (it's happened in the wild, I promise).
* | pkt: move the protocol strings to the top of the fileCarlos Martín Nieto2011-10-121-17/+14
| | | | | | | | | | | | Put them all together so we know where to find them. Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
* | Move the transports to their own directoryCarlos Martín Nieto2011-10-123-0/+0
| |
* | net: plug a few memory leaksCarlos Martín Nieto2011-10-122-2/+17
| | | | | | | | Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
* | http: download pack when fetchingCarlos Martín Nieto2011-10-121-12/+123
| | | | | | | | | | | | | | Unfortunately, we can't use the function in fetch.c due to chunked encoding and keep-alive connections. Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
* | remote: bitfield should be unsignedCarlos Martín Nieto2011-10-121-1/+1
| | | | | | | | Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
* | git transport: don't loose received dataCarlos Martín Nieto2011-10-121-83/+38
| | | | | | | | | | | | | | | | | | Using a different buffer in each function means that some data might get lost. Store all the data in a buffer in the transport object. Take this opportunity to use the generic download-pack function. Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
* | fetch: add a generic pack-download functionCarlos Martín Nieto2011-10-122-0/+63
| | | | | | | | | | | | | | Taken mostly from the git transport's version, this can be used by any transport that takes its pack data from the network. Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
* | pkt: get rid of the chunked supportCarlos Martín Nieto2011-10-124-54/+17
| | | | | | | | | | | | It was a bad idea. Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
* | http: simple negotiationCarlos Martín Nieto2011-10-122-27/+58
| | | | | | | | Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
* | Introduce the git_pkt_buffer_ family of functionsCarlos Martín Nieto2011-10-122-21/+87
| | | | | | | | Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
* | http: parse the response from the serverCarlos Martín Nieto2011-10-122-11/+109
| | | | | | | | Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
* | http: add a set of common refsCarlos Martín Nieto2011-10-121-14/+40
| | | | | | | | Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
* | http: move stuff out of negotiate_fetchCarlos Martín Nieto2011-10-121-44/+62
| | | | | | | | Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
* | transport: don't have an extra send-wants stepCarlos Martín Nieto2011-10-125-68/+19
| | | | | | | | | | | | | | It's a bit awkward to run it as an extra step, and HTTP may need to send the wants list several times. Signed-off-by: Carlos Martín Nieto <carlos@cmartin.tk>
View Lorry Controller Status