summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* fetch: clear the connection data on closecmn/fetch-twiceCarlos Martín Nieto2014-11-191-0/+1
| | | | | | | | | | | When we fetch twice with the same remote object, we did not properly clear the connection flags, so we would leak state from the last connection. This can cause the second fetch with the same remote object to fail if using a HTTP URL where the server redirects to HTTPS, as the second fetch would see `use_ssl` set and think the initial connection wanted to downgrade the connection.
* Merge pull request #2608 from libgit2/cmn/remote-pushEdward Thomson2014-11-181-0/+60
|\ | | | | Provide a convenience function `git_remote_push()`
| * remote: use configured push refspecs if none are givencmn/remote-pushCarlos Martín Nieto2014-11-091-3/+13
| | | | | | | | | | If the user does not pass any refspecs to push, try to use those configured via the configuration or via add_push().
| * remote: introduce git_remote_push()Carlos Martín Nieto2014-11-091-0/+50
| | | | | | | | | | | | | | | | | | This function, similar in style to git_remote_fetch(), performs all the steps required for a push, with a similar interface. The remote callbacks struct has learnt about the push callbacks, letting us set the callbacks a single time instead of setting some in the remote and some in the push operation.
* | Merge pull request #2671 from swisspol/remote_create_fixEdward Thomson2014-11-171-0/+4
|\ \ | | | | | | Fixed active_refspecs field not initialized on new git_remote objects
| * | Fixed active_refspecs field not initialized on new git_remote objectsPierre-Olivier Latour2014-11-171-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | When creating a new remote, contrary to loading one from disk, active_refspecs was not populated. This means that if using the new remote to push, git_push_update_tips() will be a no-op since it checks the refspecs passed during the push against the base ones i.e. active_refspecs. And therefore the local refs won't be created or updated after the push operation.
* | | Merge pull request #2693 from libgit2/cmn/push-refspec-refactorEdward Thomson2014-11-175-60/+35
|\ \ \ | | | | | | | | push: use the common refspec parser
| * | | push: use the common refspec parsercmn/push-refspec-refactorCarlos Martín Nieto2014-11-095-60/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is one well-known and well-tested parser which we should use, instead of implementing parsing a second time. The common parser is also augmented to copy the LHS into the RHS if the latter is empty. The expressions test had to change a bit, as we now catch a bad RHS of a refspec locally.
* | | | Merge pull request #2699 from swisspol/fix_warningsEdward Thomson2014-11-171-0/+4
|\ \ \ \ | |_|/ / |/| | | Fixed a couple Clang warnings
| * | | Fixed a couple Clang warningsPierre-Olivier Latour2014-11-101-0/+4
| | |/ | |/|
* | | branch: consider an empty upstream remote config as not foundCarlos Martín Nieto2014-11-171-0/+6
| | |
* | | Plug possible leak in the openssl locksUngureanu Marius2014-11-171-0/+6
| | |
* | | Rename git_threads_ to git_libgit2_Carlos Martín Nieto2014-11-082-11/+12
|/ / | | | | | | | | | | This describes their purpose better, as we now initialize ssl and some other global stuff in there. Calling the init function is not something which has been optional for a while now.
* | Changed GIT_REMOTE_DOWNLOAD_TAGS_ALL to behave like git 1.9.0Pierre-Olivier Latour2014-11-092-18/+20
| |
* | Merge pull request #2698 from libgit2/cmn/fetchhead-refactorEdward Thomson2014-11-082-25/+60
|\ \ | | | | | | Refactor fetchhead
| * | remote: refactor the reference-update decisioncmn/fetchhead-refactorCarlos Martín Nieto2014-11-081-26/+36
| | | | | | | | | | | | This is an ugly chunk of code, so let's put it into its own function.
| * | remote: don't check for upstream on an anonymous remoteCarlos Martín Nieto2014-11-081-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | If the remote is anonymous, then we cannot check for any configuration, as there is no name. Check for this before we try to use the name, which may be a NULL pointer. This fixes #2697.
| * | remote: use git_branch_upstream_remote()Carlos Martín Nieto2014-11-081-7/+8
| | | | | | | | | | | | | | | This reduces the clutter somewhat and lets us see what we're asking about the reference.
| * | branch: add getter for the upstream remote nameCarlos Martín Nieto2014-11-081-0/+23
| | | | | | | | | | | | This gets the value from branch.<foo>.remote.
* | | Merge pull request #2695 from libgit2/cmn/remote-lookupEdward Thomson2014-11-083-9/+9
|\ \ \ | | | | | | | | remote: rename _load() to _lookup()
| * | | remote: rename _load() to _lookup()cmn/remote-lookupCarlos Martín Nieto2014-11-083-9/+9
| |/ / | | | | | | | | | This brings it in line with the rest of the lookup functions.
* | | Merge pull request #2696 from libgit2/cmn/empty-objectsEdward Thomson2014-11-081-1/+23
|\ \ \ | | | | | | | | odb: hardcode the empty blob and tree
| * | | odb: hardcode the empty blob and treecmn/empty-objectsCarlos Martín Nieto2014-11-081-1/+23
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | git hardocodes these as objects which exist regardless of whether they are in the odb and uses them in the shell interface as a way of expressing the lack of a blob or tree for one side of e.g. a diff. In the library we use each language's natural way of declaring a lack of value which makes a workaround like this unnecessary. Since git uses it, it does however mean each shell application would need to perform this check themselves. This makes it common work across a range of applications and an issue with compatibility with git, which fits right into what the library aims to provide. Thus we introduce the hard-coded empty blob and tree in the odb frontend. These hard-coded objects are checked for before going to the backends, but after the cache check, which means the second time they're used, they will be treated as normal cached objects instead of creating new ones.
* | | git_status_file now takes an exact pathUngureanu Marius2014-11-071-1/+2
|/ / | | | | | | | | | | This function has one output but can match multiple files, which can be unexpected for the user, which would usually path the exact path of the file he wants the status of.
* | iterator: submodules are determined by an index or treecmn/submodule-and-dirCarlos Martín Nieto2014-11-077-9/+94
| | | | | | | | | | | | | | | | | | | | | | | | We cannot know from looking at .gitmodules whether a directory is a submodule or not. We need the index or tree we are comparing against to tell us. Otherwise we have to assume the entry in .gitmodules is stale or otherwise invalid. Thus we pass the index of the repository into the workdir iterator, even if we do not want to compare against it. This follows what git does, which even for `git diff <tree>`, it will consider staged submodules as such.
* | checkout_index: Remove stage 0 when checking out conflictsEdward Thomson2014-11-061-3/+17
| |
* | checkout_index: remove conflicts when checking out new filesEdward Thomson2014-11-061-48/+137
| |
* | Merge pull request #2598 from libgit2/cmn/stacked-ignoreEdward Thomson2014-11-062-0/+28
|\ \ | | | | | | ignore: don't leak rules into higher directores
| * | ignore: don't leak rules into higher directoriescmn/stacked-ignoreCarlos Martín Nieto2014-11-062-0/+28
| |/ | | | | | | | | | | | | | | | | | | A rule "src" in src/.gitignore must only match subdirectories of src/. The current code does not include this context in the match rule and would thus consider this rule to match the top-level src/ directory instead of the intended src/src/. Keep track fo the context in which the rule was defined so we can perform a prefix match.
* | Merge pull request #2676 from libgit2/cmn/threadingEdward Thomson2014-11-061-18/+24
|\ \ | | | | | | Threading and crypto libraries
| * | ssl: separate locking init from general initCarlos Martín Nieto2014-11-011-18/+23
| | | | | | | | | | | | | | | Extract the lock-setting functions into their own, as we cannot assume that it's ok for us to set this unconditionally.
| * | ssl: clear the OpenSSL locking functionCarlos Martín Nieto2014-11-011-0/+1
| | | | | | | | | | | | | | | We're freeing the memory which holds the locks so we must make sure that the locking function doesn't try to use it.
* | | Merge pull request #2682 from libgit2/cmn/fetch-tags-refspecEdward Thomson2014-11-061-0/+1
|\ \ \ | |_|/ |/| | remote: check for the validity of the refspec when updating FETCH_HEAD
| * | remote: check the relevance of the refspec when updating FETCH_HEADcmn/fetch-tags-refspecCarlos Martín Nieto2014-11-031-0/+1
| |/ | | | | | | | | | | Before trying to rtransform using the given refspec to figure out what the name of the upstream branch is on the remote, we must make sure that the target of the refspec applies to the current branch's upstream.
* | Merge pull request #2688 from libgit2/cmn/ignore-file-trailing-crEdward Thomson2014-11-051-1/+10
|\ \ | | | | | | ignore: consider files with a CR in their names
| * | ignore: consider files with a CR in their namescmn/ignore-file-trailing-crCarlos Martín Nieto2014-11-051-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We currently consider CR to start the end of the line, but that means that we miss cases with CR CR LF which can be used with git to match files whose names have CR at the end of their names. The fix from the patch comes from Russell's comment in the issue. This fixes #2536.
* | | git_remote_rename: propogate GIT_ENOTFOUNDEdward Thomson2014-11-031-1/+1
| | |
* | | Merge pull request #2679 from jfultz/missing-includeEdward Thomson2014-11-031-6/+12
|\ \ \ | | | | | | | | Make config reading continue after hitting a missing include file.
| * | | Clean up issues include.path issues found during code review.John Fultz2014-11-021-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Error-handling is cleaned up to only let a file-not-found error through, not other sorts of errors. And when a file-not-found error happens, we clean up the error. * Test now checks that file-not-found introduces no error. And other minor cleanups.
| * | | Make config reading continue after hitting a missing include file.John Fultz2014-11-011-7/+6
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | For example, if you have [include] path = foo and foo didn't exist, git_config_open_ondisk() would just give up on the rest of the file. Now it ignores the unresolved include without error and continues reading the rest of the file.
* | | Merge pull request #2661 from swisspol/2656Edward Thomson2014-11-031-1/+1
|\ \ \ | |_|/ |/| | Changed context_lines and interhunk_lines to uint32_t to match struct s_xdemitconf
| * | Changed context_lines and interhunk_lines to uint32_t to match struct ↵Pierre-Olivier Latour2014-10-271-1/+1
| | | | | | | | | | | | s_xdemitconf
* | | Merge pull request #2683 from libgit2/cmn/remote-unifyEdward Thomson2014-11-031-21/+2
|\ \ \ | | | | | | | | remote: unify the creation code
| * | | remote: unify the creation codecmn/remote-unifyCarlos Martín Nieto2014-11-021-21/+2
| | |/ | |/| | | | | | | | | | | | | The create function with default refspec is the same as the one with a custom refspec, but it has the default refspec, so we can create the one on top of the other.
* | | Merge pull request #2680 from libgit2/cmn/invalid-cert-returnEdward Thomson2014-11-031-1/+1
|\ \ \ | | | | | | | | netops: return GIT_ECERTIFICATE when it fails the basic tests
| * | | netops: return GIT_ECERTIFICATE when it fails the basic testscmn/invalid-cert-returnCarlos Martín Nieto2014-11-021-1/+1
| |/ / | | | | | | | | | | | | | | | | | | | | | When we first ask OpenSSL to verify the certfiicate itself (rather than the HTTPS specifics), we should also return GIT_ECERTIFICATE. Otherwise, the caller would consider this as a failed operation rather than a failed validation and not call the user's own validation.
* | | Merge pull request #2685 from libgit2/cmn/mmap-readableEdward Thomson2014-11-031-4/+2
|\ \ \ | | | | | | | | Fix segmentation fault observed on OpenBSD/sparc64
| * | | Fix segmentation fault observed on OpenBSD/sparc64cmn/mmap-readableStefan Sperling2014-11-031-4/+2
| |/ / | | | | | | | | | | | | A non-readable mapping of a file causes an access violation in the pack tests. Always use PROT_READ to work around this.
* | | Make the Visual Studio compiler happyJacques Germishuys2014-11-031-7/+8
|/ /
* | Fixed potential crash with uninitialized variablesPierre-Olivier Latour2014-10-272-2/+2
| |