summaryrefslogtreecommitdiff
path: root/src/reflog.c
Commit message (Collapse)AuthorAgeFilesLines
* reflog: use GIT_ASSERTEdward Thomson2020-11-271-14/+19
|
* tree-wide: add missing header includesPatrick Steinhardt2020-06-091-1/+2
| | | | | | | We're missing some header includes leading to missing function prototypes. While we currently don't warn about these, we should have their respective headers included in order to detect the case where a function signature change results in an incompatibility.
* tree-wide: remove unused functionsPatrick Steinhardt2020-06-081-5/+0
| | | | | We have some functions which aren't used anywhere. Let's remove them to get rid of unneeded baggage.
* reflog: allow adding entries with newlines in their messagePatrick Steinhardt2019-10-181-13/+11
| | | | | | | | | | | | | | | | | | Currently, the reflog disallows any entries that have a message with newlines, as that would effectively break the reflog format, which may contain a single line per entry, only. Upstream git behaves a bit differently, though, especially when considering stashes: instead of rejecting any reflog entry with newlines, git will simply replace newlines with spaces. E.g. executing 'git stash push -m "foo\nbar"' will create a reflog entry with "foo bar" as entry message. This commit adjusts our own logic to stop rejecting commit messages with newlines. Previously, this logic was part of `git_reflog_append`, only. There is a second place though where we add reflog entries, which is the serialization code in the filesystem refdb. As it didn't contain any sanity checks whatsoever, the refdb would have been perfectly happy to write malformatted reflog entries to the disk. This is being fixed with the same logic as for the reflog itself.
* git_error: use new names in internal APIs and usageEdward Thomson2019-01-221-3/+3
| | | | | Move to the `git_error` name in the internal API for error-related functions.
* Make sure to always include "common.h" firstPatrick Steinhardt2017-07-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | Next to including several files, our "common.h" header also declares various macros which are then used throughout the project. As such, we have to make sure to always include this file first in all implementation files. Otherwise, we might encounter problems or even silent behavioural differences due to macros or defines not being defined as they should be. So in fact, our header and implementation files should make sure to always include "common.h" first. This commit does so by establishing a common include pattern. Header files inside of "src" will now always include "common.h" as its first other file, separated by a newline from all the other includes to make it stand out as special. There are two cases for the implementation files. If they do have a matching header file, they will always include this one first, leading to "common.h" being transitively included as first file. If they do not have a matching header file, they instead include "common.h" as first file themselves. This fixes the outlined problems and will become our standard practice for header and source files inside of the "src/" from now on.
* giterr_set: consistent error messagesEdward Thomson2016-12-291-2/+2
| | | | | | | | Error messages should be sentence fragments, and therefore: 1. Should not begin with a capital letter, 2. Should not conclude with punctuation, and 3. Should not end a sentence and begin a new one
* Fix wrong format string in git_reflog_drop() error messageLinquize2015-04-241-1/+1
|
* reflog: constify byindexCarlos Martín Nieto2014-09-301-1/+1
|
* Align git_signature_dup.Arthur Schreiber2014-01-141-1/+1
| | | | | | This changes git_signature_dup to actually honor oom conditions raised by the call to git__strdup. It also aligns it with the error code return pattern used everywhere else.
* reflog: remove git_reflog_append_to()Carlos Martín Nieto2013-11-231-19/+0
| | | | | | This was a convenience method for the refs front-end to do the reflog writing. This is now done in the backend and it has no more reason for being.
* reflog: bring _append and _drop back to the frontendCarlos Martín Nieto2013-10-021-14/+86
| | | | These functions act purely on the reflog data structure.
* reflog: add a convenience append functionCarlos Martín Nieto2013-10-021-0/+19
| | | | | Provide a function that reads a reflog, performs an append and writes back to the backend in one call.
* reflog: move the reflog implementation into refdb_fsCarlos Martín Nieto2013-10-021-400/+37
| | | | | | | | | | References and their logs are logically coupled, let's make it so in the code by moving the fs-based reflog implementation to live next to the fs-based refs one. As part of the change, make the function take names rather than references, as only the names are relevant when looking up and handling reflogs.
* errors: Fix format of some error messagesnulltoken2013-09-111-1/+1
|
* Error messages for a couple other boundary conditionsRussell Belfer2013-05-011-1/+3
|
* Several warnings detected by static code analyzer fixedArkadiy Shapkin2013-03-181-1/+1
| | | | | | | Implicit type conversion argument of function to size_t type Suspicious sequence of types castings: size_t -> int -> size_t Consider reviewing the expression of the 'A = B == C' kind. The expression is calculated as following: 'A = (B == C)' Unsigned type is never < 0
* update copyrightsEdward Thomson2013-01-081-1/+1
|
* reflog: Actual error handlingVicent Marti2012-12-191-5/+13
|
* reflog: Rename error handlingVicent Marti2012-12-191-14/+15
|
* Make goto cleanup more consistentRick Bradley2012-12-181-3/+3
| | | | | There may be some question about whether this is likely to be needed at all, but that's above my head at the moment.
* don't deref before we've assertedRick Bradley2012-12-181-2/+2
| | | | just sayin'.
* reflog: Deploy EINVALIDSPEC usagenulltoken2012-12-011-3/+12
|
* Fix warnings on Win64 buildRussell Belfer2012-11-271-10/+13
|
* Rename ref and reflog apis for consistencyBen Straub2012-11-271-9/+9
|
* reflog: make entry_byindex() and drop() git compliantnulltoken2012-11-171-18/+23
| | | | | Passing 0 as the index now retrieves the most recent entry instead of the oldest one.
* Extensions to rmdir and mkdir utilitiesRussell Belfer2012-11-091-1/+1
| | | | | | | | | | | * Rework GIT_DIRREMOVAL values to GIT_RMDIR flags, allowing combinations of flags * Add GIT_RMDIR_EMPTY_PARENTS flag to remove parent dirs that are left empty after removal * Add GIT_MKDIR_VERIFY_DIR to give an error if item is a file, not a dir (previously an EEXISTS error was ignored, even for files) and enable this flag for git_futils_mkpath2file call * Improve accuracy of error messages from git_futils_mkdir
* stash: add git_stash_drop()nulltoken2012-10-261-1/+1
|
* reflog: fix bogus removal of reflog entriesnulltoken2012-10-261-6/+6
|
* reflog: create reflog and its directory structurenulltoken2012-10-261-1/+4
|
* reflog: Make git_reflog_free() accept null paramnulltoken2012-10-261-0/+3
|
* Add complex checkout test and then fix checkoutRussell Belfer2012-10-091-1/+1
| | | | | | | | | | | | | | | | This started as a complex new test for checkout going through the "typechanges" test repository, but that revealed numerous issues with checkout, including: * complete failure with submodules * failure to create blobs with exec bits * problems when replacing a tree with a blob because the tree "example/" sorts after the blob "example" so the delete was being processed after the single file blob was created This fixes most of those problems and includes a number of other minor changes that made it easier to do that, including improving the TYPECHANGE support in diff/status, etc.
* Merge remote-tracking branch 'nulltoken/topic/amd64-compat' into developmentVicent Marti2012-08-021-2/+2
|\ | | | | | | | | | | | | Conflicts: src/netops.c src/netops.h src/oid.c
| * portability: Improve x86/amd64 compatibilitynulltoken2012-07-241-2/+2
| |
* | Fix -Wuninitialized warningMichael Schubert2012-07-281-1/+1
| |
* | branch: Add `repository` argument to `create`Vicent Marti2012-07-271-1/+1
| | | | | | | | | | Yes, we can get the repository from the owner of the object, but having it marked explicitly makes the API more consistent.
* | reflog: Rename `entry_drop` to `drop`Vicent Marti2012-07-271-1/+1
| |
* | reflog: keep the reflog name in sync with the reference namenulltoken2012-07-251-0/+22
| |
* | reflog: prevent git_reflog_append() from persisting the reflog back to disknulltoken2012-07-251-81/+59
| |
* | reflog: prevent git_reflog_read() from chocking when no log exists yetnulltoken2012-07-251-9/+16
| |
* | reflog: introduce git_reflog_write()nulltoken2012-07-251-57/+113
| |
* | reflog: rename git_reflog_write() to git_reflog_append()nulltoken2012-07-251-1/+1
| |
* | reflog: introduce git_reflog_entry_drop()nulltoken2012-07-251-4/+58
| |
* | reflog: add GIT_OID_HEX_ZERO constantnulltoken2012-07-251-1/+1
|/
* refs: fix moving of the reflog when renaming a refnulltoken2012-07-071-8/+40
|
* Merge branch 'new-error-handling' into developmentVicent Martí2012-05-021-92/+85
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: .travis.yml include/git2/diff.h src/config_file.c src/diff.c src/diff_output.c src/mwindow.c src/path.c tests-clar/clar_helpers.c tests-clar/object/tree/frompath.c tests/t00-core.c tests/t03-objwrite.c tests/t08-tag.c tests/t10-refs.c tests/t12-repo.c tests/t18-status.c tests/test_helpers.c tests/test_main.c
| * Convert reflog to new errorsRussell Belfer2012-03-201-89/+82
| | | | | | | | Cleaned up some other issues.
| * error-handling: RepositoryVicent Martí2012-03-071-2/+2
| | | | | | | | | | | | | | | | This also includes droping `git_buf_lasterror` because it makes no sense in the new system. Note that in most of the places were it has been dropped, the code needs cleanup. I.e. GIT_ENOMEM is going away, so instead it should return a generic `-1` and obviously not throw anything.
| * error-handling: ReferencesVicent Martí2012-03-061-3/+3
| | | | | | | | | | Yes, this is error handling solely for `refs.c`, but some of the abstractions leak all ofer the code base.
* | Rename git_oid_to_string to git_oid_tostrAuthmillenon2012-03-061-2/+2
|/ | | | | To conform the naming scheme of git_oid_fromstr we should change the name of git_oid_to_string to git_oid_tostr.
View Lorry Controller Status