summaryrefslogtreecommitdiff
path: root/src/iterator.c
Commit message (Collapse)AuthorAgeFilesLines
* iterator: introduce `git_iterator_foreach`Edward Thomson2018-11-041-0/+29
| | | | | Introduce a `git_iterator_foreach` helper function which invokes a callback on all files for a given iterator.
* iterator: optionally hash filesystem iteratorsEdward Thomson2018-11-031-11/+50
| | | | | | | | | Optionally hash the contents of files encountered in the filesystem or working directory iterators. This is not expected to be used in production code paths, but may allow us to simplify some test contexts. For working directory iterators, apply filters as appropriate, since we have the context able to do it.
* Convert usage of `git_buf_free` to new `git_buf_dispose`Patrick Steinhardt2018-06-101-8/+8
|
* Set ctime/mtime nanosecs to 0 if USE_NSEC is not definedTomás Pollak2018-01-311-0/+3
|
* Honor 'GIT_USE_NSEC' option in `filesystem_iterator_set_current`Tomás Pollak2018-01-301-2/+4
| | | | | | This should have been part of PR #3638. Without this we still get nsec-related errors, even when using -DGIT_USE_NSEC: error: ‘struct stat’ has no member named ‘st_mtime_nsec’
* iterator: cleanups with symlink dir handlingEdward Thomson2017-12-301-14/+29
| | | | Perform some error checking when examining symlink directories.
* branches: Check symlinked subdirectoriesAndy Doan2017-12-291-1/+21
| | | | | | | | Native Git allows symlinked directories under .git/refs. This change allows libgit2 to also look for references that live under symlinked directories. Signed-off-by: Andy Doan <andy@opensourcefoundries.com>
* Make sure to always include "common.h" firstPatrick Steinhardt2017-07-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | Next to including several files, our "common.h" header also declares various macros which are then used throughout the project. As such, we have to make sure to always include this file first in all implementation files. Otherwise, we might encounter problems or even silent behavioural differences due to macros or defines not being defined as they should be. So in fact, our header and implementation files should make sure to always include "common.h" first. This commit does so by establishing a common include pattern. Header files inside of "src" will now always include "common.h" as its first other file, separated by a newline from all the other includes to make it stand out as special. There are two cases for the implementation files. If they do have a matching header file, they will always include this one first, leading to "common.h" being transitively included as first file. If they do not have a matching header file, they instead include "common.h" as first file themselves. This fixes the outlined problems and will become our standard practice for header and source files inside of the "src/" from now on.
* common: use PRIuZ for size_t in `giterr_set` callsPatrick Steinhardt2016-11-141-1/+1
|
* filesystem_iterator: fixed double free on errorJason Haslam2016-08-221-5/+3
|
* iterator: ignore submodule in has_endedEdward Thomson2016-04-211-4/+3
|
* iterator: support trailing `/` in start for submodEdward Thomson2016-04-021-10/+26
| | | | | | Allow callers to specify a start path with a trailing slash to match a submodule, instead of just a directory. This is for some legacy behavior that's sort of dumb, but there it is.
* Merge pull request #3719 from libgit2/ethomson/submodule_statusCarlos Martín Nieto2016-04-011-1/+1
|\ | | | | WD iterator: properly identify submodules
| * iterator: use correct search functionethomson/submodule_statusEdward Thomson2016-03-311-1/+1
| |
* | leaks: fix some iterator leaksEdward Thomson2016-03-311-6/+22
| |
* | Plug a few leaksCarlos Martín Nieto2016-03-311-0/+14
|/
* iterator: comment fixedMarc Strapetz2016-03-241-2/+2
|
* iterator: unused includes removedMarc Strapetz2016-03-241-4/+0
|
* iterator: cleanupsEdward Thomson2016-03-241-345/+48
| | | | Remove some unused functions, refactor some ugliness.
* iterator: refactor empty iterator to new styleEdward Thomson2016-03-241-15/+36
|
* iterator: mandate `advance_over`Edward Thomson2016-03-241-1/+10
| | | | | Since the three iterators implement `advance_over` differently, mandate it and implement each.
* iterator: refactor index iteratorEdward Thomson2016-03-241-200/+194
|
* iterator: move the index into the iterator itselfEdward Thomson2016-03-241-33/+8
|
* iterator: test that we're at the end of iterationEdward Thomson2016-03-231-1/+3
| | | | | | | Ensure that we have hit the end of iteration; previously we tested that we saw all the values that we expected to see. We did not then ensure that we were at the end of the iteration (and that there were subsequently values in the iteration that we did *not* expect.)
* iterator: combine fs+workdir iterators more completelyEdward Thomson2016-03-231-905/+1029
| | | | | | | | | | | | | Drop some of the layers of indirection between the workdir and the filesystem iterators. This makes the code a little bit easier to follow, and reduces the number of unnecessary allocations a bit as well. (Prior to this, when we filter entries, we would allocate them, filter them and then free them; now we do the filtering before allocation.) Also, rename `git_iterator_advance_over_with_status` to just `git_iterator_advance_over`. Mostly because it's a fucking long-ass function name otherwise.
* iterators: refactored tree iteratorEdward Thomson2016-03-231-391/+627
| | | | | | | | Refactored the tree iterator to never recurse; simply process the next entry in order in `advance`. Additionally, reduce the number of allocations and sorting as much as possible to provide a ~30% speedup on case-sensitive iteration. (The gains for case-insensitive iteration are less majestic.)
* git_object_dup: introduce typesafe versionsEdward Thomson2016-03-231-2/+2
|
* iterator: disambiguate reset and reset_rangeEdward Thomson2016-03-231-19/+50
| | | | | | Disambiguate the reset and reset_range functions. Now reset_range with a NULL path will clear the start or end; reset will leave the existing start and end unchanged.
* iterator: drop unused/unimplemented `seek`Edward Thomson2016-03-231-29/+0
|
* tree: re-use the id and filename in the odb objectCarlos Martín Nieto2016-03-201-2/+2
| | | | | Instead of copying over the data into the individual entries, point to the originals, which are already in a format we can use.
* Merge pull request #3619 from ethomson/win32_forbiddenCarlos Martín Nieto2016-02-181-3/+9
|\ | | | | win32: allow us to read indexes with forbidden paths on win32
| * iterator: assert tree_iterator has a frameEdward Thomson2016-02-171-7/+11
| | | | | | | | | | | | | | Although a `tree_iterator` that failed to be properly created does not have a frame, all other `tree_iterator`s should. Do not call `pop` in the failure case, but assert that in all other cases there is a frame.
| * Validate pointer before access the member.Colin Xu2016-02-171-3/+5
| | | | | | | | | | | | | | | | When Git repository at network locations, sometimes git_iterator_for_tree fails at iterator__update_ignore_case so it goes to git_iterator_free. Null pointer will crash the process if not check. Signed-off-by: Colin Xu <colin.xu@gmail.com>
* | Horrible fix for #3173.Arthur Schreiber2016-02-111-2/+3
|/
* pool: Simplify implementationVicent Marti2015-10-281-3/+4
|
* iterator: loop fs_iterator advance (don't recurse)Edward Thomson2015-09-131-35/+50
|
* iterator: advance the tree iterator smartlyEdward Thomson2015-09-111-42/+56
| | | | | | | | | | | | | | | | | | | | | | | | While advancing the tree iterator, if we advance over things that we aren't interested in, then call `current`. Which may *itself* call advance. While advancing the tree iterator, if we advance over things that we aren't interested in, then call `current`. Which may *itself* call advance. While advancing the tree iterator, if we advance over things that we aren't interested in, then call `current`. Which may *itself* call advance. While advancing the tree iterator, if we advance over things that we aren't interested in, then call `current`. Which may *itself* call advance. While advancing the tree iterator, if we advance over things that we aren't interested in, then call `current`. Which may *itself* call advance. Error: stack overflow.
* iterator: saner pathlist matching for idx iteratorEdward Thomson2015-08-311-62/+76
| | | | | | | | | | | | Some nicer refactoring for index iteration walks. The index iterator doesn't binary search through the pathlist space, since it lacks directory entries, and would have to binary search each index entry and all its parents (eg, when presented with an index entry of `foo/bar/file.c`, you would have to look in the pathlist for `foo/bar/file.c`, `foo/bar` and `foo`). Since the index entries and the pathlist are both nicely sorted, we walk the index entries in lockstep with the pathlist like we do for other iteration/diff/merge walks.
* tree_iterator: use a pathlistEdward Thomson2015-08-301-1/+34
|
* diff: use new iterator pathlist handlingEdward Thomson2015-08-301-106/+186
| | | | | | | | When using literal pathspecs in diff with `GIT_DIFF_DISABLE_PATHSPEC_MATCH` turn on the faster iterator pathlist handling. Updates iterator pathspecs to include directory prefixes (eg, `foo/`) for compatibility with `GIT_DIFF_DISABLE_PATHSPEC_MATCH`.
* iterator: sort subdirs properly with pathlistEdward Thomson2015-08-281-6/+15
| | | | | | | | | | When given a pathlist, don't assume that directories sort before files. Walk through any list of entries sorting before us to make sure that we've exhausted all entries that *aren't* directories. Eg, if we're searching for 'foo/bar', and we have a 'foo.c', keep advancing the pathlist to keep looking for an entry prefixed with 'foo/'.
* Move filelist into the iterator handling itself.Edward Thomson2015-08-281-8/+107
|
* iterator: use an options struct instead of argsEdward Thomson2015-08-281-25/+20
|
* errors: tighten up git_error_state OOMs a bit moreEdward Thomson2015-08-031-2/+2
| | | | | When an error state is an OOM, make sure that we treat is specially and do not try to free it.
* iterator: skip over errors in diriter initCarlos Martín Nieto2015-07-261-1/+4
| | | | | | | | | An error here will typically mean that the directory was removed between the time we iterated the parent and the time we wanted to visit it in which case we should ignore it. Other kinds of errors such as permissions (or transient errors) also better dealt with by pretending we didn't see it.
* iterator_walk: cast away constness for freeEdward Thomson2015-07-021-2/+2
|
* iterator_walk: drop unused variableEdward Thomson2015-06-291-5/+0
|
* index, iterator, fetchhead: plug leaksleaksCarlos Martín Nieto2015-06-261-0/+3
|
* iterator: provide git_iterator_walkEdward Thomson2015-06-251-0/+88
| | | | | Provide `git_iterator_walk` to walk each iterator in lockstep, returning each iterator's idea of the contents of the next path.
* diff: check files with the same or newer timestampsCarlos Martín Nieto2015-06-221-0/+12
| | | | | | | | | | When a file on the workdir has the same or a newer timestamp than the index, we need to perform a full check of the contents, as the update of the file may have happened just after we wrote the index. The iterator changes are such that we can reach inside the workdir iterator from the diff, though it may be better to have an accessor instead of moving these structs into the header.
View Lorry Controller Status