summaryrefslogtreecommitdiff
path: root/cmake
Commit message (Collapse)AuthorAgeFilesLines
* cmake: use PROJECT_SOURCE_DIR of CMAKE_SOURCE_DIRJosh Junon2021-12-235-11/+11
| | | | | | | | | | | | | | | | | | | | | | | Also applies to *_BINARY_DIR. This effectively reverts 84083dcc8bd41332ccac9d7b537f3e254d79011c, which broke all users of libgit2 that use it as a CMake subdirectory (via `add_subdirectory()`). This is because CMAKE_SOURCE_DIR refers to the root-most CMake directory, which in the case of `add_subdirectory()` is a parent project to libgit2 and thus the paths don't make any sense to the configuration files. Corollary, CMAKE_SOURCE_DIR only makes sense if the CMake project is always the root project - which can rarely be guaranteed. In all honesty, CMake should deprecate and eventually remove CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR. It's been the source of headaches and confusion for years, they're rarely useful over CMAKE_CURRENT_(SOURCE|BINARY)_DIR or PROJECT_(SOURCE|BINARY)_DIR, and they cause a lot of confusing configuration and source code layouts to boot. Any time they are used, they break `add_subdirectory()` almost 100% of the time, cause confusing error messages, and hide subtle bugs.
* cmake: use CMAKE_SOURCE_DIR and CMAKE_BINARY_DIRethomson/cleanupEdward Thomson2021-11-225-11/+11
| | | | | | Instead of using the project-specific `libgit2_SOURCE_DIR` and `libgit2_BINARY_DIR` variables, use `CMAKE_SOURCE_DIR` and `CMAKE_BINARY_DIR`.
* cmake: use WINHTTP when USE_WINHTTP is specifiedethomson/cmake_testEdward Thomson2021-11-171-1/+1
|
* cmake: move sha1 source selection into CMakeLists.txtEdward Thomson2021-11-141-12/+2
| | | | | The select hashes module selects the hash; the CMakeLists.txt selects the files to implement it.
* cmake: refactor global variablesEdward Thomson2021-11-148-26/+26
| | | | | Update the global variables `LIBGIT2_OBJECTS` to `LIBGIT2_DEPENDENCY_OBJECTS` for clarity and consistency.
* cmake: reformat modulesEdward Thomson2021-11-1420-812/+689
| | | | Apply the standard project cmake formatting to the modules.
* cmake: move missing-declarations warning to top-levelEdward Thomson2021-11-111-0/+1
| | | | | We should enforce declarations throughout the code-base, including examples, fuzzers and tests, not just in the `src` tree.
* cmake: refactor zlib selectionethomson/cmake3Edward Thomson2021-11-111-0/+34
| | | | Move zlib selection into its own cmake module.
* cmake: refactor WinHTTP selectionEdward Thomson2021-11-111-0/+17
| | | | Move WinHTTP selection into its own cmake module.
* cmake: refactor libssh2 selectionEdward Thomson2021-11-111-0/+41
| | | | Move SSH selection into its own cmake module.
* cmake: refactor regex selectionEdward Thomson2021-11-111-0/+51
| | | | Move regex selection into its own cmake module.
* cmake: refactor http_parser selectionEdward Thomson2021-11-111-0/+19
| | | | Move http_parser selection into its own cmake module.
* cmake: HTTP_Parser is now HTTPParserEdward Thomson2021-11-111-0/+0
|
* cmake: move cflag defaults into a separate moduleEdward Thomson2021-11-111-0/+153
|
* cmake: standardize USE_WINHTTPEdward Thomson2021-11-111-1/+1
| | | | | WinHTTP can now be disabled with `USE_WINHTTP=OFF` instead of `WINHTTP=OFF` to better support the other cmake semantics.
* cmake: standardize USE_THREADS and USE_NSECEdward Thomson2021-11-111-18/+12
| | | | | | | | Threading can now be disabled with `USE_THREADS=OFF` instead of `THREADSAFE=OFF` to better support the other cmake semantics. Nanosecond support is the default _if_ we can detect it. This should be our default always - like threads - and people can opt out explicitly.
* libgit2_clar is now libgit2_testsMartin Kühl2021-10-281-1/+1
| | | | | | in #6083 the test runner was renamed to libgit2_tests, but not all references to the old name were updated. this change changes all of them to use the new name.
* Discover libssh2 without pkg-configLaurent Stacul2021-09-141-0/+13
|
* cmake: select hashes umbrella variable has been removed.Dmitry Lobanov2021-08-281-2/+1
| | | Co-authored-by: Edward Thomson <ethomson@github.com>
* cmake: select hashes missing umbrella header has been added.Dmitry Lobanov2021-08-281-0/+2
|
* openssl: dynamically load libssl and symbols (optionally)Edward Thomson2021-08-241-0/+4
| | | | | | | | | | Provide an interface around OpenSSL to dynamically load the libraries and symbols, so that users can distribute a libgit2 library that is not linked directly against OpenSSL. This enables users to target multiple distributions with a single binary. This mechanism is optional and disabled by default. Configure cmake with -DUSE_HTTPS=OpenSSL-Dynamic to use it.
* cmake: extended futimens checking on macOSethomson/futimensEdward Thomson2021-07-301-0/+14
|
* cmake: remove CheckPrototypeDefinition modulePatrick Steinhardt2020-07-122-125/+0
| | | | | | | | | In the past, we've imported the CheckPrototypeDefinition into our own module directory as it wasn't yet available in all supported CMake versions. Now that we require at least CMake v3.5, we don't need to bundle it anymore as it's included with the distribution already. Let's drop the included modules and always use upstream's version.
* cmake: move modules into the "cmake/" top level dirPatrick Steinhardt2020-06-0121-0/+0
| | | | | | | | Our custom CMake module currently live in "cmake/Modules". As the "cmake/" directory doesn't contain anything except the "Modules" directory, it doesn't really make sense to have the additional intermediate directory. So let's instead move the modules one level up into the "cmake/" top level directory.
* cmake: Sort source files for reproducible buildspks/cmake-sort-reproducible-buildsPatrick Steinhardt2020-05-151-0/+2
| | | | | | | | | | | We currently use `FILE(GLOB ...)` in most places to find source and header files. This is problematic in that the order of files returned depends on the operating system's directory iteration order and may thus not be deterministic. As a result, we link object files in unspecified order, which may cause the linker to emit different code across runs. Fix this issue by sorting all code used as input to the libgit2 library to improve the reliability of reproducible builds.
* cmake: streamline backend detectionPatrick Steinhardt2020-04-013-86/+61
| | | | | | | We're currently doing unnecessary work to auto-detect backends even if the functionality is disabled altogether. Let's fix this by removing the extraneous FOO_BACKEND variables, instead letting auto-detection modify the variable itself.
* cmake: use install directories provided via GNUInstallDirsPatrick Steinhardt2020-03-141-5/+3
| | | | | | | | | | | | | | | | | | | | | | | We currently hand-code logic to configure where to install our artifacts via the `LIB_INSTALL_DIR`, `INCLUDE_INSTALL_DIR` and `BIN_INSTALL_DIR` variables. This is reinventing the wheel, as CMake already provide a way to do that via `CMAKE_INSTALL_<DIR>` paths, e.g. `CMAKE_INSTALL_LIB`. This requires users of libgit2 to know about the discrepancy and will require special hacks for any build systems that handle these variables in an automated way. One such example is Gentoo Linux, which sets up these paths in both the cmake and cmake-utils eclass. So let's stop doing that: the GNUInstallDirs module handles it in a better way for us, especially so as the actual values are dependent on CMAKE_INSTALL_PREFIX. This commit removes our own set of variables and instead refers users to use the standard ones. As a second benefit, this commit also fixes our pkgconfig generation to use the GNUInstallDirs module. We had a bug there where we ignored the CMAKE_INSTALL_PREFIX when configuring the libdir and includedir keys, so if libdir was set to "lib64", then libdir would be an invalid path. With GNUInstallDirs, we can now use `CMAKE_INSTALL_FULL_LIBDIR`, which handles the prefix for us.
* Merge pull request #5422 from pks-t/pks/cmake-booleansEdward Thomson2020-03-064-0/+29
|\ | | | | CMake booleans
| * cmake: sanitize boolean options passed by userPatrick Steinhardt2020-02-244-0/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Starting with our conversions to mix backend-autodetection and selection into a single variable (USE_GSSAPI, USE_HTTPS, USE_SHA1), we have introduced a simple STREQUAL to check for "ON", which indicates that the user wants us to auto-detect available backends and pick any one that's available. This behaviour deviates from previous behaviour, as passing a value like "yes", "on" or "true" will in fact be treated like a backend name and result in autodetection failure. Fix the issue by introducing a new function `SanitizeBool`. Given a variable that may hold a boolean value, the function will sanitize that variable to hold either "ON" or "OFF". In case it is not a recognized boolean, we will just keep the value as-is. This fixes the above described issue.
* | Fix #5410: fix installing libgit2.pc in wrong locationTomasz Kłoczko2020-02-191-35/+4
|/ | | | | | | | Remove using custom PKG_BUILD_PREFIu, PKG_BUILD_LIBDIR and PKG_BUILD_INCLUDEDIR variables. Use cmake CMAKE_INSTALL_PREFIX, LIB_INSTALL_DIR, INCLUDE_INSTALL_DIR instead. This patch fixes install libgit2.pc file in correct location and simpifies cmake module.
* gssapi: show information about disabled GSSAPIEdward Thomson2020-01-241-1/+1
| | | | | | When USE_GSSAPI=OFF, still show information about what SPNEGO is, even though it's disabled. This is for parity with other disabled features like SSH and debugpool that still show details about what is disabled.
* Merge pull request #5238 from tiennou/feature/macos-gssPatrick Steinhardt2019-10-172-0/+81
|\ | | | | macOS GSS Support
| * negotiate: use GSS.framework on macOSEtienne Samson2019-10-132-0/+81
| |
* | cmake: correct the link stanza for CoreFoundationEtienne Samson2019-10-131-1/+1
|/ | | | | | | | LIBRARIES is the (absolute?) path to the library. LDFLAGS is the full linker stanza to correctly link with this lib. By passing LIBRARIES as LIBGIT_LIBS, the linker ends up with the absolute path for the SDK'ed version of CoreFoundation (which doesn't exist), instead of the familiar `-framework CoreFoundation`.
* Merge pull request #5226 from pks-t/pks/regexp-apiEdward Thomson2019-09-281-3/+2
|\ | | | | regexp: implement a new regular expression API
| * posix: remove superseded POSIX regex wrappersPatrick Steinhardt2019-09-211-3/+2
| | | | | | | | | | | | The old POSIX regex wrappers have been superseded by our own regexp API that provides a higher-level abstraction. Remove the POSIX wrappers in favor of the new one.
* | cmake: streamline *.pc file handling via a moduleEtienne Samson2019-09-141-0/+110
|/
* cmake: fix various misuses of MESSAGE()Patrick Steinhardt2019-09-134-7/+7
| | | | | | | | | | The MESSAGE() function expects as first argument the message type, e.g. STATUS or FATAL_ERROR. In some places, we were misusing this to either not provide any type, which would then erroneously print the message to standard error, or to use FATAL instead of FATAL_ERROR. Fix all of these instances. Also, remove some MESSAGE invocations that are obvious leftovers from debugging the build system.
* cmake: properly abort if no mbedTLS cert location is foundPatrick Steinhardt2019-09-131-1/+1
| | | | | | | | | | | | When using mbedTLS as backend, then the user may specify the location of where system certificates are installed. If no such location is provided by the user, CMake will try to autodetect the location by using the openssl executable, if installed. If no location could be detected, then the mbedTLS is essentially worthless as it is completely unable to verify any certificates. To avoid use of such misconfigured mbedTLS configurations, let's error out if we were unable to find out the location.
* cmake: remove extraneous loggingEtienne Samson2019-09-101-2/+0
|
* cmake: include SHA1 headers into our source filesPatrick Steinhardt2019-07-181-6/+6
| | | | | | | | | | | | When selecting the SHA1 backend, we only include the respective C implementation of the selected backend. But since commit bd48bf3fb (hash: introduce source files to break include circles, 2019-06-14), we have introduced separate headers and compilation units for all hashes. So by not including the headers, we may not honor them to compute whether a file needs to be recompiled and they also will not be displayed in IDEs. Add the header files to fix this problem.
* cmake: report whether we are using sub-second stat informationPatrick Steinhardt2019-07-111-0/+6
| | | | | | | | | | Depending on the platform and on build options, we may or may not build libgit2 with support for nanoseconds when using `stat` calls. It's currently unclear though whether sub-second stat information is used at all. Add feature info for this to tell at configure time whether it's being used or not.
* Merge pull request #4438 from pks-t/pks/hash-algorithmPatrick Steinhardt2019-06-271-4/+6
|\ | | | | Multiple hash algorithms
| * hash: move SHA1 implementations into 'sha1/' folderPatrick Steinhardt2019-06-241-6/+6
| | | | | | | | | | | | | | | | | | | | | | As we will include additional hash algorithms in the future due to upstream git discussing a move away from SHA1, we should accomodate for that and prepare for the move. As a first step, move all SHA1 implementations into a common subdirectory. Also, create a SHA1-specific header file that lives inside the hash folder. This header will contain the SHA1-specific header includes, function declarations and the SHA1 context structure.
| * hash: introduce source files to break include circlesPatrick Steinhardt2019-06-241-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The hash source files have circular include dependencies right now, which shows by our broken generic hash implementation. The "hash.h" header declares two functions and the `git_hash_ctx` typedef before actually including the hash backend header and can only declare the remaining hash functions after the include due to possibly static function declarations inside of the implementation includes. Let's break this cycle and help maintainability by creating a real implementation file for each of the hash implementations. Instead of relying on the exact include order, we now especially avoid the use of `GIT_INLINE` for function declarations.
* | win32: support upgrading warnings to errors (/WX)Edward Thomson2019-06-241-1/+5
|/ | | | | | | | | | | For MSVC, support warnings as errors by providing the /WX compiler flags. (/WX is the moral equivalent of -Werror.) Disable warnings as errors ass part of xdiff, since it contains warnings. But as a component of git itself, we want to avoid skew and keep our implementation as similar as possible to theirs. We'll work with upstream to fix these issues, but in the meantime, simply let those continue to warn.
* cmake: Modulize our TLS & hash detectionEtienne Samson2019-06-142-0/+190
| | | | | | | | | | | | | | | The interactions between `USE_HTTPS` and `SHA1_BACKEND` have been streamlined. Previously we would have accepted not quite working configurations (like, `-DUSE_HTTPS=OFF -DSHA1_BACKEND=OpenSSL`) and, as the OpenSSL detection only ran with `USE_HTTPS`, the link would fail. The detection was moved to a new `USE_SHA1`, modeled after `USE_HTTPS`, which takes the values "CollisionDetection/Backend/Generic", to better match how the "hashing backend" is selected, the default (ON) being "CollisionDetection". Note that, as `SHA1_BACKEND` is still used internally, you might need to check what customization you're using it for.
* regex: optionally use PCRE2Edward Thomson2019-05-191-0/+38
| | | | | | | Use PCRE2 and its POSIX compatibility layer if requested by the user. Although PCRE2 is adequate for our needs, the PCRE2 POSIX layer as installed on Debian and Ubuntu systems is broken, so we do not opt-in to it by default to avoid breaking users on those platforms.
* regex: use system PCRE if availableEdward Thomson2019-05-191-0/+38
| | | | | Attempt to locate a system-installed version of PCRE and use its POSIX compatibility layer, if possible.
* fix typocheese12019-04-071-1/+1
|
View Lorry Controller Status