summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Introduce CI with GitHub Actionsethomson/github_actionsEdward Thomson2020-06-164-2/+263
| | | | | | | | | | | | | | | | | | | Add CI using GitHub Actions and GitHub Packages: * This moves our Linux build containers into GitHub Packages; we will identify the most recent commit that updated the docker descriptions, and then look for a docker image in libgit2's GitHub Packages registry for a container with the tag corresponding to that description. If there is not one, we will build the container and then push it to GitHub Packages. * We no longer need to manage authentication with our own credentials or PAT tokens. GitHub Actions provides a GITHUB_TOKEN that can publish artifacts, packages and commits to our repository within a workflow run. * We will use a matrix to build our various CI steps. This allows us to keep configuration in a single place without multiple YAML files.
* docker: don't take BASE as an argumentEdward Thomson2020-06-112-4/+2
| | | | | | The xenial image depends on ubuntu:xenial; the bionic one on ubuntu:bionic. No need for this to be a variable, that's just additional (unnecessary) state to manage in the CI setup(s).
* azure pipelines: use bundled zlibEdward Thomson2020-06-101-2/+2
| | | | | | Azure Pipelines has a version of zlib hanging out on the filesystem; avoid trying to use it as it's either 64 _or_ 32 bit, so exactly one of our builds will fail.
* Merge pull request #5551 from pks-t/pks/missing-declarationsPatrick Steinhardt2020-06-1052-124/+148
|\ | | | | Missing declarations
| * cmake: enable warnings for missing function declarationsPatrick Steinhardt2020-06-091-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | Over time, we have accumulated quite a lot of functions with missing prototypes, missing `static` keywords or which were completely unused. It's easy to miss these mistakes, but luckily GCC and Clang both have the `-Wmissing-declarations` warning. Enabling this will cause them to emit warnings for every not-static function that doesn't have a previous declaration. This is a very sane thing to enable, and with the preceding commits all these new warnings have been fixed. So let's always enable this warning so we won't introduce new instances of them.
| * refs: add missing function declarationPatrick Steinhardt2020-06-091-0/+1
| | | | | | | | | | | | The function `git_reference__is_note` is not declared anywhere. Let's add the declaration to avoid having non-static functions without declaration.
| * tree-wide: do not compile deprecated functions with hard deprecationPatrick Steinhardt2020-06-0931-6/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When compiling libgit2 with -DDEPRECATE_HARD, we add a preprocessor definition `GIT_DEPRECATE_HARD` which causes the "git2/deprecated.h" header to be empty. As a result, no function declarations are made available to callers, but the implementations are still available to link against. This has the problem that function declarations also aren't visible to the implementations, meaning that the symbol's visibility will not be set up correctly. As a result, the resulting library may not expose those deprecated symbols at all on some platforms and thus cause linking errors. Fix the issue by conditionally compiling deprecated functions, only. While it becomes impossible to link against such a library in case one uses deprecated functions, distributors of libgit2 aren't expected to pass -DDEPRECATE_HARD anyway. Instead, users of libgit2 should manually define GIT_DEPRECATE_HARD to hide deprecated functions. Using "real" hard deprecation still makes sense in the context of CI to test we don't use deprecated symbols ourselves and in case a dependant uses libgit2 in a vendored way and knows it won't ever use any of the deprecated symbols anyway.
| * tree-wide: add missing header includesPatrick Steinhardt2020-06-093-4/+7
| | | | | | | | | | | | | | We're missing some header includes leading to missing function prototypes. While we currently don't warn about these, we should have their respective headers included in order to detect the case where a function signature change results in an incompatibility.
| * tree-wide: mark local functions as staticPatrick Steinhardt2020-06-0920-61/+59
| | | | | | | | | | | | | | We've accumulated quite some functions which are never used outside of their respective code unit, but which are lacking the `static` keyword. Add it to reduce their linkage scope and allow the compiler to optimize better.
| * tree-wide: remove unused functionsPatrick Steinhardt2020-06-084-53/+0
|/ | | | | We have some functions which aren't used anywhere. Let's remove them to get rid of unneeded baggage.
* Revert .github/workflows/main.ymlEdward Thomson2020-06-071-111/+0
|
* yoEdward Thomson2020-06-072-10/+2
|
* Update main.ymlEdward Thomson2020-06-071-1/+1
|
* Update main.ymlEdward Thomson2020-06-071-36/+36
|
* Update main.ymlEdward Thomson2020-06-071-3/+1
|
* Update main.ymlEdward Thomson2020-06-071-1/+1
|
* Update main.ymlEdward Thomson2020-06-071-1/+1
|
* Update main.ymlEdward Thomson2020-06-071-1/+1
|
* Update bionicEdward Thomson2020-06-071-0/+1
|
* Update xenialEdward Thomson2020-06-071-0/+1
|
* Update xenialEdward Thomson2020-06-071-1/+4
|
* Update bionicEdward Thomson2020-06-071-1/+4
|
* Update main.ymlEdward Thomson2020-06-061-1/+2
|
* Update main.ymlEdward Thomson2020-06-061-1/+2
|
* Update main.ymlEdward Thomson2020-06-061-2/+3
|
* Update main.ymlEdward Thomson2020-06-061-2/+1
|
* Update main.ymlEdward Thomson2020-06-061-1/+3
|
* Update main.ymlEdward Thomson2020-06-061-1/+1
|
* Update main.ymlEdward Thomson2020-06-061-4/+12
|
* Update main.ymlEdward Thomson2020-06-061-2/+2
|
* Update main.ymlEdward Thomson2020-06-061-2/+20
|
* Update main.ymlEdward Thomson2020-06-061-2/+1
|
* Update main.ymlEdward Thomson2020-06-061-0/+1
|
* Update main.ymlEdward Thomson2020-06-061-1/+3
|
* Update main.ymlEdward Thomson2020-06-061-1/+1
|
* Update main.ymlEdward Thomson2020-06-061-0/+1
|
* Update main.ymlEdward Thomson2020-06-061-5/+8
|
* Update main.ymlEdward Thomson2020-06-061-1/+4
|
* Update main.ymlEdward Thomson2020-06-061-0/+4
|
* Update main.ymlEdward Thomson2020-06-061-1/+0
|
* Update main.ymlEdward Thomson2020-06-061-0/+6
|
* Update main.ymlEdward Thomson2020-06-061-1/+3
|
* Update main.ymlEdward Thomson2020-06-061-4/+7
|
* Update main.ymlEdward Thomson2020-06-061-4/+4
|
* Update main.ymlEdward Thomson2020-06-061-4/+4
|
* Update main.ymlEdward Thomson2020-06-061-0/+12
|
* Update main.ymlEdward Thomson2020-06-061-3/+1
|
* Update main.ymlEdward Thomson2020-06-061-1/+3
|
* Update main.ymlEdward Thomson2020-06-061-2/+2
|
* Update main.ymlEdward Thomson2020-06-061-2/+2
|
View Lorry Controller Status