summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * cmake: move fuzzer args to the fuzzer's cmakeEdward Thomson2021-11-112-15/+5
| |
| * cmake: move deprecation definition to src/Edward Thomson2021-11-112-4/+4
| | | | | | | | | | There's no need to add the deprecation at the top-level. Our tests add deprecation explicitly.
| * cmake: move cflag defaults into a separate moduleEdward Thomson2021-11-112-171/+171
| |
| * cmake: USE_SSH is not on by defaultEdward Thomson2021-11-113-21/+21
| |
| * cmake: standardize USE_WINHTTPEdward Thomson2021-11-113-4/+4
| | | | | | | | | | WinHTTP can now be disabled with `USE_WINHTTP=OFF` instead of `WINHTTP=OFF` to better support the other cmake semantics.
| * cmake: standardize USE_THREADS and USE_NSECEdward Thomson2021-11-116-36/+33
| | | | | | | | | | | | | | | | Threading can now be disabled with `USE_THREADS=OFF` instead of `THREADSAFE=OFF` to better support the other cmake semantics. Nanosecond support is the default _if_ we can detect it. This should be our default always - like threads - and people can opt out explicitly.
* | Merge pull request #6111 from libgit2/ethomson/str_freeEdward Thomson2021-11-111-7/+0
|\ \ | |/ |/| str: git_str_free is never a function
| * str: git_str_free is never a functionEdward Thomson2021-11-111-7/+0
|/
* Merge pull request #6104 from libgit2/ethomson/pathEdward Thomson2021-11-11123-3769/+4042
|\ | | | | path: refactor utility path functions
| * win32: include correct path headerethomson/pathEdward Thomson2021-11-094-4/+4
| |
| * fs_path: remove now-unused validation functionsEdward Thomson2021-11-092-68/+0
| |
| * fs_path: add length with suffix validationEdward Thomson2021-11-094-3/+30
| |
| * path: use new length validation functionsEdward Thomson2021-11-0910-20/+36
| |
| * path: length validation respecting core.longpathsEdward Thomson2021-11-093-18/+69
| | | | | | | | | | Teach `git_path_is_valid` to respect `core.longpaths`. Add helper methods to validate length and set the error message appropriately.
| * path: introduce `git_path_str_is_valid`Edward Thomson2021-11-095-18/+28
| | | | | | | | | | Add a `git_str` based validity check; the existing `git_path_is_valid` defers to it.
| * fs_path: add long path validation on windowsEdward Thomson2021-11-093-4/+37
| |
| * fs_path: make empty component validation optionalEdward Thomson2021-11-093-15/+38
| |
| * fs_path: introduce `str_is_valid`Edward Thomson2021-11-093-19/+81
| | | | | | | | | | | | | | | | | | | | Provide a mechanism for users to limit the number of characters that are examined; `git_fs_path_str_is_valid` and friends will only examine up to `str->size` bytes. `git_fs_path_is_valid` delegates to these new functions by passing `SIZE_MAX` (instead of doing a `strlen`), which is a sentinel value meaning "look for a NUL terminator".
| * path: `validate` -> `is_valid`Edward Thomson2021-11-098-77/+77
| | | | | | | | | | Since we're returning a boolean about validation, the name is more properly "is valid".
| * fs_path: `validate` -> `is_valid`Edward Thomson2021-11-094-139/+139
| | | | | | | | | | Since we're returning a boolean about validation, the name is more properly "is valid".
| * path: separate git-specific path functions from utilEdward Thomson2021-11-09123-3775/+3894
| | | | | | | | | | | | Introduce `git_fs_path`, which operates on generic filesystem paths. `git_path` will be kept for only git-specific path functionality (for example, checking for `.git` in a path).
* | Merge pull request #6107 from joshtriplett/refresh-handlingEdward Thomson2021-11-119-13/+228
|\ \ | | | | | | Support checking for object existence without refresh
| * | Omit trailing comma on enum Josh Triplett2021-11-081-1/+1
| | | | | | | | | | | | | | | To accommodate less capable compilers. Co-authored-by: Peter Pettersson <85582231+boretrk@users.noreply.github.com>
| * | Add tests for ODB refreshJosh Triplett2021-11-086-7/+198
| | | | | | | | | | | | | | | Add optional refreshing in the fake backend, and count the number of refresh calls if enabled.
| * | Support checking for object existence without refreshJosh Triplett2021-11-082-1/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Looking up a non-existent object currently always invokes `git_odb_refresh`. If looking up a large batch of objects, many of which may legitimately not exist, this will repeatedly refresh the ODB to no avail. Add a `git_odb_exists_ext` that accepts flags controlling the ODB lookup, and add a flag to suppress the refresh. This allows the user to control if and when they refresh (for instance, refreshing once before starting the batch).
| * | Update documentation for ODB backend refresh logicJosh Triplett2021-11-081-5/+2
| | | | | | | | | | | | | | | | | | | | | Commit b1a6c316a6070fac4ab1ec5792979838f7145c39 moved auto-refresh into the pack backend, and added a comment accordingly. Commit 43820f204ea32503b4083e3b6b83f30a0a0031c9 moved auto-refresh back *out* of backends into the ODB layer, but didn't update the comment.
* | | Merge pull request #6109 from joshtriplett/document-odb-race-freeEdward Thomson2021-11-111-0/+3
|\ \ \ | |_|/ |/| | Document that `git_odb` is thread-safe
| * | Document that `git_odb` is thread-safeJosh Triplett2021-11-111-0/+3
|/ / | | | | | | | | | | | | Commit 4ae41f9c639d246d34dac89c3f1d9451c9cfa8d3 made `git_odb` race-free, and added internal locking. Update `docs/threading.md` accordingly, so that APIs built atop libgit2 (e.g. language bindings) can count on this.
* | Merge pull request #6108 from libgit2/ethomson/docs_ciEdward Thomson2021-11-091-1/+1
|\ \ | |/ |/| ci: only update docs on push
| * ci: only update docs on pushethomson/docs_ciEdward Thomson2021-11-091-1/+1
|/ | | Only update the documentation on a `push`. We were previously updating the documentation only when not in a `pull_request`, which meant that we would push documentation updates in manual build triggers.
* Merge pull request #6100 from mkhl/tests/instead-of-clarEdward Thomson2021-10-288-20/+20
|\ | | | | libgit2_clar is now libgit2_tests
| * libgit2_clar is now libgit2_testsMartin Kühl2021-10-288-20/+20
|/ | | | | | in #6083 the test runner was renamed to libgit2_tests, but not all references to the old name were updated. this change changes all of them to use the new name.
* Merge pull request #6084 from libgit2/ethomson/cmakeEdward Thomson2021-10-1812-737/+704
|\ | | | | cmake: cleanups and consistency
| * cmake: stylistic refactoringEdward Thomson2021-10-189-691/+704
| | | | | | | | | | Ensure that we always use lowercase function names, and that we do not have spaces preceding open parentheses, for consistency.
| * cmake: remove unused STDCALL optionEdward Thomson2021-10-181-4/+0
| | | | | | | | | | The `STDCALL` option was removed; remove the (unreachable) error message.
| * trace: always enabledEdward Thomson2021-10-185-38/+0
| | | | | | | | There's no need to make tracing opt-in; it should always be included.
| * cmake: allow USE_ICONV on any UnixEdward Thomson2021-10-181-2/+0
| |
| * cmake: allow ENABLE_REPRODUCIBLE_BUILDS on macOSEdward Thomson2021-10-181-2/+0
|/ | | | | macOS may support ENABLE_REPRODUCIBLE_BUILDS, allow users to opt-in to it. (Especially since ENABLE_REPRODUCIBLE_BUILDS is not the default.)
* Merge pull request #6083 from libgit2/ethomson/clar_no_moreEdward Thomson2021-10-176-19/+19
|\
| * cmake: BUILD_CLAR is now BUILD_TESTSethomson/clar_no_moreEdward Thomson2021-10-176-19/+19
|/ | | | | Nobody knows what CLAR is. The test building option should be `BUILD_TESTS`.
* Merge pull request #6078 from libgit2/ethomson/gitstrEdward Thomson2021-10-17347-6308/+6822
|\ | | | | `git_buf`: now a public-only API (`git_str` is our internal API)
| * str: introduce `git_str` for internal, `git_buf` is externalethomson/gitstrEdward Thomson2021-10-17346-6308/+6759
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | libgit2 has two distinct requirements that were previously solved by `git_buf`. We require: 1. A general purpose string class that provides a number of utility APIs for manipulating data (eg, concatenating, truncating, etc). 2. A structure that we can use to return strings to callers that they can take ownership of. By using a single class (`git_buf`) for both of these purposes, we have confused the API to the point that refactorings are difficult and reasoning about correctness is also difficult. Move the utility class `git_buf` to be called `git_str`: this represents its general purpose, as an internal string buffer class. The name also is an homage to Junio Hamano ("gitstr"). The public API remains `git_buf`, and has a much smaller footprint. It is generally only used as an "out" param with strict requirements that follow the documentation. (Exceptions exist for some legacy APIs to avoid breaking callers unnecessarily.) Utility functions exist to convert a user-specified `git_buf` to a `git_str` so that we can call internal functions, then converting it back again.
| * docs: document `git_buf`Edward Thomson2021-10-171-0/+63
|/ | | | | | | | | | | | | | | We have been inconsistent about the way that we handle `git_buf`s provided by users. _Usually_ we require that it has been properly initialized with `GIT_BUF_INIT`, but _sometimes_ we simply overwrite the data in it regardless. And even more rarely, we will grow a user-provided buffer and concatenate data onto it (see `git_diff_format_email`). Document the path forward for `git_buf`, which is that we always require that the buffer is intitialized with `GIT_BUF_INIT`. `git_diff_format_email` will be kept backward compatible but users are encouraged to switch to the new `git_email` APIs.
* Merge pull request #6082 from libgit2/ethomson/oidEdward Thomson2021-10-1728-114/+143
|\ | | | | hash: separate hashes and git_oid
| * fuzzers: use updated hash functionsethomson/oidEdward Thomson2021-10-022-6/+12
| |
| * futils: use a particular hash not a git_oidEdward Thomson2021-10-022-7/+13
| | | | | | | | | | | | In `git_futils_readbuffer_updated`, always take a particular hash instead of a `git_oid`. This lets us change the checksum algorithm independently of `git_oid` usage.
| * hash: hash functions operate on byte arrays not git_oidsEdward Thomson2021-10-0224-51/+52
| | | | | | | | | | | | Separate the concerns of the hash functions from the git_oid functions. The git_oid structure will need to understand either SHA1 or SHA256; the hash functions should only deal with the appropriate one of these.
| * hash: accept the algorithm in inputsEdward Thomson2021-10-0118-57/+73
| |
| * hash: don't abbreviate algorithmEdward Thomson2021-10-012-13/+13
| |
* | Merge pull request #6092 from libgit2/ethomson/diff_rename_limitEdward Thomson2021-10-132-2/+2
|\ \ | |/ |/|
View Lorry Controller Status