| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 969d4b703c910a8fd045baafbcd243b4c9825316.
This was a fluke from Coverity. The length to all the APIs in the
library is supposed to be passed in as nibbles, not bytes. Passing it as
bytes would prevent us from parsing uneven-sized SHA1 strings.
Also, the rest of the library was still using nibbles (including
revparse and the odb_prefix APIs), so this change was seriously breaking
things in unexpected ways. ^^
|
| |\ \
| | |
| | | |
pc: Put libcurl and libssh2 in Libs.private
|
| |/ /
| |
| |
| |
| |
| |
| |
| | |
Pass on to whoever wants to link to libgit2 statically the flags that we
would have used for these libraries.
Putting them in Requires.private as we do now makes pkg-config put their
dependencies in the linker arguments as well, which is not what we want.
|
| |\ \
| | |
| | | |
Dont update index unnecessarily
|
| | | |
| | |
| | |
| | |
| | |
| | | |
When diffing the index with the workdir and GIT_DIFF_UPDATE_INDEX has been passed,
the previous implementation was always writing the index to disk even if it wasn't
modified.
|
| |/ /
| |
| |
| |
| | |
Test that workdir diffs, when presented with UPDATE_INDEX, only
write the index when they actually make a change.
|
| |\ \
| | |
| | | |
Rename FALLBACK to UNSPECIFIED
|
| | | |
| | |
| | |
| | |
| | | |
Fallback describes the mechanism, while unspecified explains what the
user is thinking.
|
| |\ \ \
| |_|/
|/| | |
List `libcurl` in the generated `libgit2.pc`
|
| |/ / |
|
| |\ \
| | |
| | | |
remote: insert refspecs with no rhs in FETCH_HEAD
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When a refspec contains no rhs and thus won't cause an explicit update,
we skip all the logic, but that means that we don't update FETCH_HEAD
with it, which is what the implicit rhs is.
Add another bit of logic which puts those remote heads in the list of
updates so we put them into FETCH_HEAD.
|
| |\ \ \
| |_|/
|/| | |
Don't allow growing borrowed buffers
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
This explains more closely what happens. While here, set an error
message.
|
| | | |
| | |
| | |
| | |
| | | |
We've been using EINVALIDSPEC for a while to mean this, but that name
is too specific. Introduce this to be more explicit.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We currently recommend using `git_buf_grow` in order to make a buffer
make an owned copy of the memory it points to. This is not behaviour we
should encourage, so remove this recommendation.
The function itself is not changed, as we need to remain compatible, but
it will be changed not to allow usage on borrowed buffers.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When we don't own a buffer (asize=0) we currently allow the usage of
grow to copy the memory into a buffer we do own. This muddles the
meaning of grow, and lets us be a bit cavalier with ownership semantics.
Don't allow this any more. Usage of grow should be restricted to buffers
which we know own their own memory. If unsure, we must not attempt to
modify it.
|
| |\ \ \
| | | |
| | | | |
Remove run-time configuration settings from submodules
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
These are not useful anymore, as we don't affect the instance's
configuration.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In addition to mapping enums to strings in the configuration, we need to
know to delete the configuration option when given the "none" or "no"
option.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We currently do not handle those enum values which require us to set
"true" or unset variables in all cases. Use a common function which does
understand this by looking at our mapping directly.
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The current code will always fail, but only because it's asking for a
string on a live config. Take a snapshot and make sure we fail with
ENOTFOUND instead of any old error.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
We no longer have any setters which affect an instance, so
`git_submodule_save()` is no longer relevant.
|
| | | | |
| | | |
| | | |
| | | | |
With this one, we can get rid of the edit_and_save test.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Similarly to the other ones. In this test we copy over testing
`RECURSE_YES` which shows an error in our handling of the `YES` variant
which we may have to port to the rest.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Moving on with the removal of runtime-changing variables, the update
setting for a remote is whatever it was when it was looked up.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
During the cache deletion, the check for whether we consider a submodule
to exist got changed regarding submodules which are in the worktree but
not configured.
Instead of checking for the url field to be populated, check the
location where we've found it.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
During the removal of the cache, we also removed the ability to use
`_lookup()` to search by path rather than name. Bring this logic back.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This lets us specify in the status call which ignore rules we want to
use (optionally falling back to whatever the submodule has in its
configuration).
This removes one of the reasons for having `_set_ignore()` set the value
in-memory. We re-use the `IGNORE_RESET` value for this as it is no
longer relevant but has a similar purpose to `IGNORE_FALLBACK`.
Similarly, we remove `IGNORE_DEFAULT` which does not have use outside of
initializers and move that to fall back to the configuration as well.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
As submodules are becomes more like values, we should not let a status
check to update its properties. Instead of taking a submodule, have
status take a repo and submodule name.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Instead of affecting a particular instance, make it change the
configuration.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Having this cache and giving them out goes against our multithreading
guarantees and it makes it impossible to use submodules in a
multi-threaded environment, as any thread can ask for a refresh which
may reallocate some string in the submodule struct which we've accessed
in a different one via a getter.
This makes the submodules behave more like remotes, where each object is
created upon request and not shared except explicitly by the user. This
means that some tests won't pass yet, as they assume they can affect the
submodule objects in the cache and that will affect later operations.
|
| |\ \ \ \
| | | | |
| | | | | |
Implement a cURL stream
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If the libcurl stream is available, use that as the underlying stream
instead of the socket stream. This allows us to set a proxy for HTTPS
connections.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We do not want libcurl to perform the TLS negotiation for us, so we
don't need to pass this option.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The TLS streams talk over the curl stream themselves, so we don't need
to ask for it explicitly. Do so in the case of the non-encrypted one so
we can still make use proxies in that case.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When linking against libcurl, use it as the underlying transport instead
of straight sockets. We can't quite just give over the file descriptor,
as curl puts it into non-blocking mode, so we build a custom BIO so
OpenSSL sends the data through our stream, be it the socket or curl
streams.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The information is exposed by curl for some crypto libraries in the form
of name:content strings. We can't do much more than return this
information.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Of the built-in ones, only cURL support it, but there's no reason a
user-provided stream wouldn't support it.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If the stream claims to support this feature, we can let the transport
set the proxy.
We also set HTTPPROXYTUNNEL option so curl can create a tunnel through
the proxy which lets us create our own TLS session (if needed).
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
cURL has a mode in which it acts a lot like our streams, providing send
and recv functions and taking care of the TLS and proxy setup for us.
Implement a new stream which uses libcurl instead of raw sockets or the
TLS libraries directly. This version does not support reporting
certificates or proxies yet.
|
| | | |/ /
| |/| | |
|
| |\ \ \ \
| | | | |
| | | | | |
Handle binary DIFFABLEness properly
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Always set `GIT_DIFF_PATCH_DIFFABLE` for all files, regardless of
binary-ness, so that the binary callback is invoked to either
show the binary contents, or just print the standard "Binary files
differ" message. We may need to do deeper inspection for binary
files where we have avoided loading the contents into a file map.
|
