diff options
| author | Russell Belfer <rb@github.com> | 2014-05-08 10:17:14 -0700 |
|---|---|---|
| committer | Russell Belfer <rb@github.com> | 2014-05-08 10:17:14 -0700 |
| commit | 1e4976cb015bd10a2a8c377e02801306473afc26 (patch) | |
| tree | 73cde51de2a436cdffa825b155c6888df41671bd /src/submodule.c | |
| parent | ed476c236b8328c31acb150ee69eaf00c821b9e3 (diff) | |
| download | libgit2-rb/fix-2333.tar.gz | |
Be more careful with user-supplied buffersrb/fix-2333
This adds in missing calls to `git_buf_sanitize` and fixes a
number of places where `git_buf` APIs could inadvertently write
NUL terminator bytes into invalid buffers. This also changes the
behavior of `git_buf_sanitize` to NUL terminate a buffer if it can
and of `git_buf_shorten` to do nothing if it can.
Adds tests of filtering code with zeroed (i.e. unsanitized) buffer
which was previously triggering a segfault.
Diffstat (limited to 'src/submodule.c')
| -rw-r--r-- | src/submodule.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/submodule.c b/src/submodule.c index 5ddbfe828..b1291df8e 100644 --- a/src/submodule.c +++ b/src/submodule.c @@ -641,7 +641,9 @@ int git_submodule_resolve_url(git_buf *out, git_repository *repo, const char *ur { int error = 0; - assert(url); + assert(out && repo && url); + + git_buf_sanitize(out); if (git_path_is_relative(url)) { if (!(error = get_url_base(out, repo))) |