Add range checking around cache opts

Add a git_cache_set_max_object_size method that does more checking
around setting the max object size.  Also add a git_cache_size to
read the number of objects currently in the cache.  This makes it
easier to write tests.

1 files changed, 17 insertions, 6 deletions

diff --git a/src/cache.c b/src/cache.c
index f8cddeaca..263f736fa 100644
--- a/src/cache.c
+++ b/src/cache.c
@@ -19,17 +19,28 @@ GIT__USE_OIDMAP
 
 bool git_cache__enabled = true;
 
-size_t git_cache__max_object_size[8] = {
-	0, /* GIT_OBJ__EXT1 */
+static size_t git_cache__max_object_size[8] = {
+	0,     /* GIT_OBJ__EXT1 */
 	4096,  /* GIT_OBJ_COMMIT */
 	4096,  /* GIT_OBJ_TREE */
-	0, /* GIT_OBJ_BLOB */
+	0,     /* GIT_OBJ_BLOB */
 	4096,  /* GIT_OBJ_TAG */
-	0, /* GIT_OBJ__EXT2 */
-	0, /* GIT_OBJ_OFS_DELTA */
-	0 /* GIT_OBJ_REF_DELTA */
+	0,     /* GIT_OBJ__EXT2 */
+	0,     /* GIT_OBJ_OFS_DELTA */
+	0      /* GIT_OBJ_REF_DELTA */
 };
 
+int git_cache_set_max_object_size(git_otype type, size_t size)
+{
+	if (type < 0 || (size_t)type >= ARRAY_SIZE(git_cache__max_object_size)) {
+		giterr_set(GITERR_INVALID, "type out of range");
+		return -1;
+	}
+
+	git_cache__max_object_size[type] = size;
+	return 0;
+}
+
 void git_cache_dump_stats(git_cache *cache)
 {
 	git_cached_obj *object;