diff options
| author | lhchavez <lhchavez@lhchavez.com> | 2022-06-11 14:29:15 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-11 14:29:15 -0700 |
| commit | a75416761c28326262b8c48ebc81f34702fa33b1 (patch) | |
| tree | a620aa7f4329a983de91c19e36524ba7bf8c1000 | |
| parent | 1d88605ca9d51f9e8695030853d5914743fbb091 (diff) | |
| download | libgit2-a75416761c28326262b8c48ebc81f34702fa33b1.tar.gz | |
Apply suggestions from code review
Co-authored-by: Edward Thomson <ethomson@github.com>
| -rw-r--r-- | include/git2/sys/remote.h | 2 | ||||
| -rw-r--r-- | include/git2/sys/transport.h | 2 | ||||
| -rw-r--r-- | src/libgit2/transports/smart.c | 2 | ||||
| -rw-r--r-- | tests/libgit2/transport/register.c | 2 |
4 files changed, 5 insertions, 3 deletions
diff --git a/include/git2/sys/remote.h b/include/git2/sys/remote.h index bde1b168c..0eae9234d 100644 --- a/include/git2/sys/remote.h +++ b/include/git2/sys/remote.h @@ -30,6 +30,8 @@ typedef enum { /** * Disposes libgit2-initialized fields from a git_remote_connect_options. + * This should only be used for git_remote_connect_options returned by + * git_transport_remote_connect_options. * * Note that this does not free the `git_remote_connect_options` itself, just * the memory pointed to by it. diff --git a/include/git2/sys/transport.h b/include/git2/sys/transport.h index 8191f1557..af315e369 100644 --- a/include/git2/sys/transport.h +++ b/include/git2/sys/transport.h @@ -280,7 +280,7 @@ GIT_EXTERN(int) git_transport_smart_proxy_options(git_proxy_options *out, git_tr * @param out options struct to fill * @param transport the transport to extract the data from. */ -GIT_EXTERN(int) git_transport_smart_remote_connect_options( +GIT_EXTERN(int) git_transport_remote_connect_options( git_remote_connect_options *out, git_transport *transport); diff --git a/src/libgit2/transports/smart.c b/src/libgit2/transports/smart.c index 264f21341..7f57dba2a 100644 --- a/src/libgit2/transports/smart.c +++ b/src/libgit2/transports/smart.c @@ -425,7 +425,7 @@ int git_transport_smart_credentials(git_credential **out, git_transport *transpo return connect_opts->callbacks.credentials(out, t->url, user, methods, connect_opts->callbacks.payload); } -int git_transport_smart_remote_connect_options( +int git_transport_remote_connect_options( git_remote_connect_options *out, git_transport *transport) { diff --git a/tests/libgit2/transport/register.c b/tests/libgit2/transport/register.c index 216f11e82..4d3c09726 100644 --- a/tests/libgit2/transport/register.c +++ b/tests/libgit2/transport/register.c @@ -134,7 +134,7 @@ static int custom_subtransport__action( GIT_UNUSED(url); GIT_UNUSED(action); - ret = git_transport_smart_remote_connect_options(&opts, t->owner); + ret = git_transport_remote_connect_options(&opts, t->owner); /* increase the counter once if this function was called at all and once more if the URL matches. */ (*t->called)++; |