diff options
| author | Victor Garcia <victor@tuenti.com> | 2013-11-07 16:22:49 +0100 |
|---|---|---|
| committer | Victor Garcia <victor@tuenti.com> | 2013-11-07 16:22:49 +0100 |
| commit | 99feb98897fa1daa0ff3fd70b17ccc9d9a51f1d0 (patch) | |
| tree | a0993987627260ff9f81762ebb98b89ee82a9128 | |
| parent | 0fe522d1057aef064084a22d116f7c225948a3bd (diff) | |
| download | libgit2-99feb98897fa1daa0ff3fd70b17ccc9d9a51f1d0.tar.gz | |
adding doc for new param and test to check fetch spec is correctly added
| -rw-r--r-- | include/git2/remote.h | 4 | ||||
| -rw-r--r-- | tests-clar/network/remote/remotes.c | 12 |
2 files changed, 14 insertions, 2 deletions
diff --git a/include/git2/remote.h b/include/git2/remote.h index 07102594e..f5e6f5aeb 100644 --- a/include/git2/remote.h +++ b/include/git2/remote.h @@ -27,13 +27,15 @@ GIT_BEGIN_DECL typedef int (*git_remote_rename_problem_cb)(const char *problematic_refspec, void *payload); /** - * Add a remote with the default fetch refspec to the repository's configuration. This + * Add a remote with the provided fetch refspec (or default if NULL) to the repository's + * configuration. This * calls git_remote_save before returning. * * @param out the resulting remote * @param repo the repository in which to create the remote * @param name the remote's name * @param url the remote's url + * @param fetch the remote fetch value * @return 0, GIT_EINVALIDSPEC, GIT_EEXISTS or an error code */ GIT_EXTERN(int) git_remote_create( diff --git a/tests-clar/network/remote/remotes.c b/tests-clar/network/remote/remotes.c index 3b7ce2924..210790d4f 100644 --- a/tests-clar/network/remote/remotes.c +++ b/tests-clar/network/remote/remotes.c @@ -450,7 +450,6 @@ void test_network_remote_remotes__cannot_create_a_remote_which_name_conflicts_wi assert_cannot_create_remote("test", GIT_EEXISTS); } - void test_network_remote_remotes__cannot_create_a_remote_which_name_is_invalid(void) { assert_cannot_create_remote("/", GIT_EINVALIDSPEC); @@ -459,6 +458,17 @@ void test_network_remote_remotes__cannot_create_a_remote_which_name_is_invalid(v assert_cannot_create_remote("a.lock", GIT_EINVALIDSPEC); } +void test_network_remote_remotes__create_a_remote_with_custom_fetch_spec(void) +{ + git_remote *remote; + git_strarray array; + + cl_git_pass(git_remote_create(&remote, _repo, "test-new", "git://github.com/libgit2/libgit2", "+refs/*:refs/*")); + git_remote_get_fetch_refspecs(&array, remote); + cl_assert_equal_s("+refs/*:refs/*", array.strings[0]); + git_remote_free(remote); +} + static const char *fetch_refspecs[] = { "+refs/heads/*:refs/remotes/origin/*", "refs/tags/*:refs/tags/*", |