diff options
| author | Edward Thomson <ethomson@edwardthomson.com> | 2019-12-14 06:58:52 +1030 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-12-14 06:58:52 +1030 |
| commit | e1d7747f23a3b2c09976c00685a754563ad6225e (patch) | |
| tree | 9522929e1bb2c09616a6013dc9232b36e75f5e7d | |
| parent | 2f6f10bb804becddfae78bb9682183ae8ae8184d (diff) | |
| parent | 868526138e131601c69f0949c58976700501881f (diff) | |
| download | libgit2-e1d7747f23a3b2c09976c00685a754563ad6225e.tar.gz | |
Merge pull request #5337 from pks-t/pks/smart-pkt-ok-overflow
smart_pkt: fix overflow resulting in OOB read/write of one byte
| -rw-r--r-- | src/transports/smart_pkt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/transports/smart_pkt.c b/src/transports/smart_pkt.c index 9bc273e0c..56b680d28 100644 --- a/src/transports/smart_pkt.c +++ b/src/transports/smart_pkt.c @@ -273,7 +273,7 @@ static int ok_pkt(git_pkt **out, const char *line, size_t len) line += 3; len -= 3; - if (line[len - 1] == '\n') + if (len && line[len - 1] == '\n') --len; GIT_ERROR_CHECK_ALLOC_ADD(&alloc_len, len, 1); |