diff options
| author | Sven Strickroth <email@cs-ware.de> | 2020-09-08 13:03:07 +0200 |
|---|---|---|
| committer | Sven Strickroth <email@cs-ware.de> | 2020-09-08 13:03:07 +0200 |
| commit | 2dea3eb41a8e75eea464b3d1bcdffcf0530f4cbc (patch) | |
| tree | d260a86e14dc2879fa91a70b22f75a275e48ff6f | |
| parent | f29e6ddec179726d0879c9b4a86a87f897766833 (diff) | |
| download | libgit2-2dea3eb41a8e75eea464b3d1bcdffcf0530f4cbc.tar.gz | |
Don't fail if a HTTP server announces he supports a protocol upgrade
cf. RFC7230 section 6.7, an Upgrade header in a normal response merely informs the client that the server supports upgrading to other protocols, and the client can ask for such an upgrade in a later request. The server requiring an upgrade is via the 426 Upgrade Required response code, not the mere presence of the Upgrade response header.
(closes issue #5573)
Signed-off-by: Sven Strickroth <email@cs-ware.de>
| -rw-r--r-- | src/transports/httpclient.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/transports/httpclient.c b/src/transports/httpclient.c index dda267833..3c940c930 100644 --- a/src/transports/httpclient.c +++ b/src/transports/httpclient.c @@ -1120,11 +1120,6 @@ GIT_INLINE(int) client_read_and_parse(git_http_client *client) return -1; } - if (parser->upgrade) { - git_error_set(GIT_ERROR_HTTP, "server requested upgrade"); - return -1; - } - if (ctx->parse_status == PARSE_STATUS_ERROR) { client->connected = 0; return ctx->error ? ctx->error : -1; |