diff options
| author | Carlos Martín Nieto <cmn@dwim.me> | 2015-06-24 19:32:56 +0200 |
|---|---|---|
| committer | Carlos Martín Nieto <cmn@dwim.me> | 2015-06-24 23:49:10 +0200 |
| commit | a65992355dac71490f4b22b3f2c0d55a1beca01b (patch) | |
| tree | dfdc39361e6007cfa89e4d7ff464d958d8ddbbe1 | |
| parent | 189aad45af733316ddecb01e750daed5f792fa07 (diff) | |
| download | libgit2-a65992355dac71490f4b22b3f2c0d55a1beca01b.tar.gz | |
buffer: make use of EINVALID for growing a borrowed buffer
This explains more closely what happens. While here, set an error
message.
| -rw-r--r-- | src/buffer.c | 6 | ||||
| -rw-r--r-- | tests/core/buffer.c | 2 |
2 files changed, 5 insertions, 3 deletions
diff --git a/src/buffer.c b/src/buffer.c index c066d8e84..1a5809cca 100644 --- a/src/buffer.c +++ b/src/buffer.c @@ -41,8 +41,10 @@ int git_buf_try_grow( if (buf->ptr == git_buf__oom) return -1; - if (buf->asize == 0 && buf->size != 0) - return GIT_EINVALIDSPEC; + if (buf->asize == 0 && buf->size != 0) { + giterr_set(GITERR_INVALID, "cannot grow a borrowed buffer"); + return GIT_EINVALID; + } if (!target_size) target_size = buf->size; diff --git a/tests/core/buffer.c b/tests/core/buffer.c index cc2d7bbcc..0e7026a9c 100644 --- a/tests/core/buffer.c +++ b/tests/core/buffer.c @@ -1164,5 +1164,5 @@ void test_core_buffer__dont_grow_borrowed(void) cl_assert_equal_i(0, buf.asize); cl_assert_equal_i(strlen(somestring) + 1, buf.size); - cl_git_fail_with(GIT_EINVALIDSPEC, git_buf_grow(&buf, 1024)); + cl_git_fail_with(GIT_EINVALID, git_buf_grow(&buf, 1024)); } |