[core] Mark most getter functions as pure

Add G_GNUC_PURE to all applicable getter functions, which should allow gcc to
optimise calls to libgdata in some cases. This required a little rewrite of
the authentication system to ensure the username and password (etc.) are only
changed on the #GDataService from the main thread.

7 files changed, 24 insertions, 24 deletions

diff --git a/gdata/gcontact/gdata-gcontact-calendar.h b/gdata/gcontact/gdata-gcontact-calendar.h
index 7eb37775..ac7caaa2 100644
--- a/gdata/gcontact/gdata-gcontact-calendar.h
+++ b/gdata/gcontact/gdata-gcontact-calendar.h
@@ -100,18 +100,18 @@ GType gdata_gcontact_calendar_get_type (void) G_GNUC_CONST;
 
 GDataGContactCalendar *gdata_gcontact_calendar_new (const gchar *uri, const gchar *relation_type,
                                                     const gchar *label, gboolean is_primary) G_GNUC_WARN_UNUSED_RESULT G_GNUC_MALLOC;
-gint gdata_gcontact_calendar_compare (const GDataGContactCalendar *a, const GDataGContactCalendar *b);
+gint gdata_gcontact_calendar_compare (const GDataGContactCalendar *a, const GDataGContactCalendar *b) G_GNUC_PURE;
 
-const gchar *gdata_gcontact_calendar_get_uri (GDataGContactCalendar *self);
+const gchar *gdata_gcontact_calendar_get_uri (GDataGContactCalendar *self) G_GNUC_PURE;
 void gdata_gcontact_calendar_set_uri (GDataGContactCalendar *self, const gchar *uri);
 
-const gchar *gdata_gcontact_calendar_get_relation_type (GDataGContactCalendar *self);
+const gchar *gdata_gcontact_calendar_get_relation_type (GDataGContactCalendar *self) G_GNUC_PURE;
 void gdata_gcontact_calendar_set_relation_type (GDataGContactCalendar *self, const gchar *relation_type);
 
-const gchar *gdata_gcontact_calendar_get_label (GDataGContactCalendar *self);
+const gchar *gdata_gcontact_calendar_get_label (GDataGContactCalendar *self) G_GNUC_PURE;
 void gdata_gcontact_calendar_set_label (GDataGContactCalendar *self, const gchar *label);
 
-gboolean gdata_gcontact_calendar_is_primary (GDataGContactCalendar *self);
+gboolean gdata_gcontact_calendar_is_primary (GDataGContactCalendar *self) G_GNUC_PURE;
 void gdata_gcontact_calendar_set_is_primary (GDataGContactCalendar *self, gboolean is_primary);
 
 G_END_DECLS
diff --git a/gdata/gcontact/gdata-gcontact-event.h b/gdata/gcontact/gdata-gcontact-event.h
index bbe0a997..c8063b67 100644
--- a/gdata/gcontact/gdata-gcontact-event.h
+++ b/gdata/gcontact/gdata-gcontact-event.h
@@ -92,10 +92,10 @@ GDataGContactEvent *gdata_gcontact_event_new (const GDate *date, const gchar *re
 void gdata_gcontact_event_get_date (GDataGContactEvent *self, GDate *date);
 void gdata_gcontact_event_set_date (GDataGContactEvent *self, const GDate *date);
 
-const gchar *gdata_gcontact_event_get_relation_type (GDataGContactEvent *self);
+const gchar *gdata_gcontact_event_get_relation_type (GDataGContactEvent *self) G_GNUC_PURE;
 void gdata_gcontact_event_set_relation_type (GDataGContactEvent *self, const gchar *relation_type);
 
-const gchar *gdata_gcontact_event_get_label (GDataGContactEvent *self);
+const gchar *gdata_gcontact_event_get_label (GDataGContactEvent *self) G_GNUC_PURE;
 void gdata_gcontact_event_set_label (GDataGContactEvent *self, const gchar *label);
 
 G_END_DECLS
diff --git a/gdata/gcontact/gdata-gcontact-external-id.h b/gdata/gcontact/gdata-gcontact-external-id.h
index 2da8bfca..7146f47a 100644
--- a/gdata/gcontact/gdata-gcontact-external-id.h
+++ b/gdata/gcontact/gdata-gcontact-external-id.h
@@ -112,15 +112,15 @@ GType gdata_gcontact_external_id_get_type (void) G_GNUC_CONST;
 
 GDataGContactExternalID *gdata_gcontact_external_id_new (const gchar *value, const gchar *relation_type,
                                                          const gchar *label) G_GNUC_WARN_UNUSED_RESULT G_GNUC_MALLOC;
-gint gdata_gcontact_external_id_compare (const GDataGContactExternalID *a, const GDataGContactExternalID *b);
+gint gdata_gcontact_external_id_compare (const GDataGContactExternalID *a, const GDataGContactExternalID *b) G_GNUC_PURE;
 
-const gchar *gdata_gcontact_external_id_get_value (GDataGContactExternalID *self);
+const gchar *gdata_gcontact_external_id_get_value (GDataGContactExternalID *self) G_GNUC_PURE;
 void gdata_gcontact_external_id_set_value (GDataGContactExternalID *self, const gchar *value);
 
-const gchar *gdata_gcontact_external_id_get_relation_type (GDataGContactExternalID *self);
+const gchar *gdata_gcontact_external_id_get_relation_type (GDataGContactExternalID *self) G_GNUC_PURE;
 void gdata_gcontact_external_id_set_relation_type (GDataGContactExternalID *self, const gchar *relation_type);
 
-const gchar *gdata_gcontact_external_id_get_label (GDataGContactExternalID *self);
+const gchar *gdata_gcontact_external_id_get_label (GDataGContactExternalID *self) G_GNUC_PURE;
 void gdata_gcontact_external_id_set_label (GDataGContactExternalID *self, const gchar *label);
 
 G_END_DECLS
diff --git a/gdata/gcontact/gdata-gcontact-jot.h b/gdata/gcontact/gdata-gcontact-jot.h
index 2eb89889..908ee864 100644
--- a/gdata/gcontact/gdata-gcontact-jot.h
+++ b/gdata/gcontact/gdata-gcontact-jot.h
@@ -124,10 +124,10 @@ GType gdata_gcontact_jot_get_type (void) G_GNUC_CONST;
 
 GDataGContactJot *gdata_gcontact_jot_new (const gchar *content, const gchar *relation_type) G_GNUC_WARN_UNUSED_RESULT G_GNUC_MALLOC;
 
-const gchar *gdata_gcontact_jot_get_content (GDataGContactJot *self);
+const gchar *gdata_gcontact_jot_get_content (GDataGContactJot *self) G_GNUC_PURE;
 void gdata_gcontact_jot_set_content (GDataGContactJot *self, const gchar *content);
 
-const gchar *gdata_gcontact_jot_get_relation_type (GDataGContactJot *self);
+const gchar *gdata_gcontact_jot_get_relation_type (GDataGContactJot *self) G_GNUC_PURE;
 void gdata_gcontact_jot_set_relation_type (GDataGContactJot *self, const gchar *relation_type);
 
 G_END_DECLS
diff --git a/gdata/gcontact/gdata-gcontact-language.h b/gdata/gcontact/gdata-gcontact-language.h
index af2e0ff5..9995f52f 100644
--- a/gdata/gcontact/gdata-gcontact-language.h
+++ b/gdata/gcontact/gdata-gcontact-language.h
@@ -63,12 +63,12 @@ typedef struct {
 GType gdata_gcontact_language_get_type (void) G_GNUC_CONST;
 
 GDataGContactLanguage *gdata_gcontact_language_new (const gchar *code, const gchar *label) G_GNUC_WARN_UNUSED_RESULT G_GNUC_MALLOC;
-gint gdata_gcontact_language_compare (const GDataGContactLanguage *a, const GDataGContactLanguage *b);
+gint gdata_gcontact_language_compare (const GDataGContactLanguage *a, const GDataGContactLanguage *b) G_GNUC_PURE;
 
-const gchar *gdata_gcontact_language_get_code (GDataGContactLanguage *self);
+const gchar *gdata_gcontact_language_get_code (GDataGContactLanguage *self) G_GNUC_PURE;
 void gdata_gcontact_language_set_code (GDataGContactLanguage *self, const gchar *code);
 
-const gchar *gdata_gcontact_language_get_label (GDataGContactLanguage *self);
+const gchar *gdata_gcontact_language_get_label (GDataGContactLanguage *self) G_GNUC_PURE;
 void gdata_gcontact_language_set_label (GDataGContactLanguage *self, const gchar *label);
 
 G_END_DECLS
diff --git a/gdata/gcontact/gdata-gcontact-relation.h b/gdata/gcontact/gdata-gcontact-relation.h
index 73660f88..1c637a3d 100644
--- a/gdata/gcontact/gdata-gcontact-relation.h
+++ b/gdata/gcontact/gdata-gcontact-relation.h
@@ -233,13 +233,13 @@ GType gdata_gcontact_relation_get_type (void) G_GNUC_CONST;
 GDataGContactRelation *gdata_gcontact_relation_new (const gchar *name, const gchar *relation_type,
                                                     const gchar *label) G_GNUC_WARN_UNUSED_RESULT G_GNUC_MALLOC;
 
-const gchar *gdata_gcontact_relation_get_name (GDataGContactRelation *self);
+const gchar *gdata_gcontact_relation_get_name (GDataGContactRelation *self) G_GNUC_PURE;
 void gdata_gcontact_relation_set_name (GDataGContactRelation *self, const gchar *name);
 
-const gchar *gdata_gcontact_relation_get_relation_type (GDataGContactRelation *self);
+const gchar *gdata_gcontact_relation_get_relation_type (GDataGContactRelation *self) G_GNUC_PURE;
 void gdata_gcontact_relation_set_relation_type (GDataGContactRelation *self, const gchar *relation_type);
 
-const gchar *gdata_gcontact_relation_get_label (GDataGContactRelation *self);
+const gchar *gdata_gcontact_relation_get_label (GDataGContactRelation *self) G_GNUC_PURE;
 void gdata_gcontact_relation_set_label (GDataGContactRelation *self, const gchar *label);
 
 G_END_DECLS
diff --git a/gdata/gcontact/gdata-gcontact-website.h b/gdata/gcontact/gdata-gcontact-website.h
index 91bd5857..bfdc2257 100644
--- a/gdata/gcontact/gdata-gcontact-website.h
+++ b/gdata/gcontact/gdata-gcontact-website.h
@@ -148,18 +148,18 @@ GType gdata_gcontact_website_get_type (void) G_GNUC_CONST;
 
 GDataGContactWebsite *gdata_gcontact_website_new (const gchar *uri, const gchar *relation_type,
                                                   const gchar *label, gboolean is_primary) G_GNUC_WARN_UNUSED_RESULT G_GNUC_MALLOC;
-gint gdata_gcontact_website_compare (const GDataGContactWebsite *a, const GDataGContactWebsite *b);
+gint gdata_gcontact_website_compare (const GDataGContactWebsite *a, const GDataGContactWebsite *b) G_GNUC_PURE;
 
-const gchar *gdata_gcontact_website_get_uri (GDataGContactWebsite *self);
+const gchar *gdata_gcontact_website_get_uri (GDataGContactWebsite *self) G_GNUC_PURE;
 void gdata_gcontact_website_set_uri (GDataGContactWebsite *self, const gchar *uri);
 
-const gchar *gdata_gcontact_website_get_relation_type (GDataGContactWebsite *self);
+const gchar *gdata_gcontact_website_get_relation_type (GDataGContactWebsite *self) G_GNUC_PURE;
 void gdata_gcontact_website_set_relation_type (GDataGContactWebsite *self, const gchar *relation_type);
 
-const gchar *gdata_gcontact_website_get_label (GDataGContactWebsite *self);
+const gchar *gdata_gcontact_website_get_label (GDataGContactWebsite *self) G_GNUC_PURE;
 void gdata_gcontact_website_set_label (GDataGContactWebsite *self, const gchar *label);
 
-gboolean gdata_gcontact_website_is_primary (GDataGContactWebsite *self);
+gboolean gdata_gcontact_website_is_primary (GDataGContactWebsite *self) G_GNUC_PURE;
 void gdata_gcontact_website_set_is_primary (GDataGContactWebsite *self, gboolean is_primary);
 
 G_END_DECLS