diff options
| author | Philip Withnall <philip@tecnocode.co.uk> | 2014-08-31 00:06:02 +0100 |
|---|---|---|
| committer | Philip Withnall <philip@tecnocode.co.uk> | 2014-09-15 18:42:52 +0100 |
| commit | c83a01a0eb222999574e2344c702e1a36dc1cb5a (patch) | |
| tree | b2e122add366a85d62d648e60f36fae053c58e20 | |
| parent | 28a4fada8a3077ab5ea3062c1d59b48971a51283 (diff) | |
| download | libgdata-c83a01a0eb222999574e2344c702e1a36dc1cb5a.tar.gz | |
tasks: Deprecate the ‘q’ parameter of gdata_tasks_query_new()
It was never a valid parameter, and we really should have caught this
before the API was finalised. Deprecate the parameter and document that
it should only ever have NULL passed to it. Don’t use the parameter
internally.
This is necessary because Google don’t support the ‘q’ parameter for
Tasks queries — there is no way to search within task titles or notes.
| -rw-r--r-- | gdata/services/tasks/gdata-tasks-query.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/gdata/services/tasks/gdata-tasks-query.c b/gdata/services/tasks/gdata-tasks-query.c index 6f7219d7..bbe33d46 100644 --- a/gdata/services/tasks/gdata-tasks-query.c +++ b/gdata/services/tasks/gdata-tasks-query.c @@ -355,7 +355,7 @@ get_query_uri (GDataQuery *self, const gchar *feed_uri, GString *query_uri, gboo * gdata_tasks_query_new: * @q: (allow-none): a query string, or %NULL * - * Creates a new #GDataTasksQuery with its #GDataQuery:q property set to @q. + * Creates a new #GDataTasksQuery. @q is unused and must be set to %NULL. * * Return value: a new #GDataTasksQuery * @@ -364,7 +364,9 @@ get_query_uri (GDataQuery *self, const gchar *feed_uri, GString *query_uri, gboo GDataTasksQuery * gdata_tasks_query_new (const gchar *q) { - return g_object_new (GDATA_TYPE_TASKS_QUERY, "q", q, NULL); + /* Ignore the q parameter, as it's not used in any of the queries and + * will cause errors. */ + return g_object_new (GDATA_TYPE_TASKS_QUERY, NULL); } /** |