summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhilip Withnall <philip@tecnocode.co.uk>2014-05-16 10:00:36 +0100
committerPhilip Withnall <philip@tecnocode.co.uk>2014-05-27 21:55:20 +0100
commit8276acd6bd11a08663fd78a8bcf4a1e06b996778 (patch)
treebe97db31d2e10531b0d2a60054d1ad74d208a904
parente3f2d83f933cc79c352233e015b9690278128601 (diff)
downloadlibgdata-8276acd6bd11a08663fd78a8bcf4a1e06b996778.tar.gz
contacts: Remove a redundant xmlFree() call
It was always called on NULL, and was confusing Coverity. Coverity issue: #59764
-rw-r--r--gdata/services/contacts/gdata-contacts-contact.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/gdata/services/contacts/gdata-contacts-contact.c b/gdata/services/contacts/gdata-contacts-contact.c
index 4ec9e581..cb7c4d11 100644
--- a/gdata/services/contacts/gdata-contacts-contact.c
+++ b/gdata/services/contacts/gdata-contacts-contact.c
@@ -922,7 +922,6 @@ parse_xml (GDataParsable *parsable, xmlDoc *doc, xmlNode *node, gpointer user_da
/* Note that while we require the property to be present, we don't require it to be non-empty. See bgo#648058 */
name = xmlGetProp (node, (xmlChar*) "key");
if (name == NULL) {
- xmlFree (name);
return gdata_parser_error_required_property_missing (node, "key", error);
}