r14736@tombo: nickm | 2007-11-06 00:26:51 -0500

 Backport fix for crash in evdns_resolve_reverse_ipv6().


svn:r477

2 files changed, 3 insertions, 1 deletions

diff --git a/ChangeLog b/ChangeLog
index 1d5d4684..3e98d645 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -4,6 +4,7 @@ Changes since 1.3e:
  o Fix evport implementation: port_disassociate called on unassociated events resulting in bogus errors; more efficient memory management; from Trond Norbye and Prakash Sangappa
  o Build correctly outside of the source tree. (Patch from Kelly Anderson)
  o Fix evhttp.h compilation when TAILQ_ENTRY is not defined.
+ o Fix buffer overrun in evdns_resolve_reverse_ipv6 (backported)
 
 Changes since 1.3d:
  o demote most http warnings to debug messages
diff --git a/evdns.c b/evdns.c
index 597f1093..9714bcd0 100644
--- a/evdns.c
+++ b/evdns.c
@@ -2263,7 +2263,8 @@ int evdns_resolve_reverse(struct in_addr *in, int flags, evdns_callback_type cal
 }
 
 int evdns_resolve_reverse_ipv6(struct in6_addr *in, int flags, evdns_callback_type callback, void *ptr) {
-	char buf[64];
+	/* 32 nybbles, 32 periods, "ip6.arpa", NUL. */
+	char buf[73];
 	char *cp;
 	struct request *req;
 	int i;