Whoops, APR_BADARG is bogus [my doing.] Still return APR_EINVAL since

  we don't know where the id came from, and if it's safe to pass to the
  kernel.


git-svn-id: http://svn.apache.org/repos/asf/apr/apr/trunk@61722 13f79535-47bb-0310-9956-ffa450edef68

1 files changed, 4 insertions, 4 deletions

diff --git a/user/win32/groupinfo.c b/user/win32/groupinfo.c
index b66853e15..6b8b74cff 100644
--- a/user/win32/groupinfo.c
+++ b/user/win32/groupinfo.c
@@ -66,12 +66,12 @@ APR_DECLARE(apr_status_t) apr_get_groupname(char **groupname, apr_gid_t groupid,
     char name[MAX_PATH], domain[MAX_PATH];
     DWORD cbname = sizeof(name), cbdomain = sizeof(domain);
     if (!groupid)
-        return APR_BADARG;
+        return APR_EINVAL;
     if (!LookupAccountSid(NULL, groupid, name, &cbname, domain, &cbdomain, &type))
         return apr_get_os_error();
     if (type != SidTypeGroup && type != SidTypeWellKnownGroup 
                              && type != SidTypeAlias)
-        return APR_BADARG;
+        return APR_EINVAL;
     *groupname = apr_pstrdup(p, name);
     return APR_SUCCESS;
 }
@@ -79,9 +79,9 @@ APR_DECLARE(apr_status_t) apr_get_groupname(char **groupname, apr_gid_t groupid,
 APR_DECLARE(apr_status_t) apr_compare_groups(apr_gid_t left, apr_gid_t right)
 {
     if (!left || !right)
-        return APR_BADARG;
+        return APR_EINVAL;
     if (!IsValidSid(left) || !IsValidSid(right))
-        return APR_BADARG;
+        return APR_EINVAL;
     if (!EqualSid(left, right))
         return APR_EMISMATCH;
     return APR_SUCCESS;