Fix the naming of the apr_threadattr_detach_xxx functions. get and set were

reversed.

This may have broken the Unix threaded mpm's when they started using the
bogus "set" function.  A likely symptom would be failure to stop a threaded
process cleanly.

Note: it appears these functions are essentially no-ops except in Unix.


git-svn-id: http://svn.apache.org/repos/asf/apr/apr/trunk@61495 13f79535-47bb-0310-9956-ffa450edef68

4 files changed, 8 insertions, 8 deletions

diff --git a/threadproc/beos/thread.c b/threadproc/beos/thread.c
index 041319d9c..d0fac8e4e 100644
--- a/threadproc/beos/thread.c
+++ b/threadproc/beos/thread.c
@@ -69,7 +69,7 @@ apr_status_t apr_threadattr_create(apr_threadattr_t **new, apr_pool_t *cont)
     return APR_SUCCESS;
 }
 
-apr_status_t apr_threadattr_detach_get(apr_threadattr_t *attr, apr_int32_t on)
+apr_status_t apr_threadattr_detach_set(apr_threadattr_t *attr, apr_int32_t on)
 {
 	if (on == 1){
 		attr->detached = 1;
@@ -79,7 +79,7 @@ apr_status_t apr_threadattr_detach_get(apr_threadattr_t *attr, apr_int32_t on)
     return APR_SUCCESS;
 }
 
-apr_status_t apr_threadattr_detach_set(apr_threadattr_t *attr)
+apr_status_t apr_threadattr_detach_get(apr_threadattr_t *attr)
 {
 	if (attr->detached == 1){
 		return APR_DETACH;
diff --git a/threadproc/os2/thread.c b/threadproc/os2/thread.c
index aa85f43f1..0f15e6fe3 100644
--- a/threadproc/os2/thread.c
+++ b/threadproc/os2/thread.c
@@ -77,7 +77,7 @@ apr_status_t apr_threadattr_create(apr_threadattr_t **new, apr_pool_t *cont)
 
 
 
-apr_status_t apr_threadattr_detach_get(apr_threadattr_t *attr, apr_int32_t on)
+apr_status_t apr_threadattr_detach_set(apr_threadattr_t *attr, apr_int32_t on)
 {
     attr->attr |= APR_THREADATTR_DETACHED;
     return APR_SUCCESS;
@@ -85,7 +85,7 @@ apr_status_t apr_threadattr_detach_get(apr_threadattr_t *attr, apr_int32_t on)
 
 
 
-apr_status_t apr_threadattr_detach_set(apr_threadattr_t *attr)
+apr_status_t apr_threadattr_detach_get(apr_threadattr_t *attr)
 {
     return (attr->attr & APR_THREADATTR_DETACHED) ? APR_DETACH : APR_NOTDETACH;
 }
diff --git a/threadproc/unix/thread.c b/threadproc/unix/thread.c
index 90f4d0c16..a8bcc3334 100644
--- a/threadproc/unix/thread.c
+++ b/threadproc/unix/thread.c
@@ -82,7 +82,7 @@ apr_status_t apr_threadattr_create(apr_threadattr_t **new, apr_pool_t *cont)
     return stat;
 }
 
-apr_status_t apr_threadattr_detach_get(apr_threadattr_t *attr, apr_int32_t on)
+apr_status_t apr_threadattr_detach_set(apr_threadattr_t *attr, apr_int32_t on)
 {
     apr_status_t stat;
 #ifdef PTHREAD_ATTR_SETDETACHSTATE_ARG2_ADDR
@@ -102,7 +102,7 @@ apr_status_t apr_threadattr_detach_get(apr_threadattr_t *attr, apr_int32_t on)
     }
 }
 
-apr_status_t apr_threadattr_detach_set(apr_threadattr_t *attr)
+apr_status_t apr_threadattr_detach_get(apr_threadattr_t *attr)
 {
     int state;
 
diff --git a/threadproc/win32/thread.c b/threadproc/win32/thread.c
index 624da55fb..047a68a94 100644
--- a/threadproc/win32/thread.c
+++ b/threadproc/win32/thread.c
@@ -75,14 +75,14 @@ APR_DECLARE(apr_status_t) apr_threadattr_create(apr_threadattr_t **new,
     return APR_SUCCESS;
 }
 
-APR_DECLARE(apr_status_t) apr_threadattr_detach_get(apr_threadattr_t *attr,
+APR_DECLARE(apr_status_t) apr_threadattr_detach_set(apr_threadattr_t *attr,
                                                    apr_int32_t on)
 {
     attr->detach = on;
 	return APR_SUCCESS;
 }
 
-APR_DECLARE(apr_status_t) apr_threadattr_detach_set(apr_threadattr_t *attr)
+APR_DECLARE(apr_status_t) apr_threadattr_detach_get(apr_threadattr_t *attr)
 {
     if (attr->detach == 1)
         return APR_DETACH;