This changes apr_sms_create into a more appropriately named

apr_sms_init. It also now returns an apr_status_t which is more
inline with the rest of the code.

I've changed to using calloc for the memory structures rather
than memset in the function, but we may want to change this again.
This patch is a modified version of one submitted by Sander Striker.

Submitted by:	Sander Striker <striker@samba-tng.org>
Reviewed by:	David Reid (applied in a modified form)


git-svn-id: http://svn.apache.org/repos/asf/apr/apr/trunk@61689 13f79535-47bb-0310-9956-ffa450edef68

1 files changed, 6 insertions, 8 deletions

diff --git a/include/apr_sms.h b/include/apr_sms.h
index e29db6ba7..d616264f3 100644
--- a/include/apr_sms.h
+++ b/include/apr_sms.h
@@ -161,20 +161,18 @@ APR_DECLARE(apr_status_t) apr_sms_free(apr_sms_t *mem_sys, void *mem);
  */
 
 /**
- * Create a memory system (actually it initialized a memory system structure)
+ * Initialize a memory system
  * @caution Call this function as soon as you have obtained a block of memory
  *          to serve as a memory system structure from your 
  *          apr_xxx_sms_create. Only use this function when you are
  *          implementing a memory system.
- * @param memory The memory to turn into a memory system
- * @warning The memory passed in should be at least of size 
- *          sizeof(apr_sms_t)
+ * @param mem_sys The memory system created
  * @param parent_mem_sys The parent memory system
- * @return The freshly initialized memory system
- * @deffunc apr_sms_t *apr_sms_create(void *memory,
- *				   apr_sms_t *parent_mem_sys)
+ * @deffunc apr_status_t apr_sms_init(apr_sms_t *sms,
+ *				      apr_sms_t *parent_mem_sys)
  */
-APR_DECLARE(apr_sms_t *) apr_sms_create(void *memory, apr_sms_t *parent_mem_sys);
+APR_DECLARE(apr_status_t) apr_sms_init(apr_sms_t *mem_sys, 
+                                       apr_sms_t *parent_mem_sys);
 
 /**
  * Check if a memory system is obeying all rules.