diff options
author | Stefan Bodewig <bodewig@apache.org> | 2017-04-12 06:54:09 +0200 |
---|---|---|
committer | Stefan Bodewig <bodewig@apache.org> | 2017-04-12 06:54:09 +0200 |
commit | af74d1f6b882cef5f4167d972638ad886d12d58c (patch) | |
tree | 0e101452cf55b87d8e6239dbb5977db54ebdadfd /src/main/org/apache/tools/ant/taskdefs/optional | |
parent | 00d140c1b2ac131485862741145ddfbd68024892 (diff) | |
download | ant-af74d1f6b882cef5f4167d972638ad886d12d58c.tar.gz |
reduce GC pressure by replacing File(In|Out)putStream
Diffstat (limited to 'src/main/org/apache/tools/ant/taskdefs/optional')
32 files changed, 116 insertions, 115 deletions
diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/EchoProperties.java b/src/main/org/apache/tools/ant/taskdefs/optional/EchoProperties.java index 30bcc759c..f6681f8b1 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/EchoProperties.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/EchoProperties.java @@ -19,13 +19,13 @@ package org.apache.tools.ant.taskdefs.optional; import java.io.ByteArrayOutputStream; import java.io.File; -import java.io.FileInputStream; import java.io.FileNotFoundException; -import java.io.FileOutputStream; import java.io.IOException; +import java.io.InputStream; import java.io.OutputStream; import java.io.OutputStreamWriter; import java.io.Writer; +import java.nio.file.Files; import java.util.ArrayList; import java.util.Collections; import java.util.Comparator; @@ -290,9 +290,9 @@ public class EchoProperties extends Task { return; } - FileInputStream in = null; + InputStream in = null; try { - in = new FileInputStream(inFile); + in = Files.newInputStream(inFile.toPath()); Properties props = new Properties(); props.load(in); allProps.putAll(props); @@ -352,7 +352,7 @@ public class EchoProperties extends Task { } return; } - os = new FileOutputStream(this.destfile); + os = Files.newOutputStream(this.destfile.toPath()); saveProperties(allProps, os); } } catch (IOException ioe) { diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/PropertyFile.java b/src/main/org/apache/tools/ant/taskdefs/optional/PropertyFile.java index 9ad9feba1..5a3c215cf 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/PropertyFile.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/PropertyFile.java @@ -21,10 +21,10 @@ package org.apache.tools.ant.taskdefs.optional; import java.io.BufferedInputStream; import java.io.ByteArrayOutputStream; import java.io.File; -import java.io.FileInputStream; -import java.io.FileOutputStream; import java.io.IOException; +import java.io.InputStream; import java.io.OutputStream; +import java.nio.file.Files; import java.text.DateFormat; import java.text.DecimalFormat; import java.text.ParseException; @@ -192,15 +192,15 @@ public class PropertyFile extends Task { if (propertyfile.exists()) { log("Updating property file: " + propertyfile.getAbsolutePath()); - try (FileInputStream fis = new FileInputStream(propertyfile); + try (InputStream fis = Files.newInputStream(propertyfile.toPath()); BufferedInputStream bis = new BufferedInputStream(fis)) { properties.load(bis); } } else { log("Creating new property file: " + propertyfile.getAbsolutePath()); - try (FileOutputStream out = - new FileOutputStream(propertyfile.getAbsolutePath())) { + try (OutputStream out = + Files.newOutputStream(propertyfile.toPath())) { out.flush(); } } @@ -249,7 +249,7 @@ public class PropertyFile extends Task { throw new BuildException(x, getLocation()); } try { - OutputStream os = new FileOutputStream(propertyfile); //NOSONAR + OutputStream os = Files.newOutputStream(propertyfile.toPath()); //NOSONAR try { try { os.write(baos.toByteArray()); diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ReplaceRegExp.java b/src/main/org/apache/tools/ant/taskdefs/optional/ReplaceRegExp.java index 40b7b5d99..f5357bb9d 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/ReplaceRegExp.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/ReplaceRegExp.java @@ -20,8 +20,6 @@ package org.apache.tools.ant.taskdefs.optional; import java.io.BufferedReader; import java.io.BufferedWriter; import java.io.File; -import java.io.FileInputStream; -import java.io.FileOutputStream; import java.io.IOException; import java.io.InputStream; import java.io.InputStreamReader; @@ -29,6 +27,7 @@ import java.io.OutputStream; import java.io.OutputStreamWriter; import java.io.Reader; import java.io.Writer; +import java.nio.file.Files; import org.apache.tools.ant.BuildException; import org.apache.tools.ant.Project; @@ -356,8 +355,8 @@ public class ReplaceRegExp extends Task { try { boolean changes = false; - try (InputStream is = new FileInputStream(f); - OutputStream os = new FileOutputStream(temp)) { + try (InputStream is = Files.newInputStream(f.toPath()); + OutputStream os = Files.newOutputStream(temp.toPath())) { Reader r = null; Writer w = null; try { diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/Rpm.java b/src/main/org/apache/tools/ant/taskdefs/optional/Rpm.java index 765841d60..d1e945cf6 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/Rpm.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/Rpm.java @@ -19,10 +19,10 @@ package org.apache.tools.ant.taskdefs.optional; import java.io.BufferedOutputStream; import java.io.File; -import java.io.FileOutputStream; import java.io.IOException; import java.io.OutputStream; import java.io.PrintStream; +import java.nio.file.Files; import java.util.Map; import org.apache.tools.ant.BuildException; @@ -149,9 +149,9 @@ public class Rpm extends Task { } } else { if (output != null) { - FileOutputStream fos = null; + OutputStream fos = null; try { - fos = new FileOutputStream(output); //NOSONAR + fos = Files.newOutputStream(output.toPath()); //NOSONAR BufferedOutputStream bos = new BufferedOutputStream(fos); outputstream = new PrintStream(bos); } catch (IOException e) { @@ -164,9 +164,9 @@ public class Rpm extends Task { outputstream = new LogOutputStream(this, Project.MSG_DEBUG); } if (error != null) { - FileOutputStream fos = null; + OutputStream fos = null; try { - fos = new FileOutputStream(error); + fos = Files.newOutputStream(error.toPath()); BufferedOutputStream bos = new BufferedOutputStream(fos); errorstream = new PrintStream(bos); } catch (IOException e) { diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java b/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java index f2fcd9a1b..f5a6717fd 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/TraXLiaison.java @@ -21,13 +21,12 @@ package org.apache.tools.ant.taskdefs.optional; import java.io.BufferedInputStream; import java.io.BufferedOutputStream; import java.io.File; -import java.io.FileInputStream; -import java.io.FileOutputStream; import java.io.IOException; import java.io.InputStream; import java.io.OutputStream; import java.lang.reflect.Field; import java.net.URL; +import java.nio.file.Files; import java.util.ArrayList; import java.util.Enumeration; import java.util.HashMap; @@ -191,8 +190,8 @@ public class TraXLiaison implements XSLTLiaison4, ErrorListener, XSLTLoggerAware InputStream fis = null; OutputStream fos = null; try { - fis = new BufferedInputStream(new FileInputStream(infile)); - fos = new BufferedOutputStream(new FileOutputStream(outfile)); + fis = new BufferedInputStream(Files.newInputStream(infile.toPath())); + fos = new BufferedOutputStream(Files.newOutputStream(outfile.toPath())); final StreamResult res = new StreamResult(fos); // not sure what could be the need of this... res.setSystemId(JAXPUtils.getSystemId(outfile)); diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java b/src/main/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java index 26b49a2bf..8a25341a1 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/XMLValidateTask.java @@ -18,8 +18,8 @@ package org.apache.tools.ant.taskdefs.optional; import java.io.File; -import java.io.FileInputStream; import java.io.IOException; +import java.nio.file.Files; import java.util.Vector; import org.apache.tools.ant.AntClassLoader; @@ -550,7 +550,7 @@ public class XMLValidateTask extends Task { try { log("Validating " + afile.getName() + "... ", Project.MSG_VERBOSE); errorHandler.init(afile); - InputSource is = new InputSource(new FileInputStream(afile)); + InputSource is = new InputSource(Files.newInputStream(afile.toPath())); String uri = FILE_UTILS.toURI(afile.getAbsolutePath()); is.setSystemId(uri); xmlReader.parse(is); diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/depend/AntAnalyzer.java b/src/main/org/apache/tools/ant/taskdefs/optional/depend/AntAnalyzer.java index d49095523..8f0a57975 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/depend/AntAnalyzer.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/depend/AntAnalyzer.java @@ -18,9 +18,10 @@ package org.apache.tools.ant.taskdefs.optional.depend; import java.io.File; -import java.io.FileInputStream; import java.io.IOException; import java.io.InputStream; +import java.nio.file.Files; +import java.nio.file.Paths; import java.util.Enumeration; import java.util.Hashtable; import java.util.Vector; @@ -80,7 +81,7 @@ public class AntAnalyzer extends AbstractAnalyzer { InputStream inStream = null; try { if (container.getName().endsWith(".class")) { - inStream = new FileInputStream(container.getPath()); + inStream = Files.newInputStream(Paths.get(container.getPath())); } else { zipFile = new ZipFile(container.getPath()); String entryName diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/depend/DirectoryIterator.java b/src/main/org/apache/tools/ant/taskdefs/optional/depend/DirectoryIterator.java index fbb963efc..4401f1cab 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/depend/DirectoryIterator.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/depend/DirectoryIterator.java @@ -18,8 +18,9 @@ package org.apache.tools.ant.taskdefs.optional.depend; import java.io.File; -import java.io.FileInputStream; import java.io.IOException; +import java.io.InputStream; +import java.nio.file.Files; import java.util.Enumeration; import java.util.Stack; import java.util.Vector; @@ -130,8 +131,8 @@ public class DirectoryIterator implements ClassFileIterator { } else { // we have a file. create a stream for it - try (FileInputStream inFileStream - = new FileInputStream(element)) { + try (InputStream inFileStream + = Files.newInputStream(element.toPath())) { if (element.getName().endsWith(".class")) { // create a data input stream from the jar diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/DescriptorHandler.java b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/DescriptorHandler.java index 158cba937..a987b92db 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/DescriptorHandler.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/DescriptorHandler.java @@ -19,11 +19,10 @@ package org.apache.tools.ant.taskdefs.optional.ejb; import java.io.File; -import java.io.FileInputStream; -import java.io.FileNotFoundException; import java.io.IOException; import java.io.InputStream; import java.net.URL; +import java.nio.file.Files; import java.util.Hashtable; import org.apache.tools.ant.Project; @@ -192,8 +191,8 @@ public class DescriptorHandler extends org.xml.sax.HandlerBase { try { owningTask.log("Resolved " + publicId + " to local file " + dtdFile, Project.MSG_VERBOSE); - return new InputSource(new FileInputStream(dtdFile)); - } catch (FileNotFoundException ex) { + return new InputSource(Files.newInputStream(dtdFile.toPath())); + } catch (IOException ex) { // ignore } } diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/GenericDeploymentTool.java b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/GenericDeploymentTool.java index 43b923705..7de0ba309 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/GenericDeploymentTool.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/GenericDeploymentTool.java @@ -18,10 +18,9 @@ package org.apache.tools.ant.taskdefs.optional.ejb; import java.io.File; -import java.io.FileInputStream; -import java.io.FileOutputStream; import java.io.IOException; import java.io.InputStream; +import java.nio.file.Files; import java.util.Enumeration; import java.util.HashSet; import java.util.Hashtable; @@ -327,10 +326,10 @@ public class GenericDeploymentTool implements EJBDeploymentTool { File inputFile, String logicalFilename) throws BuildException { - FileInputStream iStream = null; + InputStream iStream = null; try { if (!addedfiles.contains(logicalFilename)) { - iStream = new FileInputStream(inputFile); + iStream = Files.newInputStream(inputFile.toPath()); // Create the zip entry and add it to the jar file ZipEntry zipEntry = new ZipEntry(logicalFilename.replace('\\', '/')); jStream.putNextEntry(zipEntry); @@ -514,7 +513,7 @@ public class GenericDeploymentTool implements EJBDeploymentTool { */ protected Hashtable parseEjbFiles(String descriptorFileName, SAXParser saxParser) throws IOException, SAXException { - FileInputStream descriptorStream = null; + InputStream descriptorStream = null; Hashtable ejbFiles = null; try { @@ -524,7 +523,7 @@ public class GenericDeploymentTool implements EJBDeploymentTool { * get hold of all the classfile names for the descriptor. */ descriptorStream - = new FileInputStream(new File(config.descriptorDir, descriptorFileName)); + = Files.newInputStream(new File(config.descriptorDir, descriptorFileName).toPath()); saxParser.parse(new InputSource(descriptorStream), handler); ejbFiles = handler.getFiles(); @@ -776,7 +775,7 @@ public class GenericDeploymentTool implements EJBDeploymentTool { try { File manifestFile = (File) files.get(MANIFEST); if (manifestFile != null && manifestFile.exists()) { - in = new FileInputStream(manifestFile); + in = Files.newInputStream(manifestFile.toPath()); } else { String defaultManifest = "/org/apache/tools/ant/defaultManifest.mf"; in = this.getClass().getResourceAsStream(defaultManifest); @@ -797,7 +796,7 @@ public class GenericDeploymentTool implements EJBDeploymentTool { // Create the streams necessary to write the jarfile - jarStream = new JarOutputStream(new FileOutputStream(jarfile), manifest); + jarStream = new JarOutputStream(Files.newOutputStream(jarfile.toPath()), manifest); jarStream.setMethod(JarOutputStream.DEFLATED); // Loop through all the class files found and add them to the jar diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/IPlanetEjbc.java b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/IPlanetEjbc.java index 76b61ae36..5a6656f4e 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/IPlanetEjbc.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/IPlanetEjbc.java @@ -20,10 +20,11 @@ package org.apache.tools.ant.taskdefs.optional.ejb; import java.io.BufferedReader; import java.io.File; -import java.io.FileInputStream; import java.io.IOException; import java.io.InputStream; import java.io.InputStreamReader; +import java.nio.file.Files; +import java.nio.file.Paths; import java.util.ArrayList; import java.util.Date; import java.util.HashMap; @@ -729,7 +730,7 @@ public class IPlanetEjbc { location = (String) fileDtds.get(publicId); if (location != null) { // closed when the InputSource is closed - inputStream = new FileInputStream(location); //NOSONAR + inputStream = Files.newInputStream(Paths.get(location)); //NOSONAR } } } catch (IOException e) { diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/WeblogicDeploymentTool.java b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/WeblogicDeploymentTool.java index 6495e97dd..cc1bd90aa 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/WeblogicDeploymentTool.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/WeblogicDeploymentTool.java @@ -18,10 +18,9 @@ package org.apache.tools.ant.taskdefs.optional.ejb; import java.io.File; -import java.io.FileInputStream; -import java.io.FileOutputStream; import java.io.IOException; import java.io.InputStream; +import java.nio.file.Files; import java.util.Enumeration; import java.util.Hashtable; import java.util.Iterator; @@ -496,9 +495,8 @@ public class WeblogicDeploymentTool extends GenericDeploymentTool { DescriptorHandler handler = getWeblogicDescriptorHandler(ejbDescriptor.getParentFile()); - saxParser.parse(new InputSource - (new FileInputStream(weblogicDD)), - handler); + saxParser.parse(new InputSource(Files.newInputStream(weblogicDD.toPath())), + handler); Hashtable ht = handler.getFiles(); Enumeration e = ht.keys(); @@ -810,7 +808,7 @@ public class WeblogicDeploymentTool extends GenericDeploymentTool { newWLJarFile.delete(); } - newJarStream = new JarOutputStream(new FileOutputStream(newWLJarFile)); + newJarStream = new JarOutputStream(Files.newOutputStream(newWLJarFile.toPath())); newJarStream.setLevel(0); //Copy files from old weblogic jar diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/WebsphereDeploymentTool.java b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/WebsphereDeploymentTool.java index da84f245f..63caf5075 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/ejb/WebsphereDeploymentTool.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/ejb/WebsphereDeploymentTool.java @@ -18,9 +18,9 @@ package org.apache.tools.ant.taskdefs.optional.ejb; import java.io.File; -import java.io.FileOutputStream; import java.io.IOException; import java.io.InputStream; +import java.nio.file.Files; import java.util.Enumeration; import java.util.Hashtable; import java.util.Iterator; @@ -775,7 +775,7 @@ public class WebsphereDeploymentTool extends GenericDeploymentTool { newwasJarFile.delete(); } - newJarStream = new JarOutputStream(new FileOutputStream(newwasJarFile)); + newJarStream = new JarOutputStream(Files.newOutputStream(newwasJarFile.toPath())); newJarStream.setLevel(0); //Copy files from old websphere jar diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibManifestTask.java b/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibManifestTask.java index 401dcfb6a..a5105e24b 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibManifestTask.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/extension/JarLibManifestTask.java @@ -18,8 +18,9 @@ package org.apache.tools.ant.taskdefs.optional.extension; import java.io.File; -import java.io.FileOutputStream; import java.io.IOException; +import java.io.OutputStream; +import java.nio.file.Files; import java.util.ArrayList; import java.util.Iterator; import java.util.jar.Attributes; @@ -214,9 +215,9 @@ public final class JarLibManifestTask extends Task { * @throws IOException if error writing file */ private void writeManifest(final Manifest manifest) throws IOException { - FileOutputStream output = null; + OutputStream output = null; try { - output = new FileOutputStream(destFile); + output = Files.newOutputStream(destFile.toPath()); manifest.write(output); output.flush(); } finally { diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/i18n/Translate.java b/src/main/org/apache/tools/ant/taskdefs/optional/i18n/Translate.java index 82731fe9e..685468ad5 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/i18n/Translate.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/i18n/Translate.java @@ -20,11 +20,12 @@ package org.apache.tools.ant.taskdefs.optional.i18n; import java.io.BufferedReader; import java.io.BufferedWriter; import java.io.File; -import java.io.FileInputStream; -import java.io.FileOutputStream; import java.io.IOException; +import java.io.InputStream; import java.io.InputStreamReader; +import java.io.OutputStream; import java.io.OutputStreamWriter; +import java.nio.file.Files; import java.util.Hashtable; import java.util.Locale; import java.util.Vector; @@ -407,9 +408,9 @@ public class Translate extends MatchingTask { private void processBundle(final String bundleFile, final int i, final boolean checkLoaded) throws BuildException { final File propsFile = getProject().resolveFile(bundleFile + ".properties"); - FileInputStream ins = null; + InputStream ins = null; try { - ins = new FileInputStream(propsFile); + ins = Files.newInputStream(propsFile.toPath()); loaded = true; bundleLastModified[i] = propsFile.lastModified(); log("Using " + propsFile, Project.MSG_DEBUG); @@ -429,7 +430,7 @@ public class Translate extends MatchingTask { * Load resourceMap with key value pairs. Values of existing keys * are not overwritten. Bundle's encoding scheme is used. */ - private void loadResourceMap(FileInputStream ins) throws BuildException { + private void loadResourceMap(InputStream ins) throws BuildException { try { BufferedReader in = null; InputStreamReader isr = new InputStreamReader(ins, bundleEncoding); @@ -551,9 +552,9 @@ public class Translate extends MatchingTask { BufferedWriter out = null; BufferedReader in = null; try { - FileOutputStream fos = new FileOutputStream(dest); + OutputStream fos = Files.newOutputStream(dest.toPath()); out = new BufferedWriter(new OutputStreamWriter(fos, destEncoding)); - FileInputStream fis = new FileInputStream(src); + InputStream fis = Files.newInputStream(src.toPath()); in = new BufferedReader(new InputStreamReader(fis, srcEncoding)); String line; LineTokenizer lineTokenizer = new LineTokenizer(); diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/image/Image.java b/src/main/org/apache/tools/ant/taskdefs/optional/image/Image.java index 9b3766e05..5cef00933 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/image/Image.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/image/Image.java @@ -18,8 +18,9 @@ package org.apache.tools.ant.taskdefs.optional.image; import java.io.File; -import java.io.FileOutputStream; import java.io.IOException; +import java.io.OutputStream; +import java.nio.file.Files; import java.util.Locale; import java.util.Vector; @@ -316,9 +317,9 @@ public class Image extends MatchingTask { newFile.delete(); } - FileOutputStream stream = null; + OutputStream stream = null; try { - stream = new FileOutputStream(newFile); + stream = Files.newOutputStream(newFile.toPath()); JAI.create("encode", image, stream, str_encoding.toUpperCase(Locale.ENGLISH), diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/jlink/jlink.java b/src/main/org/apache/tools/ant/taskdefs/optional/jlink/jlink.java index 5d45cfcc5..4f3cff928 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/jlink/jlink.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/jlink/jlink.java @@ -24,10 +24,10 @@ package org.apache.tools.ant.taskdefs.optional.jlink; import java.io.BufferedInputStream; import java.io.File; -import java.io.FileInputStream; -import java.io.FileOutputStream; import java.io.IOException; import java.io.InputStream; +import java.nio.file.Files; +import java.nio.file.Paths; import java.util.Enumeration; import java.util.Vector; import java.util.zip.CRC32; @@ -145,7 +145,7 @@ public class jlink { * @throws Exception on error. */ public void link() throws Exception { //NOSONAR - ZipOutputStream output = new ZipOutputStream(new FileOutputStream(outfile)); + ZipOutputStream output = new ZipOutputStream(Files.newOutputStream(Paths.get(outfile))); if (compression) { output.setMethod(ZipOutputStream.DEFLATED); @@ -303,7 +303,7 @@ public class jlink { // see if the file is in fact a .class file, and determine its actual name. InputStream input = null; try { - input = new FileInputStream(file); + input = Files.newInputStream(file.toPath()); String className = ClassNameReader.getClassName(input); if (className != null) { @@ -337,7 +337,7 @@ public class jlink { if (!compress) { entry.setCrc(calcChecksum(file)); } - FileInputStream input = new FileInputStream(file); + InputStream input = Files.newInputStream(file.toPath()); addToOutputStream(output, input, entry); } @@ -422,7 +422,7 @@ public class jlink { * is not compressed. */ private long calcChecksum(File f) throws IOException { - BufferedInputStream in = new BufferedInputStream(new FileInputStream(f)); + BufferedInputStream in = new BufferedInputStream(Files.newInputStream(f.toPath())); return calcChecksum(in); } diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/junit/AggregateTransformer.java b/src/main/org/apache/tools/ant/taskdefs/optional/junit/AggregateTransformer.java index ca4707458..026412fe6 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/junit/AggregateTransformer.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/junit/AggregateTransformer.java @@ -18,11 +18,11 @@ package org.apache.tools.ant.taskdefs.optional.junit; import java.io.File; -import java.io.FileInputStream; import java.io.FileNotFoundException; import java.io.IOException; import java.io.InputStream; import java.net.URL; +import java.nio.file.Files; import java.util.Iterator; import java.util.List; import java.util.Vector; @@ -176,7 +176,7 @@ public class AggregateTransformer { protected void setXmlfile(File xmlfile) throws BuildException { try { DocumentBuilder builder = privateDBFactory.newDocumentBuilder(); - try (InputStream in = new FileInputStream(xmlfile)) { + try (InputStream in = Files.newInputStream(xmlfile.toPath())) { Document doc = builder.parse(in); setXmlDocument(doc); } diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/junit/FormatterElement.java b/src/main/org/apache/tools/ant/taskdefs/optional/junit/FormatterElement.java index f9fbcb0ae..6587b1d1d 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/junit/FormatterElement.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/junit/FormatterElement.java @@ -20,12 +20,12 @@ package org.apache.tools.ant.taskdefs.optional.junit; import java.io.BufferedOutputStream; import java.io.File; -import java.io.FileOutputStream; import java.io.IOException; import java.io.OutputStream; import java.lang.reflect.Field; import java.lang.reflect.InvocationTargetException; import java.lang.reflect.Method; +import java.nio.file.Files; import org.apache.tools.ant.BuildException; import org.apache.tools.ant.Project; @@ -378,7 +378,7 @@ public class FormatterElement { public void write(int b) throws IOException { synchronized (this) { if (outputStream == null) { - outputStream = new BufferedOutputStream(new FileOutputStream(file)); + outputStream = new BufferedOutputStream(Files.newOutputStream(file.toPath())); } } outputStream.write(b); diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTask.java b/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTask.java index 6a69d2396..dcb2a98d4 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTask.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTask.java @@ -21,7 +21,6 @@ package org.apache.tools.ant.taskdefs.optional.junit; import java.io.BufferedReader; import java.io.BufferedWriter; import java.io.File; -import java.io.FileOutputStream; import java.io.FileReader; import java.io.FileWriter; import java.io.IOException; @@ -29,6 +28,7 @@ import java.io.OutputStream; import java.io.PrintStream; import java.lang.reflect.Constructor; import java.net.URL; +import java.nio.file.Files; import java.security.AccessController; import java.security.PrivilegedAction; import java.util.ArrayList; @@ -1243,7 +1243,7 @@ public class JUnitTask extends Task { props.put(key, p.get(key)); } try { - final FileOutputStream outstream = new FileOutputStream(propsFile); + final OutputStream outstream = Files.newOutputStream(propsFile.toPath()); props.store(outstream, "Ant JUnitTask generated properties file"); outstream.close(); } catch (final java.io.IOException e) { @@ -1953,7 +1953,7 @@ public class JUnitTask extends Task { final File outFile = getOutput(fe, test); if (outFile != null) { try { - out = new FileOutputStream(outFile); + out = Files.newOutputStream(outFile.toPath()); } catch (final IOException e) { // ignore } diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTestRunner.java b/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTestRunner.java index c7d39e096..ea7524da8 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTestRunner.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTestRunner.java @@ -22,15 +22,17 @@ import java.io.BufferedReader; import java.io.BufferedWriter; import java.io.ByteArrayOutputStream; import java.io.File; -import java.io.FileInputStream; import java.io.FileWriter; import java.io.IOException; +import java.io.InputStream; import java.io.OutputStream; import java.io.PrintStream; import java.io.StringReader; import java.io.StringWriter; import java.lang.reflect.Method; import java.lang.reflect.Modifier; +import java.nio.file.Files; +import java.nio.file.Paths; import java.util.Enumeration; import java.util.Hashtable; import java.util.Properties; @@ -940,8 +942,8 @@ public class JUnitTestRunner implements TestListener, JUnitTaskMirror.JUnitTestR System.exit(ERRORS); } } else if (args[i].startsWith(Constants.PROPSFILE)) { - final FileInputStream in = new FileInputStream(args[i] - .substring(Constants.PROPSFILE.length())); + final InputStream in = Files.newInputStream(Paths.get(args[i] + .substring(Constants.PROPSFILE.length()))); props.load(in); in.close(); } else if (args[i].startsWith(Constants.SHOWOUTPUT)) { diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLResultAggregator.java b/src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLResultAggregator.java index 97e2647bc..92e3553b8 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLResultAggregator.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/junit/XMLResultAggregator.java @@ -19,11 +19,11 @@ package org.apache.tools.ant.taskdefs.optional.junit; import java.io.BufferedOutputStream; import java.io.File; -import java.io.FileOutputStream; import java.io.IOException; import java.io.OutputStream; import java.io.OutputStreamWriter; import java.io.PrintWriter; +import java.nio.file.Files; import java.util.Enumeration; import java.util.Vector; @@ -213,7 +213,7 @@ public class XMLResultAggregator extends Task implements XMLConstants { * @throws IOException thrown if there is an error while writing the content. */ protected void writeDOMTree(Document doc, File file) throws IOException { - try (OutputStream os = new FileOutputStream(file); + try (OutputStream os = Files.newOutputStream(file.toPath()); PrintWriter wri = new PrintWriter(new OutputStreamWriter(new BufferedOutputStream(os), "UTF8"))) { wri.write("<?xml version=\"1.0\" encoding=\"UTF-8\" ?>\n"); (new DOMElementWriter()).write(doc.getDocumentElement(), wri, 0, " "); diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/BuiltinNative2Ascii.java b/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/BuiltinNative2Ascii.java index 36e46c314..244b8c140 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/BuiltinNative2Ascii.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/native2ascii/BuiltinNative2Ascii.java @@ -20,14 +20,13 @@ package org.apache.tools.ant.taskdefs.optional.native2ascii; import java.io.BufferedReader; import java.io.BufferedWriter; import java.io.File; -import java.io.FileInputStream; -import java.io.FileOutputStream; import java.io.FileReader; import java.io.FileWriter; import java.io.IOException; import java.io.InputStreamReader; import java.io.OutputStreamWriter; import java.io.Writer; +import java.nio.file.Files; import org.apache.tools.ant.BuildException; import org.apache.tools.ant.taskdefs.optional.Native2Ascii; @@ -61,7 +60,7 @@ public class BuiltinNative2Ascii implements Native2AsciiAdapter { boolean reverse) throws IOException { if (!reverse && encoding != null) { return new BufferedReader(new InputStreamReader( - new FileInputStream(srcFile), encoding)); + Files.newInputStream(srcFile.toPath()), encoding)); } return new BufferedReader(new FileReader(srcFile)); } @@ -73,7 +72,7 @@ public class BuiltinNative2Ascii implements Native2AsciiAdapter { } if (encoding != null) { return new BufferedWriter( - new OutputStreamWriter(new FileOutputStream(destFile), + new OutputStreamWriter(Files.newOutputStream(destFile.toPath()), encoding)); } return new BufferedWriter(new FileWriter(destFile)); diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java b/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java index b78370657..a9d079c2e 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java @@ -21,12 +21,11 @@ import java.io.BufferedInputStream; import java.io.BufferedOutputStream; import java.io.BufferedWriter; import java.io.File; -import java.io.FileInputStream; -import java.io.FileOutputStream; import java.io.FileWriter; import java.io.IOException; import java.io.InputStream; import java.io.OutputStream; +import java.nio.file.Files; import java.text.SimpleDateFormat; import java.util.Collection; import java.util.Date; @@ -1957,7 +1956,7 @@ public class FTP extends Task implements FTPTaskConfig { // create a local temporary file FILE_UTILS.createNewFile(tempFile); long localTimeStamp = tempFile.lastModified(); - BufferedInputStream instream = new BufferedInputStream(new FileInputStream(tempFile)); + BufferedInputStream instream = new BufferedInputStream(Files.newInputStream(tempFile.toPath())); ftp.storeFile(tempFile.getName(), instream); instream.close(); boolean success = FTPReply.isPositiveCompletion(ftp.getReplyCode()); @@ -2148,7 +2147,7 @@ public class FTP extends Task implements FTPTaskConfig { log("transferring " + file.getAbsolutePath()); } - instream = new BufferedInputStream(new FileInputStream(file)); + instream = new BufferedInputStream(Files.newInputStream(file.toPath())); createParents(ftp, filename); @@ -2278,7 +2277,7 @@ public class FTP extends Task implements FTPTaskConfig { if (!pdir.exists()) { pdir.mkdirs(); } - outstream = new BufferedOutputStream(new FileOutputStream(file)); + outstream = new BufferedOutputStream(Files.newOutputStream(file.toPath())); ftp.retrieveFile(resolveFile(filename), outstream); if (!FTPReply.isPositiveCompletion(ftp.getReplyCode())) { diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java b/src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java index 6cb79c833..35f01b355 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java @@ -21,12 +21,11 @@ import java.io.BufferedInputStream; import java.io.BufferedOutputStream; import java.io.BufferedWriter; import java.io.File; -import java.io.FileInputStream; -import java.io.FileOutputStream; import java.io.FileWriter; import java.io.IOException; import java.io.InputStream; import java.io.OutputStream; +import java.nio.file.Files; import java.text.SimpleDateFormat; import java.util.Date; import java.util.Enumeration; @@ -1346,7 +1345,7 @@ public class FTPTaskMirrorImpl implements FTPTaskMirror { // create a local temporary file FILE_UTILS.createNewFile(tempFile); long localTimeStamp = tempFile.lastModified(); - BufferedInputStream instream = new BufferedInputStream(new FileInputStream(tempFile)); + BufferedInputStream instream = new BufferedInputStream(Files.newInputStream(tempFile.toPath())); ftp.storeFile(tempFile.getName(), instream); instream.close(); boolean success = FTPReply.isPositiveCompletion(ftp.getReplyCode()); @@ -1535,7 +1534,7 @@ public class FTPTaskMirrorImpl implements FTPTaskMirror { task.log("transferring " + file.getAbsolutePath()); } - instream = new BufferedInputStream(new FileInputStream(file)); + instream = new BufferedInputStream(Files.newInputStream(file.toPath())); createParents(ftp, filename); @@ -1666,7 +1665,7 @@ public class FTPTaskMirrorImpl implements FTPTaskMirror { if (!pdir.exists()) { pdir.mkdirs(); } - outstream = new BufferedOutputStream(new FileOutputStream(file)); + outstream = new BufferedOutputStream(Files.newOutputStream(file.toPath())); ftp.retrieveFile(resolveFile(filename), outstream); if (!FTPReply.isPositiveCompletion(ftp.getReplyCode())) { diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/pvcs/Pvcs.java b/src/main/org/apache/tools/ant/taskdefs/optional/pvcs/Pvcs.java index dd6016a8c..7bcfef93b 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/pvcs/Pvcs.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/pvcs/Pvcs.java @@ -21,10 +21,11 @@ import java.io.BufferedReader; import java.io.BufferedWriter; import java.io.File; import java.io.FileNotFoundException; -import java.io.FileOutputStream; import java.io.FileReader; import java.io.FileWriter; import java.io.IOException; +import java.io.OutputStream; +import java.nio.file.Files; import java.text.MessageFormat; import java.text.ParseException; import java.util.Enumeration; @@ -198,7 +199,7 @@ public class Pvcs extends org.apache.tools.ant.Task { try { Random rand = new Random(System.currentTimeMillis()); tmp = new File("pvcs_ant_" + rand.nextLong() + ".log"); - FileOutputStream fos = new FileOutputStream(tmp); + OutputStream fos = Files.newOutputStream(tmp.toPath()); tmp2 = new File("pvcs_ant_" + rand.nextLong() + ".log"); log(commandLine.describeCommand(), Project.MSG_VERBOSE); try { diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ssh/SSHExec.java b/src/main/org/apache/tools/ant/taskdefs/optional/ssh/SSHExec.java index 7d497098c..394200335 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/ssh/SSHExec.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/ssh/SSHExec.java @@ -22,13 +22,13 @@ import java.io.BufferedReader; import java.io.ByteArrayInputStream; import java.io.ByteArrayOutputStream; import java.io.File; -import java.io.FileInputStream; import java.io.FileWriter; import java.io.IOException; import java.io.InputStream; import java.io.InputStreamReader; import java.io.OutputStream; import java.io.StringReader; +import java.nio.file.Files; import org.apache.tools.ant.BuildException; import org.apache.tools.ant.Project; @@ -360,7 +360,7 @@ public class SSHExec extends SSHBase { InputStream istream = null; if (inputFile != null) { try { - istream = new FileInputStream(inputFile); + istream = Files.newInputStream(inputFile.toPath()); } catch (final IOException e) { // because we checked the existence before, this one // shouldn't happen What if the file exists, but there diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ssh/ScpFromMessage.java b/src/main/org/apache/tools/ant/taskdefs/optional/ssh/ScpFromMessage.java index b6b9b01b7..8775c1190 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/ssh/ScpFromMessage.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/ssh/ScpFromMessage.java @@ -21,10 +21,10 @@ package org.apache.tools.ant.taskdefs.optional.ssh; import java.io.ByteArrayOutputStream; import java.io.EOFException; import java.io.File; -import java.io.FileOutputStream; import java.io.IOException; import java.io.InputStream; import java.io.OutputStream; +import java.nio.file.Files; import org.apache.tools.ant.util.FileUtils; @@ -262,7 +262,7 @@ public class ScpFromMessage extends AbstractSshMessage { sendAck(out); // read a content of lfile - final FileOutputStream fos = new FileOutputStream(localFile); + final OutputStream fos = Files.newOutputStream(localFile.toPath()); int length; long totalLength = 0; final long startTime = System.currentTimeMillis(); diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/ssh/ScpToMessage.java b/src/main/org/apache/tools/ant/taskdefs/optional/ssh/ScpToMessage.java index 7b0a0f29f..214dd4ea1 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/ssh/ScpToMessage.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/ssh/ScpToMessage.java @@ -19,10 +19,10 @@ package org.apache.tools.ant.taskdefs.optional.ssh; import java.io.File; -import java.io.FileInputStream; import java.io.IOException; import java.io.InputStream; import java.io.OutputStream; +import java.nio.file.Files; import java.util.Iterator; import java.util.List; @@ -363,7 +363,7 @@ public class ScpToMessage extends AbstractSshMessage { waitForAck(in); // send a content of lfile - final FileInputStream fis = new FileInputStream(localFile); + final InputStream fis = Files.newInputStream(localFile.toPath()); final byte[] buf = new byte[BUFFER_SIZE]; final long startTime = System.currentTimeMillis(); long totalLength = 0; diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java b/src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java index e83c0b6b5..a45b74ffb 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java @@ -32,12 +32,12 @@ package org.apache.tools.ant.taskdefs.optional.unix; import java.io.BufferedInputStream; import java.io.BufferedOutputStream; import java.io.File; -import java.io.FileInputStream; import java.io.FileNotFoundException; -import java.io.FileOutputStream; import java.io.IOException; import java.io.InputStream; +import java.io.OutputStream; import java.io.PrintStream; +import java.nio.file.Files; import java.util.HashSet; import java.util.Hashtable; import java.util.Iterator; @@ -437,7 +437,7 @@ public class Symlink extends DispatchTask { BufferedOutputStream bos = null; try { bos = new BufferedOutputStream( - new FileOutputStream(new File(dir, linkFileName))); + Files.newOutputStream(new File(dir, linkFileName).toPath())); properties.store(bos, "Symlinks from " + dir); } catch (IOException ioe) { throw new BuildException(ioe, getLocation()); @@ -567,7 +567,7 @@ public class Symlink extends DispatchTask { Properties lnks = new Properties(); InputStream is = null; try { - is = new BufferedInputStream(new FileInputStream(inc)); + is = new BufferedInputStream(Files.newInputStream(inc.toPath())); lnks.load(is); pf = pf.getCanonicalFile(); } catch (FileNotFoundException fnfe) { diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/xz/Unxz.java b/src/main/org/apache/tools/ant/taskdefs/optional/xz/Unxz.java index a98ae6d2c..f55fb7c3b 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/xz/Unxz.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/xz/Unxz.java @@ -18,9 +18,10 @@ package org.apache.tools.ant.taskdefs.optional.xz; -import java.io.FileOutputStream; import java.io.IOException; import java.io.InputStream; +import java.io.OutputStream; +import java.nio.file.Files; import org.apache.tools.ant.BuildException; import org.apache.tools.ant.taskdefs.Unpack; @@ -57,11 +58,11 @@ public class Unxz extends Unpack { log("Expanding " + srcResource.getName() + " to " + dest.getAbsolutePath()); - FileOutputStream out = null; + OutputStream out = null; XZInputStream zIn = null; InputStream fis = null; try { - out = new FileOutputStream(dest); + out = Files.newOutputStream(dest.toPath()); fis = srcResource.getInputStream(); zIn = new XZInputStream(fis); byte[] buffer = new byte[BUFFER_SIZE]; diff --git a/src/main/org/apache/tools/ant/taskdefs/optional/xz/Xz.java b/src/main/org/apache/tools/ant/taskdefs/optional/xz/Xz.java index d88f91052..76031921c 100644 --- a/src/main/org/apache/tools/ant/taskdefs/optional/xz/Xz.java +++ b/src/main/org/apache/tools/ant/taskdefs/optional/xz/Xz.java @@ -19,8 +19,8 @@ package org.apache.tools.ant.taskdefs.optional.xz; import java.io.BufferedOutputStream; -import java.io.FileOutputStream; import java.io.IOException; +import java.nio.file.Files; import org.apache.tools.ant.BuildException; import org.apache.tools.ant.util.FileUtils; @@ -44,7 +44,7 @@ public class Xz extends Pack { protected void pack() { XZOutputStream zOut = null; try { - zOut = new XZOutputStream(new FileOutputStream(zipFile), + zOut = new XZOutputStream(Files.newOutputStream(zipFile.toPath()), new LZMA2Options()); zipResource(getSrcResource(), zOut); } catch (IOException ioe) { |