diff options
| author | Jan Matèrne <jhm@apache.org> | 2014-06-28 21:09:33 +0200 |
|---|---|---|
| committer | Jan Matèrne <jhm@apache.org> | 2014-06-28 21:09:33 +0200 |
| commit | 211b7188af7eb761ab8646f9a8cd847aca9db026 (patch) | |
| tree | 2f1617acf95bd19e0f8dbf97065d89ce595e9315 /src/etc/checkstyle | |
| parent | 7472cb03e65eaa3877e704a0af5bafd7eecb4162 (diff) | |
| download | ant-211b7188af7eb761ab8646f9a8cd847aca9db026.tar.gz | |
update checkstyle (check 'DoubleCheckLocking' was removed in CS)
Diffstat (limited to 'src/etc/checkstyle')
| -rw-r--r-- | src/etc/checkstyle/checkstyle-config | 35 |
1 files changed, 20 insertions, 15 deletions
diff --git a/src/etc/checkstyle/checkstyle-config b/src/etc/checkstyle/checkstyle-config index 160b098d3..b3232be7b 100644 --- a/src/etc/checkstyle/checkstyle-config +++ b/src/etc/checkstyle/checkstyle-config @@ -18,6 +18,19 @@ <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.1//EN" "http://www.puppycrawl.com/dtds/configuration_1_1.dtd"> <module name="Checker"> + + <!-- required licence file --> + <module name="Header"> + <property name="headerFile" value="${config.dir}/RequiredHeader.txt"/> + <property name="ignoreLines" value="2"/> + </module> + + <!-- size limits --> + <module name="FileLength"/> + + <module name="FileTabCharacter"/> + + <module name="TreeWalker"> <!-- Javadoc requirements --> <module name="JavadocType"> @@ -42,12 +55,6 @@ <module name="ParameterName"/> <module name="StaticVariableName"/> - <!-- required licence file --> - <module name="Header"> - <property name="headerFile" value="${config.dir}/RequiredHeader.txt"/> - <property name="ignoreLines" value="2"/> - </module> - <!-- Import conventions --> <module name="AvoidStarImport"/> <module name="IllegalImport"/> @@ -55,7 +62,6 @@ <module name="UnusedImports"/> <!-- size limits --> - <module name="FileLength"/> <module name="LineLength"> <property name="max" value="100"/> <property name="ignorePattern" value="^ *\* *[^ ]+$"/> @@ -69,7 +75,6 @@ <module name="NoWhitespaceBefore"/> <module name="OperatorWrap"/> <module name="ParenPad"/> - <module name="TabCharacter"/> <module name="WhitespaceAfter"/> <module name="WhitespaceAround"/> @@ -77,7 +82,6 @@ <module name="ModifierOrder"/> <module name="RedundantModifier"/> - <!-- Checks for blocks --> <module name="AvoidNestedBlocks"/> <module name="EmptyBlock"> @@ -87,10 +91,8 @@ <module name="NeedBraces"/> <module name="RightCurly"/> - <!-- Checks for common coding problems --> <!--<module name="AvoidInlineConditionals"/> --> - <module name="DoubleCheckedLocking"/> <module name="EmptyStatement"/> <module name="EqualsHashCode"/> <module name="IllegalInstantiation"> @@ -116,19 +118,22 @@ <!-- Miscellaneous other checks. --> <module name="ArrayTypeStyle"/> - <module name="GenericIllegalRegexp"> - <property name="format" value="\s+$"/> - <property name="message" value="Line has trailing spaces."/> - </module> <!-- <module name="TodoComment"/> --> <module name="UpperEll"/> <!-- allow comment suppression of checks --> <module name="FileContentsHolder"/> </module> + + <module name="RegexpSingleline"> + <!-- \s matches whitespace character, $ matches end of line. --> + <property name="format" value="\s+$"/> + </module> + <!-- <module name="au.com.redhillconsulting.simian.SimianCheck"/> --> <module name="SuppressionCommentFilter"> <property name="offCommentFormat" value="CheckStyle\:([\w\|]+) *OFF"/> <property name="onCommentFormat" value="CheckStyle\:([\w\|]+) *ON"/> <property name="checkFormat" value="$1"/> </module> + </module> |
