summaryrefslogtreecommitdiff
path: root/server/failover.c
diff options
context:
space:
mode:
authorMark Andrews <marka@isc.org>2013-05-15 10:49:54 +1000
committerMark Andrews <marka@isc.org>2013-05-15 10:49:54 +1000
commitdc9d7b08aa62743e7cbfb1795c324b3c1773ecd0 (patch)
tree5f15f5dc67d166c072f276867a0172071bcaff9f /server/failover.c
parent7133470475b841299f06487039be10003d020456 (diff)
downloadisc-dhcp-dc9d7b08aa62743e7cbfb1795c324b3c1773ecd0.tar.gz
- Silence benign static analysis warnings.
[ISC-Bugs #33428]
Diffstat (limited to 'server/failover.c')
-rw-r--r--server/failover.c8
1 files changed, 3 insertions, 5 deletions
diff --git a/server/failover.c b/server/failover.c
index e0a416e2..7a9ae9e2 100644
--- a/server/failover.c
+++ b/server/failover.c
@@ -3,7 +3,7 @@
Failover protocol support code... */
/*
- * Copyright (c) 2004-2012 by Internet Systems Consortium, Inc. ("ISC")
+ * Copyright (c) 2004-2013 by Internet Systems Consortium, Inc. ("ISC")
* Copyright (c) 1999-2003 by Internet Software Consortium
*
* Permission to use, copy, modify, and distribute this software for any
@@ -893,8 +893,7 @@ isc_result_t dhcp_failover_link_get_value (omapi_object_t *h,
return omapi_make_int_value (value, name,
(int)link -> peer_port, MDL);
} else if (!omapi_ds_strcmp (name, "link-state")) {
- if (link -> state < 0 ||
- link -> state >= dhcp_flink_state_max)
+ if (link -> state >= dhcp_flink_state_max)
return omapi_make_string_value (value, name,
"invalid link state",
MDL);
@@ -954,8 +953,7 @@ isc_result_t dhcp_failover_link_stuff_values (omapi_object_t *c,
status = omapi_connection_put_name (c, "link-state");
if (status != ISC_R_SUCCESS)
return status;
- if (link -> state < 0 ||
- link -> state >= dhcp_flink_state_max)
+ if (link -> state >= dhcp_flink_state_max)
status = omapi_connection_put_string (c, "invalid link state");
else
status = (omapi_connection_put_string